Fix Debian GitHub build & zstd CMake error

[wonglkd]

1. Workaround for Debian Docker image bug that is breaking Debian build on GitHub (Explicitly mark Git repo as safe).
2. Pin zstd to a commit that resolves problems with older CMakes (note: affects all OSes, not just Debian)

Context for 1: In latest Debian Docker image , there is a regression that affects the checkout action.

From actions/checkout#1169:

• Checkout runs, and runs /usr/bin/git config --global --add safe.directory
• The global .gitconfig does not exist
• Any calls to git remain unsafe/dubious

The suggested workaround was to use --system instead of --global.

Test Plan: See if GitHub Action Debian build is fixed.

[wonglkd]

It fixed the issue above, but the Debian build now fails on the cmake/zstd issue. zstd 1.5.4 was released in Jan-23 but preceding v1.5.2 was in Jan-22 (a whole year in-between), so not sure when we might see the fix (on dev branch) merged into release. We could do what is done by this repo, i.e., cherrypicking the commit:

git fetch origin dev
git cherry-pick 8420502e

Or pin it at 1.5.2 or that commit with the fix (con: need to manually update it later), or use the dev branch (con: potentially less stable than release).

[wonglkd]

Decided to pin zstd to the commit that has the cmake fix. Pinning it might be a good idea anyway for stability. Doing it in general and not just for Debian since it affects all systems with an older cmake.

[wonglkd]

Debian uses gcc-8.3 and thus now fails on the issue fixed by #201.

[jaesoo-fb]

Thanks for working on this.

[wonglkd]

Updated as suggested. Thanks! Also, I got a successful Debian build on my fork after I cherrypicked #201: https://github.com/wonglkd/CacheLib-1/actions/runs/4298872004/jobs/7493484190

[wonglkd]

Made requested changes and rebased.

[jaesoo-fb]

Thanks for fixing this.

[jaesoo-fb]

Somehow I cannot import and merge this. @wonglkd Just in case, could you rebase?

[wonglkd]

@jaesoo-fb rebased!

[facebook-github-bot]

@jaesoo-fb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@jaesoo-fb merged this pull request in 185bbe6.