Skip to content

fix: existing log files being truncated on restart - #25

Closed
cluck wants to merge 2 commits into
facebook:mainfrom
cluck:fix-log-truncated
Closed

fix: existing log files being truncated on restart#25
cluck wants to merge 2 commits into
facebook:mainfrom
cluck:fix-log-truncated

Conversation

@cluck

@cluckcluck commented Feb 15, 2026

Copy link
Copy Markdown

The existing modules pass O_TRUNC flag to open() for opening the (usually pre-existing) logfiles.
This results in all existing log entries to be discarded.

This PR changes O_TRUNC to O_APPEND.
It also add an example logrotate config file.

@meta-cla

meta-claBot commented Feb 15, 2026

Copy link
Copy Markdown

Hi @cluck!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 15, 2026
@meta-cla

meta-claBot commented Feb 15, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@cluck