Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Performance logging - #385
Closed
vreis wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Feb 10, 2020
Contributor
This pull request was exported from Phabricator. Differential Revision: D19739656 |
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@vreis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
vreis added a commit
to vreis/ClassyVision-2
that referenced
this pull request
Feb 10, 2020
Summary: Pull Request resolved: facebookresearch#385 Test Plan: . Differential Revision: D19739656 Pulled By: vreis fbshipit-source-id: 347772745f2811bf2947128a23986161395c526d
facebook-github-bot
commented
Feb 10, 2020
Contributor
This pull request was exported from Phabricator. Differential Revision: D19739656 |
Summary: This changes ClassificationTask to compute some high-level performance numbers (img/sec) and plot them in Tensorboard. This is useful for comparing performance optimizations since we now get a "blessed" performance number. Also, this was done in a way that's comparable to NVidia's benchmarks (e.g. https://ngc.nvidia.com/catalog/model-scripts/nvidia:resnet_50_v1_5_for_pytorch/performance), so we know how well we're doing compared to other implementations. In terms of implementation, I could have made a hook instead, but decided against it for two reasons: (1) it would introduce dependencies between hooks; (2) we want to control precisely when the timing measurements are taken; Pull Request resolved: facebookresearch#385 Test Plan: ./classy_train.py --config configs/template_config.json Reviewed By: mannatsingh Differential Revision: D19739656 Pulled By: vreis fbshipit-source-id: a63c394308851e6accee9d260d9cb1d972f33a7f
facebook-github-bot
commented
Feb 11, 2020
Contributor
This pull request was exported from Phabricator. Differential Revision: D19739656 |
facebook-github-bot
commented
Feb 11, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes ClassificationTask to compute some high-level performance
numbers (img/sec) and plot them in Tensorboard. This is useful for comparing
performance optimizations since we now get a "blessed" performance number.
Also, this was done in a way that's comparable to NVidia's benchmarks (e.g. https://ngc.nvidia.com/catalog/model-scripts/nvidia:resnet_50_v1_5_for_pytorch/performance), so we know how well we're doing compared to other implementations.
In terms of implementation, I could have made a hook instead, but decided against it for two reasons: (1) it would introduce dependencies between hooks; (2) we want to control precisely when the timing measurements are taken;