Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Add a tutorial which gives an overview of classy models - #485
Closed
mannatsingh wants to merge 7 commits into
Closed
Add a tutorial which gives an overview of classy models#485mannatsingh wants to merge 7 commits into
mannatsingh wants to merge 7 commits into
Conversation
Summary:
When setting heads, we do the following currently -
```
model.set_heads({"block3-2": {head.unique_id: head}})
```
This is a redundant structure, since the unique_id is already available in `head`. I was writing a tutorial and I want to show a cleaner API there -
```
model.set_heads({"block3-2": [head]})
```
Differential Revision: D21096621
fbshipit-source-id: 65c1eb5caacf2970d60eb050061aeadf69db94d9Summary: Pull Request resolved: facebookresearch#484 When setting heads, we do the following currently - ``` model.set_heads({"block3-2": {head.unique_id: head}}) ``` This is a redundant structure, since the unique_id is already available in `head`. I was writing a tutorial and I want to show a cleaner API there - ``` model.set_heads({"block3-2": [head]}) ``` Differential Revision: D21096621 fbshipit-source-id: 4dfc87e172390c43e9cd7fce98ad987099542ca2
…ssyVision into export-D21096621
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@mannatsingh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@mannatsingh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@mannatsingh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
commented
Apr 23, 2020
Contributor
@mannatsingh merged this pull request in 4139a5c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.