This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Mass Spring Notebook - #63
Merged
david-boney-jobs merged 15 commits intoJun 9, 2022
Merged
Conversation
juniorrojas
suggested changes
Jun 8, 2022
juniorrojas
left a comment
There was a problem hiding this comment.
Since we haven't found a convenient way to display animations in notebooks, I still think we should simplify this notebook to only show an energy minimization demo instead of numerical integration, but let's plan on merging this numerical integration demo for now and I'll open a new issue to revisit this in the future. A few requests before accepting:
- Do not use the term ODE. We have more than one independent variable (x and y components of multiple point masses), so I guess technically we're dealing with PDEs here, but I'd prefer to avoid the term PDE in this notebook. Let's just use "mass-spring system" if possible, or "differential equation" in general if necessary.
- Fix typo MassStringSystem -> MassSpringSystem
- Add missing hyphen "user defined type" -> "user-defined type"
Contributor
Author
|
@juniorrojas |
juniorrojas
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Junior's request for a Vector2 class.
Animation not implemented.