Uh oh!
There was an error while loading. Please reload this page.
Fix misleading comments in commsOverlapBench overlap-pair-pgs (#222) - #222
Fix misleading comments in commsOverlapBench overlap-pair-pgs (#222)#222MogicianWu wants to merge 1 commit into
Conversation
@MogicianWu has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103730559. |
…okresearch#222) Summary: Fix three comments in commsOverlapBench.py that incorrectly described the --overlap-pair-pgs feature as creating only "two" process groups. The code actually creates 1 + len(pair_collectives_list) PGs, supporting N concurrent collectives on separate streams. Updated comments to accurately reflect this behavior. Reviewed By: dsjohns2 Differential Revision: D103730559
…okresearch#222) Summary: Fix three comments in commsOverlapBench.py that incorrectly described the --overlap-pair-pgs feature as creating only "two" process groups. The code actually creates 1 + len(pair_collectives_list) PGs, supporting N concurrent collectives on separate streams. Updated comments to accurately reflect this behavior. Reviewed By: dsjohns2 Differential Revision: D103730559
…okresearch#222) Summary: Fix three comments in commsOverlapBench.py that incorrectly described the --overlap-pair-pgs feature as creating only "two" process groups. The code actually creates 1 + len(pair_collectives_list) PGs, supporting N concurrent collectives on separate streams. Updated comments to accurately reflect this behavior. Reviewed By: dsjohns2 Differential Revision: D103730559
Hi @MogicianWu! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary:
Fix three comments in commsOverlapBench.py that incorrectly described the --overlap-pair-pgs feature as creating only "two" process groups. The code actually creates 1 + len(pair_collectives_list) PGs, supporting N concurrent collectives on separate streams. Updated comments to accurately reflect this behavior.
Reviewed By: dsjohns2
Differential Revision: D103730559