Uh oh!
There was an error while loading. Please reload this page.
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
This reverts commit 9316c78.
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
| #[derive(Debug)] | ||
| pub struct Asynchronous { | ||
| appends: Arc<[Box<dyn Append>]>, | ||
| overflow: Overflow, | ||
| state: AppendState, | ||
| } |
There was a problem hiding this comment.
Thanks for @ SpriteOvO's spdlog-rs AsyncPoolSink. I borrow most of the design while change the thread pool to a single background thread.
One open issue is about naming. Since async is a keyword now, we'd better use a different name from Async here. Currently I use Asynchronous, but I'd prefer a shorter name. Considering AsyncPool, perhaps AsyncSingleThread or other.
BTW we need to implement a clean up logic atexit, related to SpriteOvO/spdlog-rs#102
| fn exit(&self) -> Result<(), Error> { | ||
| // fastrace flush accesses thread-local storage, | ||
| // which is not supported in atexit handlers | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
@andylokandy Then we rely on the caller/application to call fastrace::flush on exit, like what we do in ScopeDB.
Uh oh!
There was an error while loading. Please reload this page.
This closes#145.