Uh oh!
There was an error while loading. Please reload this page.
♻️ Replace ESLint and Prettier with Biome to format and lint frontend - #719
Conversation
santigandolfo
commented
Mar 14, 2024
I see that this other PR has been merged: #714
The only reason why I prefer 2 over 1 is that using that approach the git-hooks on the frontend are installed automatically when we run |
tiangolo
commented
Mar 17, 2024
Awesome! This looks cool @santigandolfo! 🚀 We need to keep pre-commit because that's what's used to format the backend and the rest of the code, and Husky expects to be the only git hook handler, disabling pre-commit. 🤓 I'll ask @alejsdev to tweak this PR a bit with some commits on top to adjust the rules to the current code style, to minimize the changes, but taking in a few of them, etc. And then it will be ready, thank you! 🍰 |
tiangolo
commented
Mar 17, 2024
Awesome, thanks @santigandolfo and @alejsdev! 🍰 |
…fastapi#719) Co-authored-by: User <alejsdev@gmail.com> Co-authored-by: Alejandra <90076947+alejsdev@users.noreply.github.com>
I had to modify the
modify-openapi-operationids.jsscript because biome was giving me a lint error because of the use offorEachinstead offor...ofI also disabled some other rules in the linter that were making the project fail without some changes, because I'd prefer the maintainers decide if we want to keep it as it is or not.