✨ Support pattern parameter

[stickm4n]

I faced this issue with Pydantic V2 and there is a simple workaround to it by passing the pattern Field parameter as schema extra:

Ex:

classMyClass(SQLModel)
id: str=Field(unique=True, schema_extra={'pattern': r"^\d{5}$"})

I don't know if this issue was already fixed in another branch, I saw there was a temporary PR already made but closed.

[stickm4n]

@tiangolo@alejsdev or some other maintainer... could you please review this issue?

[svlandeg]

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

[stickm4n]

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

[YuriiMotov]

LGTM!

This keep supporting old ways of specifying pattern (regex parameter, and pattern via schema_extra), but emits warnings in these cases. We will remove this support in the future versions.

[stickm4n]

@YuriiMotov I added a blocking comment, please review it and let me know if you will address it (since it was your change to clean the code and prepare the PR) or should I? Anyway I will be around... 🤠

PS: Annotations were updated for re.Pattern support.

[Graphity]

guys what's the news on this?
mind you the regex parameter is ignored in validation and using it blindly could lead to potential bugs.

[YuriiMotov]

LGTM!

[stickm4n]

I faced this issue with Pydantic V2 and there is a simple workaround to it by passing the pattern Field parameter as schema extra:

Ex:

classMyClass(SQLModel)
id: str=Field(unique=True, schema_extra={'pattern': r"^\d{5}$"})

I don't know if this issue was already fixed in another branch, I saw there was a temporary PR already made but closed.

[stickm4n]

@tiangolo@alejsdev or some other maintainer... could you please review this issue?

[svlandeg]

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

[stickm4n]

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

[YuriiMotov]

LGTM!

This keep supporting old ways of specifying pattern (regex parameter, and pattern via schema_extra), but emits warnings in these cases. We will remove this support in the future versions.

[stickm4n]

@YuriiMotov I added a blocking comment, please review it and let me know if you will address it (since it was your change to clean the code and prepare the PR) or should I? Anyway I will be around... 🤠

PS: Annotations were updated for re.Pattern support.

[Graphity]

guys what's the news on this?
mind you the regex parameter is ignored in validation and using it blindly could lead to potential bugs.

[YuriiMotov]

LGTM!

[stickm4n]

I faced this issue with Pydantic V2 and there is a simple workaround to it by passing the pattern Field parameter as schema extra:

Ex:

classMyClass(SQLModel)
id: str=Field(unique=True, schema_extra={'pattern': r"^\d{5}$"})

I don't know if this issue was already fixed in another branch, I saw there was a temporary PR already made but closed.

[stickm4n]

@tiangolo@alejsdev or some other maintainer... could you please review this issue?

[svlandeg]

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

[stickm4n]

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

[YuriiMotov]

LGTM!

This keep supporting old ways of specifying pattern (regex parameter, and pattern via schema_extra), but emits warnings in these cases. We will remove this support in the future versions.

[stickm4n]

@YuriiMotov I added a blocking comment, please review it and let me know if you will address it (since it was your change to clean the code and prepare the PR) or should I? Anyway I will be around... 🤠

PS: Annotations were updated for re.Pattern support.

[Graphity]

guys what's the news on this?
mind you the regex parameter is ignored in validation and using it blindly could lead to potential bugs.

[YuriiMotov]

LGTM!

[stickm4n]

I faced this issue with Pydantic V2 and there is a simple workaround to it by passing the pattern Field parameter as schema extra:

Ex:

classMyClass(SQLModel)
id: str=Field(unique=True, schema_extra={'pattern': r"^\d{5}$"})

I don't know if this issue was already fixed in another branch, I saw there was a temporary PR already made but closed.

[stickm4n]

@tiangolo@alejsdev or some other maintainer... could you please review this issue?

[svlandeg]

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

[stickm4n]

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

[YuriiMotov]

LGTM!

This keep supporting old ways of specifying pattern (regex parameter, and pattern via schema_extra), but emits warnings in these cases. We will remove this support in the future versions.

[stickm4n]

@YuriiMotov I added a blocking comment, please review it and let me know if you will address it (since it was your change to clean the code and prepare the PR) or should I? Anyway I will be around... 🤠

PS: Annotations were updated for re.Pattern support.

[Graphity]

guys what's the news on this?
mind you the regex parameter is ignored in validation and using it blindly could lead to potential bugs.

[YuriiMotov]

LGTM!

[stickm4n]

I faced this issue with Pydantic V2 and there is a simple workaround to it by passing the pattern Field parameter as schema extra:

Ex:

classMyClass(SQLModel)
id: str=Field(unique=True, schema_extra={'pattern': r"^\d{5}$"})

I don't know if this issue was already fixed in another branch, I saw there was a temporary PR already made but closed.

[stickm4n]

@tiangolo@alejsdev or some other maintainer... could you please review this issue?

[svlandeg]

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

[stickm4n]

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

[YuriiMotov]

LGTM!

This keep supporting old ways of specifying pattern (regex parameter, and pattern via schema_extra), but emits warnings in these cases. We will remove this support in the future versions.

[stickm4n]

@YuriiMotov I added a blocking comment, please review it and let me know if you will address it (since it was your change to clean the code and prepare the PR) or should I? Anyway I will be around... 🤠

PS: Annotations were updated for re.Pattern support.

[Graphity]

guys what's the news on this?
mind you the regex parameter is ignored in validation and using it blindly could lead to potential bugs.

[YuriiMotov]

LGTM!

[stickm4n]

I faced this issue with Pydantic V2 and there is a simple workaround to it by passing the pattern Field parameter as schema extra:

Ex:

classMyClass(SQLModel)
id: str=Field(unique=True, schema_extra={'pattern': r"^\d{5}$"})

I don't know if this issue was already fixed in another branch, I saw there was a temporary PR already made but closed.

[stickm4n]

@tiangolo@alejsdev or some other maintainer... could you please review this issue?

[svlandeg]

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

[stickm4n]

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

[YuriiMotov]

LGTM!

This keep supporting old ways of specifying pattern (regex parameter, and pattern via schema_extra), but emits warnings in these cases. We will remove this support in the future versions.

[stickm4n]

@YuriiMotov I added a blocking comment, please review it and let me know if you will address it (since it was your change to clean the code and prepare the PR) or should I? Anyway I will be around... 🤠

PS: Annotations were updated for re.Pattern support.

[Graphity]

guys what's the news on this?
mind you the regex parameter is ignored in validation and using it blindly could lead to potential bugs.

[YuriiMotov]

LGTM!

[stickm4n]

I faced this issue with Pydantic V2 and there is a simple workaround to it by passing the pattern Field parameter as schema extra:

Ex:

classMyClass(SQLModel)
id: str=Field(unique=True, schema_extra={'pattern': r"^\d{5}$"})

I don't know if this issue was already fixed in another branch, I saw there was a temporary PR already made but closed.

[stickm4n]

@tiangolo@alejsdev or some other maintainer... could you please review this issue?

[svlandeg]

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

[stickm4n]

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

[YuriiMotov]

LGTM!

This keep supporting old ways of specifying pattern (regex parameter, and pattern via schema_extra), but emits warnings in these cases. We will remove this support in the future versions.

[stickm4n]

@YuriiMotov I added a blocking comment, please review it and let me know if you will address it (since it was your change to clean the code and prepare the PR) or should I? Anyway I will be around... 🤠

PS: Annotations were updated for re.Pattern support.

[Graphity]

guys what's the news on this?
mind you the regex parameter is ignored in validation and using it blindly could lead to potential bugs.

[YuriiMotov]

LGTM!

[stickm4n]

I faced this issue with Pydantic V2 and there is a simple workaround to it by passing the pattern Field parameter as schema extra:

Ex:

classMyClass(SQLModel)
id: str=Field(unique=True, schema_extra={'pattern': r"^\d{5}$"})

I don't know if this issue was already fixed in another branch, I saw there was a temporary PR already made but closed.

[stickm4n]

@tiangolo@alejsdev or some other maintainer... could you please review this issue?

[svlandeg]

Thanks for the PR! We're going through the backlog of PRs right now, and will get back to you once we've had the time to review this and consider the (breaking) change 🙏

[stickm4n]

@svlandeg Nice to hear you are taking action on this matter. There is remark, the parameter the was renamed between Pydantic v1 and v2 is regex-> pattern, not as listed in the PR.

The suggestion I made in the PR was to keep both versions compatible when upgrading, but there is an alternative, which is not managing the change between them and just provide the proper type hints.

If you want me to update the PR just let me know, IDK which approach is more adequate for the project.

[YuriiMotov]

LGTM!

This keep supporting old ways of specifying pattern (regex parameter, and pattern via schema_extra), but emits warnings in these cases. We will remove this support in the future versions.

[stickm4n]

@YuriiMotov I added a blocking comment, please review it and let me know if you will address it (since it was your change to clean the code and prepare the PR) or should I? Anyway I will be around... 🤠

PS: Annotations were updated for re.Pattern support.

[Graphity]

guys what's the news on this?
mind you the regex parameter is ignored in validation and using it blindly could lead to potential bugs.

[YuriiMotov]

LGTM!