Uh oh!
There was an error while loading. Please reload this page.
👷 Replace mypy with ty in precommit - #1806
Conversation
📝 Docs previewLast commit becee62 at: https://b232cb93.sqlmodel.pages.dev |
…rs are before it (invalid-legacy-positional-parameter)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # pyproject.toml # uv.lock
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # pyproject.toml # uv.lock
YuriiMotov
left a comment
There was a problem hiding this comment.
Added a few suggestions in the comments. Please, take a look)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
svlandeg
commented
Mar 18, 2026
@YuriiMotov, thanks for the review! I addressed everything, looks better IMO 🙂 |
| # Replicate SQLAlchemy | ||
| def __setattr__(cls, name: str, value: Any) -> None: | ||
| def __setattr__(cls, name: str, value: Any) -> None: # ty: ignore[invalid-method-override] |
YuriiMotov
left a comment
There was a problem hiding this comment.
LGTM!
Just one moment with removing tests/test_select_typing.py from command
Uh oh!
There was an error while loading. Please reload this page.
svlandeg
commented
Mar 25, 2026
Ok, I reviewed it all again, I think it should be fine now 🤞 |
svlandeg
left a comment
There was a problem hiding this comment.
Putting this back in draft as I have a look into updating ty to 0.0.25, which generates a new host of errors.
svlandeg
left a comment
There was a problem hiding this comment.
Apologies for all the back-and-forth here. I updated the PR to use ty 0.0.25 which is actually nicer. And now we also error on warnings. Should be good for a hopefully final review 🙏
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading. Please reload this page.
mypywithtyin precommit,lint.sh& pyproject.toml.typecodes to specifictycodestyhappyI originally set out to have
mypyandtyrun together in precommit, but forsqlmodelI would argue that perhaps we want to removemypyalltogether already now, as it allows us to remove a lot oftype: ignorestatements thattythinks are unnecessary anyway.