Validate SQLModel on all Non-Database Sourced Data#1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ClayGendron wants to merge 4 commits into
base:main
Choose a base branch
from
Open

Validate SQLModel on all Non-Database Sourced Data #1823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b51f27
Validate SQLModel on all Non-Database Sourced Data
ClayGendron Mar 19, 2026
1ca48d9
Remove unused sqlmodel_table_construct
ClayGendron Mar 19, 2026
c79b30a
Merge branch 'main' into validate-table-models-on-construction
ClayGendron Apr 3, 2026
2569005
Merge branch 'main' into validate-table-models-on-construction
ClayGendron Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 16 additions & 80 deletions sqlmodel/_compat.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -205,74 +205,6 @@ def get_field_metadata(field: Any) -> Any:
return FakeMetadata()


def sqlmodel_table_construct(
*,
self_instance: _TSQLModel,
values: dict[str, Any],
_fields_set: set[str] | None = None,
) -> _TSQLModel:
# Copy from Pydantic's BaseModel.construct()
# Ref: https://github.com/pydantic/pydantic/blob/v2.5.2/pydantic/main.py#L198
# Modified to not include everything, only the model fields, and to
# set relationships
# SQLModel override to get class SQLAlchemy __dict__ attributes and
# set them back in after creating the object
# new_obj = cls.__new__(cls)
cls = type(self_instance)
old_dict = self_instance.__dict__.copy()
# End SQLModel override

fields_values: dict[str, Any] = {}
defaults: dict[
str, Any
] = {} # keeping this separate from `fields_values` helps us compute `_fields_set`
for name, field in cls.model_fields.items():
if field.alias and field.alias in values:
fields_values[name] = values.pop(field.alias)
elif name in values:
fields_values[name] = values.pop(name)
elif not field.is_required():
defaults[name] = field.get_default(call_default_factory=True)
if _fields_set is None:
_fields_set = set(fields_values.keys())
fields_values.update(defaults)

_extra: dict[str, Any] | None = None
if cls.model_config.get("extra") == "allow":
_extra = {}
for k, v in values.items():
_extra[k] = v
# SQLModel override, do not include everything, only the model fields
# else:
# fields_values.update(values)
# End SQLModel override
# SQLModel override
# Do not set __dict__, instead use setattr to trigger SQLAlchemy
# object.__setattr__(new_obj, "__dict__", fields_values)
# instrumentation
for key, value in {**old_dict, **fields_values}.items():
setattr(self_instance, key, value)
# End SQLModel override
object.__setattr__(self_instance, "__pydantic_fields_set__", _fields_set)
if not cls.__pydantic_root_model__:
object.__setattr__(self_instance, "__pydantic_extra__", _extra)

if cls.__pydantic_post_init__:
self_instance.model_post_init(None)
elif not cls.__pydantic_root_model__:
# Note: if there are any private attributes, cls.__pydantic_post_init__ would exist
# Since it doesn't, that means that `__pydantic_private__` should be set to None
object.__setattr__(self_instance, "__pydantic_private__", None)
# SQLModel override, set relationships
# Get and set any relationship objects
for key in self_instance.__sqlmodel_relationships__:
value = values.get(key, Undefined)
if value is not Undefined:
setattr(self_instance, key, value)
# End SQLModel override
return self_instance


def sqlmodel_validate(
cls: type[_TSQLModel],
obj: Any,
Expand DownExpand Up@@ -328,18 +260,22 @@ def sqlmodel_validate(

def sqlmodel_init(*, self: "SQLModel", data: dict[str, Any]) -> None:
old_dict = self.__dict__.copy()
self.__pydantic_validator__.validate_python(
data,
self_instance=self,
)
if not is_table_model_class(self.__class__):
self.__pydantic_validator__.validate_python(
data,
self_instance=self,
object.__setattr__(
self,
"__dict__",
{**old_dict, **self.__dict__},
)
else:
sqlmodel_table_construct(
self_instance=self,
values=data,
)
object.__setattr__(
self,
"__dict__",
{**old_dict, **self.__dict__},
)
fields_set = self.__pydantic_fields_set__.copy()
for key, value in {**old_dict, **self.__dict__}.items():
setattr(self, key, value)
object.__setattr__(self, "__pydantic_fields_set__", fields_set)
for key in self.__sqlmodel_relationships__:
value = data.get(key, Undefined)
if value is not Undefined:
setattr(self, key, value)
25 changes: 12 additions & 13 deletions tests/test_instance_no_args.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,17 @@
from sqlmodel import Field, Session, SQLModel, create_engine, select


def test_allow_instantiation_without_arguments(clear_sqlmodel):
def test_not_allow_instantiation_without_arguments(clear_sqlmodel):
class Item(SQLModel, table=True):
id: int | None = Field(default=None, primary_key=True)
name: str
description: str | None = None

with pytest.raises(ValidationError):
Item()


def test_allow_instantiation_with_required_arguments(clear_sqlmodel):
class Item(SQLModel, table=True):
id: int | None = Field(default=None, primary_key=True)
name: str
Expand All@@ -12,22 +22,11 @@ class Item(SQLModel, table=True):
engine = create_engine("sqlite:///:memory:")
SQLModel.metadata.create_all(engine)
with Session(engine) as db:
item = Item()
item.name = "Rick"
item = Item(name="Rick")
db.add(item)
db.commit()
statement = select(Item)
result = db.exec(statement).all()
assert len(result) == 1
assert isinstance(item.id, int)
SQLModel.metadata.clear()


def test_not_allow_instantiation_without_arguments_if_not_table():
class Item(SQLModel):
id: int | None = Field(default=None, primary_key=True)
name: str
description: str | None = None

with pytest.raises(ValidationError):
Item()
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Validate SQLModel on all Non-Database Sourced Data#1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

ClayGendron
wants to merge
4
commits into

base:main
Choose a base branch

from

 Open


Validate SQLModel on all Non-Database Sourced Data
#1823
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
9b51f27

Validate SQLModel on all Non-Database Sourced Data


ClayGendron Mar 19, 2026
1ca48d9

Remove unused sqlmodel_table_construct


ClayGendron Mar 19, 2026
c79b30a

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 3, 2026
2569005

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


96 changes: 16 additions & 80 deletions
sqlmodel/_compat.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,74 +205,6 @@ def get_field_metadata(field: Any) -> Any:
 return FakeMetadata()


def sqlmodel_table_construct(
 *,
 self_instance: _TSQLModel,
 values: dict[str, Any],
 _fields_set: set[str] | None = None,
) -> _TSQLModel:
 # Copy from Pydantic's BaseModel.construct()
 # Ref: https://github.com/pydantic/pydantic/blob/v2.5.2/pydantic/main.py#L198
 # Modified to not include everything, only the model fields, and to
 # set relationships
 # SQLModel override to get class SQLAlchemy __dict__ attributes and
 # set them back in after creating the object
 # new_obj = cls.__new__(cls)
 cls = type(self_instance)
 old_dict = self_instance.__dict__.copy()
 # End SQLModel override

 fields_values: dict[str, Any] = {}
 defaults: dict[
 str, Any
 ] = {} # keeping this separate from `fields_values` helps us compute `_fields_set`
 for name, field in cls.model_fields.items():
 if field.alias and field.alias in values:
 fields_values[name] = values.pop(field.alias)
 elif name in values:
 fields_values[name] = values.pop(name)
 elif not field.is_required():
 defaults[name] = field.get_default(call_default_factory=True)
 if _fields_set is None:
 _fields_set = set(fields_values.keys())
 fields_values.update(defaults)

 _extra: dict[str, Any] | None = None
 if cls.model_config.get("extra") == "allow":
 _extra = {}
 for k, v in values.items():
 _extra[k] = v
 # SQLModel override, do not include everything, only the model fields
 # else:
 # fields_values.update(values)
 # End SQLModel override
 # SQLModel override
 # Do not set __dict__, instead use setattr to trigger SQLAlchemy
 # object.__setattr__(new_obj, "__dict__", fields_values)
 # instrumentation
 for key, value in {**old_dict, **fields_values}.items():
 setattr(self_instance, key, value)
 # End SQLModel override
 object.__setattr__(self_instance, "__pydantic_fields_set__", _fields_set)
 if not cls.__pydantic_root_model__:
 object.__setattr__(self_instance, "__pydantic_extra__", _extra)

 if cls.__pydantic_post_init__:
 self_instance.model_post_init(None)
 elif not cls.__pydantic_root_model__:
 # Note: if there are any private attributes, cls.__pydantic_post_init__ would exist
 # Since it doesn't, that means that `__pydantic_private__` should be set to None
 object.__setattr__(self_instance, "__pydantic_private__", None)
 # SQLModel override, set relationships
 # Get and set any relationship objects
 for key in self_instance.__sqlmodel_relationships__:
 value = values.get(key, Undefined)
 if value is not Undefined:
 setattr(self_instance, key, value)
 # End SQLModel override
 return self_instance


def sqlmodel_validate(
 cls: type[_TSQLModel],
 obj: Any,
Expand DownExpand Up@@ -328,18 +260,22 @@ def sqlmodel_validate(

def sqlmodel_init(*, self: "SQLModel", data: dict[str, Any]) -> None:
 old_dict = self.__dict__.copy()
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 )
 if not is_table_model_class(self.__class__):
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 else:
 sqlmodel_table_construct(
 self_instance=self,
 values=data,
 )
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 fields_set = self.__pydantic_fields_set__.copy()
 for key, value in {**old_dict, **self.__dict__}.items():
 setattr(self, key, value)
 object.__setattr__(self, "__pydantic_fields_set__", fields_set)
 for key in self.__sqlmodel_relationships__:
 value = data.get(key, Undefined)
 if value is not Undefined:
 setattr(self, key, value)

25 changes: 12 additions & 13 deletions
tests/test_instance_no_args.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,17 @@
from sqlmodel import Field, Session, SQLModel, create_engine, select


def test_allow_instantiation_without_arguments(clear_sqlmodel):
def test_not_allow_instantiation_without_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()


def test_allow_instantiation_with_required_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
Expand All@@ -12,22 +22,11 @@ class Item(SQLModel, table=True):
 engine = create_engine("sqlite:///:memory:")
 SQLModel.metadata.create_all(engine)
 with Session(engine) as db:
 item = Item()
 item.name = "Rick"
 item = Item(name="Rick")
 db.add(item)
 db.commit()
 statement = select(Item)
 result = db.exec(statement).all()
 assert len(result) == 1
 assert isinstance(item.id, int)
 SQLModel.metadata.clear()


def test_not_allow_instantiation_without_arguments_if_not_table():
 class Item(SQLModel):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Validate SQLModel on all Non-Database Sourced Data#1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

ClayGendron
wants to merge
4
commits into

base:main
Choose a base branch

from

 Open


Validate SQLModel on all Non-Database Sourced Data
#1823
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
9b51f27

Validate SQLModel on all Non-Database Sourced Data


ClayGendron Mar 19, 2026
1ca48d9

Remove unused sqlmodel_table_construct


ClayGendron Mar 19, 2026
c79b30a

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 3, 2026
2569005

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


96 changes: 16 additions & 80 deletions
sqlmodel/_compat.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,74 +205,6 @@ def get_field_metadata(field: Any) -> Any:
 return FakeMetadata()


def sqlmodel_table_construct(
 *,
 self_instance: _TSQLModel,
 values: dict[str, Any],
 _fields_set: set[str] | None = None,
) -> _TSQLModel:
 # Copy from Pydantic's BaseModel.construct()
 # Ref: https://github.com/pydantic/pydantic/blob/v2.5.2/pydantic/main.py#L198
 # Modified to not include everything, only the model fields, and to
 # set relationships
 # SQLModel override to get class SQLAlchemy __dict__ attributes and
 # set them back in after creating the object
 # new_obj = cls.__new__(cls)
 cls = type(self_instance)
 old_dict = self_instance.__dict__.copy()
 # End SQLModel override

 fields_values: dict[str, Any] = {}
 defaults: dict[
 str, Any
 ] = {} # keeping this separate from `fields_values` helps us compute `_fields_set`
 for name, field in cls.model_fields.items():
 if field.alias and field.alias in values:
 fields_values[name] = values.pop(field.alias)
 elif name in values:
 fields_values[name] = values.pop(name)
 elif not field.is_required():
 defaults[name] = field.get_default(call_default_factory=True)
 if _fields_set is None:
 _fields_set = set(fields_values.keys())
 fields_values.update(defaults)

 _extra: dict[str, Any] | None = None
 if cls.model_config.get("extra") == "allow":
 _extra = {}
 for k, v in values.items():
 _extra[k] = v
 # SQLModel override, do not include everything, only the model fields
 # else:
 # fields_values.update(values)
 # End SQLModel override
 # SQLModel override
 # Do not set __dict__, instead use setattr to trigger SQLAlchemy
 # object.__setattr__(new_obj, "__dict__", fields_values)
 # instrumentation
 for key, value in {**old_dict, **fields_values}.items():
 setattr(self_instance, key, value)
 # End SQLModel override
 object.__setattr__(self_instance, "__pydantic_fields_set__", _fields_set)
 if not cls.__pydantic_root_model__:
 object.__setattr__(self_instance, "__pydantic_extra__", _extra)

 if cls.__pydantic_post_init__:
 self_instance.model_post_init(None)
 elif not cls.__pydantic_root_model__:
 # Note: if there are any private attributes, cls.__pydantic_post_init__ would exist
 # Since it doesn't, that means that `__pydantic_private__` should be set to None
 object.__setattr__(self_instance, "__pydantic_private__", None)
 # SQLModel override, set relationships
 # Get and set any relationship objects
 for key in self_instance.__sqlmodel_relationships__:
 value = values.get(key, Undefined)
 if value is not Undefined:
 setattr(self_instance, key, value)
 # End SQLModel override
 return self_instance


def sqlmodel_validate(
 cls: type[_TSQLModel],
 obj: Any,
Expand DownExpand Up@@ -328,18 +260,22 @@ def sqlmodel_validate(

def sqlmodel_init(*, self: "SQLModel", data: dict[str, Any]) -> None:
 old_dict = self.__dict__.copy()
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 )
 if not is_table_model_class(self.__class__):
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 else:
 sqlmodel_table_construct(
 self_instance=self,
 values=data,
 )
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 fields_set = self.__pydantic_fields_set__.copy()
 for key, value in {**old_dict, **self.__dict__}.items():
 setattr(self, key, value)
 object.__setattr__(self, "__pydantic_fields_set__", fields_set)
 for key in self.__sqlmodel_relationships__:
 value = data.get(key, Undefined)
 if value is not Undefined:
 setattr(self, key, value)

25 changes: 12 additions & 13 deletions
tests/test_instance_no_args.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,17 @@
from sqlmodel import Field, Session, SQLModel, create_engine, select


def test_allow_instantiation_without_arguments(clear_sqlmodel):
def test_not_allow_instantiation_without_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()


def test_allow_instantiation_with_required_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
Expand All@@ -12,22 +22,11 @@ class Item(SQLModel, table=True):
 engine = create_engine("sqlite:///:memory:")
 SQLModel.metadata.create_all(engine)
 with Session(engine) as db:
 item = Item()
 item.name = "Rick"
 item = Item(name="Rick")
 db.add(item)
 db.commit()
 statement = select(Item)
 result = db.exec(statement).all()
 assert len(result) == 1
 assert isinstance(item.id, int)
 SQLModel.metadata.clear()


def test_not_allow_instantiation_without_arguments_if_not_table():
 class Item(SQLModel):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Validate SQLModel on all Non-Database Sourced Data#1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

ClayGendron
wants to merge
4
commits into

base:main
Choose a base branch

from

 Open


Validate SQLModel on all Non-Database Sourced Data
#1823
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
9b51f27

Validate SQLModel on all Non-Database Sourced Data


ClayGendron Mar 19, 2026
1ca48d9

Remove unused sqlmodel_table_construct


ClayGendron Mar 19, 2026
c79b30a

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 3, 2026
2569005

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


96 changes: 16 additions & 80 deletions
sqlmodel/_compat.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,74 +205,6 @@ def get_field_metadata(field: Any) -> Any:
 return FakeMetadata()


def sqlmodel_table_construct(
 *,
 self_instance: _TSQLModel,
 values: dict[str, Any],
 _fields_set: set[str] | None = None,
) -> _TSQLModel:
 # Copy from Pydantic's BaseModel.construct()
 # Ref: https://github.com/pydantic/pydantic/blob/v2.5.2/pydantic/main.py#L198
 # Modified to not include everything, only the model fields, and to
 # set relationships
 # SQLModel override to get class SQLAlchemy __dict__ attributes and
 # set them back in after creating the object
 # new_obj = cls.__new__(cls)
 cls = type(self_instance)
 old_dict = self_instance.__dict__.copy()
 # End SQLModel override

 fields_values: dict[str, Any] = {}
 defaults: dict[
 str, Any
 ] = {} # keeping this separate from `fields_values` helps us compute `_fields_set`
 for name, field in cls.model_fields.items():
 if field.alias and field.alias in values:
 fields_values[name] = values.pop(field.alias)
 elif name in values:
 fields_values[name] = values.pop(name)
 elif not field.is_required():
 defaults[name] = field.get_default(call_default_factory=True)
 if _fields_set is None:
 _fields_set = set(fields_values.keys())
 fields_values.update(defaults)

 _extra: dict[str, Any] | None = None
 if cls.model_config.get("extra") == "allow":
 _extra = {}
 for k, v in values.items():
 _extra[k] = v
 # SQLModel override, do not include everything, only the model fields
 # else:
 # fields_values.update(values)
 # End SQLModel override
 # SQLModel override
 # Do not set __dict__, instead use setattr to trigger SQLAlchemy
 # object.__setattr__(new_obj, "__dict__", fields_values)
 # instrumentation
 for key, value in {**old_dict, **fields_values}.items():
 setattr(self_instance, key, value)
 # End SQLModel override
 object.__setattr__(self_instance, "__pydantic_fields_set__", _fields_set)
 if not cls.__pydantic_root_model__:
 object.__setattr__(self_instance, "__pydantic_extra__", _extra)

 if cls.__pydantic_post_init__:
 self_instance.model_post_init(None)
 elif not cls.__pydantic_root_model__:
 # Note: if there are any private attributes, cls.__pydantic_post_init__ would exist
 # Since it doesn't, that means that `__pydantic_private__` should be set to None
 object.__setattr__(self_instance, "__pydantic_private__", None)
 # SQLModel override, set relationships
 # Get and set any relationship objects
 for key in self_instance.__sqlmodel_relationships__:
 value = values.get(key, Undefined)
 if value is not Undefined:
 setattr(self_instance, key, value)
 # End SQLModel override
 return self_instance


def sqlmodel_validate(
 cls: type[_TSQLModel],
 obj: Any,
Expand DownExpand Up@@ -328,18 +260,22 @@ def sqlmodel_validate(

def sqlmodel_init(*, self: "SQLModel", data: dict[str, Any]) -> None:
 old_dict = self.__dict__.copy()
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 )
 if not is_table_model_class(self.__class__):
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 else:
 sqlmodel_table_construct(
 self_instance=self,
 values=data,
 )
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 fields_set = self.__pydantic_fields_set__.copy()
 for key, value in {**old_dict, **self.__dict__}.items():
 setattr(self, key, value)
 object.__setattr__(self, "__pydantic_fields_set__", fields_set)
 for key in self.__sqlmodel_relationships__:
 value = data.get(key, Undefined)
 if value is not Undefined:
 setattr(self, key, value)

25 changes: 12 additions & 13 deletions
tests/test_instance_no_args.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,17 @@
from sqlmodel import Field, Session, SQLModel, create_engine, select


def test_allow_instantiation_without_arguments(clear_sqlmodel):
def test_not_allow_instantiation_without_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()


def test_allow_instantiation_with_required_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
Expand All@@ -12,22 +22,11 @@ class Item(SQLModel, table=True):
 engine = create_engine("sqlite:///:memory:")
 SQLModel.metadata.create_all(engine)
 with Session(engine) as db:
 item = Item()
 item.name = "Rick"
 item = Item(name="Rick")
 db.add(item)
 db.commit()
 statement = select(Item)
 result = db.exec(statement).all()
 assert len(result) == 1
 assert isinstance(item.id, int)
 SQLModel.metadata.clear()


def test_not_allow_instantiation_without_arguments_if_not_table():
 class Item(SQLModel):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Validate SQLModel on all Non-Database Sourced Data#1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

ClayGendron
wants to merge
4
commits into

base:main
Choose a base branch

from

 Open


Validate SQLModel on all Non-Database Sourced Data
#1823
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
9b51f27

Validate SQLModel on all Non-Database Sourced Data


ClayGendron Mar 19, 2026
1ca48d9

Remove unused sqlmodel_table_construct


ClayGendron Mar 19, 2026
c79b30a

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 3, 2026
2569005

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


96 changes: 16 additions & 80 deletions
sqlmodel/_compat.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,74 +205,6 @@ def get_field_metadata(field: Any) -> Any:
 return FakeMetadata()


def sqlmodel_table_construct(
 *,
 self_instance: _TSQLModel,
 values: dict[str, Any],
 _fields_set: set[str] | None = None,
) -> _TSQLModel:
 # Copy from Pydantic's BaseModel.construct()
 # Ref: https://github.com/pydantic/pydantic/blob/v2.5.2/pydantic/main.py#L198
 # Modified to not include everything, only the model fields, and to
 # set relationships
 # SQLModel override to get class SQLAlchemy __dict__ attributes and
 # set them back in after creating the object
 # new_obj = cls.__new__(cls)
 cls = type(self_instance)
 old_dict = self_instance.__dict__.copy()
 # End SQLModel override

 fields_values: dict[str, Any] = {}
 defaults: dict[
 str, Any
 ] = {} # keeping this separate from `fields_values` helps us compute `_fields_set`
 for name, field in cls.model_fields.items():
 if field.alias and field.alias in values:
 fields_values[name] = values.pop(field.alias)
 elif name in values:
 fields_values[name] = values.pop(name)
 elif not field.is_required():
 defaults[name] = field.get_default(call_default_factory=True)
 if _fields_set is None:
 _fields_set = set(fields_values.keys())
 fields_values.update(defaults)

 _extra: dict[str, Any] | None = None
 if cls.model_config.get("extra") == "allow":
 _extra = {}
 for k, v in values.items():
 _extra[k] = v
 # SQLModel override, do not include everything, only the model fields
 # else:
 # fields_values.update(values)
 # End SQLModel override
 # SQLModel override
 # Do not set __dict__, instead use setattr to trigger SQLAlchemy
 # object.__setattr__(new_obj, "__dict__", fields_values)
 # instrumentation
 for key, value in {**old_dict, **fields_values}.items():
 setattr(self_instance, key, value)
 # End SQLModel override
 object.__setattr__(self_instance, "__pydantic_fields_set__", _fields_set)
 if not cls.__pydantic_root_model__:
 object.__setattr__(self_instance, "__pydantic_extra__", _extra)

 if cls.__pydantic_post_init__:
 self_instance.model_post_init(None)
 elif not cls.__pydantic_root_model__:
 # Note: if there are any private attributes, cls.__pydantic_post_init__ would exist
 # Since it doesn't, that means that `__pydantic_private__` should be set to None
 object.__setattr__(self_instance, "__pydantic_private__", None)
 # SQLModel override, set relationships
 # Get and set any relationship objects
 for key in self_instance.__sqlmodel_relationships__:
 value = values.get(key, Undefined)
 if value is not Undefined:
 setattr(self_instance, key, value)
 # End SQLModel override
 return self_instance


def sqlmodel_validate(
 cls: type[_TSQLModel],
 obj: Any,
Expand DownExpand Up@@ -328,18 +260,22 @@ def sqlmodel_validate(

def sqlmodel_init(*, self: "SQLModel", data: dict[str, Any]) -> None:
 old_dict = self.__dict__.copy()
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 )
 if not is_table_model_class(self.__class__):
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 else:
 sqlmodel_table_construct(
 self_instance=self,
 values=data,
 )
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 fields_set = self.__pydantic_fields_set__.copy()
 for key, value in {**old_dict, **self.__dict__}.items():
 setattr(self, key, value)
 object.__setattr__(self, "__pydantic_fields_set__", fields_set)
 for key in self.__sqlmodel_relationships__:
 value = data.get(key, Undefined)
 if value is not Undefined:
 setattr(self, key, value)

25 changes: 12 additions & 13 deletions
tests/test_instance_no_args.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,17 @@
from sqlmodel import Field, Session, SQLModel, create_engine, select


def test_allow_instantiation_without_arguments(clear_sqlmodel):
def test_not_allow_instantiation_without_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()


def test_allow_instantiation_with_required_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
Expand All@@ -12,22 +22,11 @@ class Item(SQLModel, table=True):
 engine = create_engine("sqlite:///:memory:")
 SQLModel.metadata.create_all(engine)
 with Session(engine) as db:
 item = Item()
 item.name = "Rick"
 item = Item(name="Rick")
 db.add(item)
 db.commit()
 statement = select(Item)
 result = db.exec(statement).all()
 assert len(result) == 1
 assert isinstance(item.id, int)
 SQLModel.metadata.clear()


def test_not_allow_instantiation_without_arguments_if_not_table():
 class Item(SQLModel):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Validate SQLModel on all Non-Database Sourced Data#1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

ClayGendron
wants to merge
4
commits into

base:main
Choose a base branch

from

 Open


Validate SQLModel on all Non-Database Sourced Data
#1823
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
9b51f27

Validate SQLModel on all Non-Database Sourced Data


ClayGendron Mar 19, 2026
1ca48d9

Remove unused sqlmodel_table_construct


ClayGendron Mar 19, 2026
c79b30a

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 3, 2026
2569005

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


96 changes: 16 additions & 80 deletions
sqlmodel/_compat.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,74 +205,6 @@ def get_field_metadata(field: Any) -> Any:
 return FakeMetadata()


def sqlmodel_table_construct(
 *,
 self_instance: _TSQLModel,
 values: dict[str, Any],
 _fields_set: set[str] | None = None,
) -> _TSQLModel:
 # Copy from Pydantic's BaseModel.construct()
 # Ref: https://github.com/pydantic/pydantic/blob/v2.5.2/pydantic/main.py#L198
 # Modified to not include everything, only the model fields, and to
 # set relationships
 # SQLModel override to get class SQLAlchemy __dict__ attributes and
 # set them back in after creating the object
 # new_obj = cls.__new__(cls)
 cls = type(self_instance)
 old_dict = self_instance.__dict__.copy()
 # End SQLModel override

 fields_values: dict[str, Any] = {}
 defaults: dict[
 str, Any
 ] = {} # keeping this separate from `fields_values` helps us compute `_fields_set`
 for name, field in cls.model_fields.items():
 if field.alias and field.alias in values:
 fields_values[name] = values.pop(field.alias)
 elif name in values:
 fields_values[name] = values.pop(name)
 elif not field.is_required():
 defaults[name] = field.get_default(call_default_factory=True)
 if _fields_set is None:
 _fields_set = set(fields_values.keys())
 fields_values.update(defaults)

 _extra: dict[str, Any] | None = None
 if cls.model_config.get("extra") == "allow":
 _extra = {}
 for k, v in values.items():
 _extra[k] = v
 # SQLModel override, do not include everything, only the model fields
 # else:
 # fields_values.update(values)
 # End SQLModel override
 # SQLModel override
 # Do not set __dict__, instead use setattr to trigger SQLAlchemy
 # object.__setattr__(new_obj, "__dict__", fields_values)
 # instrumentation
 for key, value in {**old_dict, **fields_values}.items():
 setattr(self_instance, key, value)
 # End SQLModel override
 object.__setattr__(self_instance, "__pydantic_fields_set__", _fields_set)
 if not cls.__pydantic_root_model__:
 object.__setattr__(self_instance, "__pydantic_extra__", _extra)

 if cls.__pydantic_post_init__:
 self_instance.model_post_init(None)
 elif not cls.__pydantic_root_model__:
 # Note: if there are any private attributes, cls.__pydantic_post_init__ would exist
 # Since it doesn't, that means that `__pydantic_private__` should be set to None
 object.__setattr__(self_instance, "__pydantic_private__", None)
 # SQLModel override, set relationships
 # Get and set any relationship objects
 for key in self_instance.__sqlmodel_relationships__:
 value = values.get(key, Undefined)
 if value is not Undefined:
 setattr(self_instance, key, value)
 # End SQLModel override
 return self_instance


def sqlmodel_validate(
 cls: type[_TSQLModel],
 obj: Any,
Expand DownExpand Up@@ -328,18 +260,22 @@ def sqlmodel_validate(

def sqlmodel_init(*, self: "SQLModel", data: dict[str, Any]) -> None:
 old_dict = self.__dict__.copy()
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 )
 if not is_table_model_class(self.__class__):
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 else:
 sqlmodel_table_construct(
 self_instance=self,
 values=data,
 )
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 fields_set = self.__pydantic_fields_set__.copy()
 for key, value in {**old_dict, **self.__dict__}.items():
 setattr(self, key, value)
 object.__setattr__(self, "__pydantic_fields_set__", fields_set)
 for key in self.__sqlmodel_relationships__:
 value = data.get(key, Undefined)
 if value is not Undefined:
 setattr(self, key, value)

25 changes: 12 additions & 13 deletions
tests/test_instance_no_args.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,17 @@
from sqlmodel import Field, Session, SQLModel, create_engine, select


def test_allow_instantiation_without_arguments(clear_sqlmodel):
def test_not_allow_instantiation_without_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()


def test_allow_instantiation_with_required_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
Expand All@@ -12,22 +22,11 @@ class Item(SQLModel, table=True):
 engine = create_engine("sqlite:///:memory:")
 SQLModel.metadata.create_all(engine)
 with Session(engine) as db:
 item = Item()
 item.name = "Rick"
 item = Item(name="Rick")
 db.add(item)
 db.commit()
 statement = select(Item)
 result = db.exec(statement).all()
 assert len(result) == 1
 assert isinstance(item.id, int)
 SQLModel.metadata.clear()


def test_not_allow_instantiation_without_arguments_if_not_table():
 class Item(SQLModel):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Validate SQLModel on all Non-Database Sourced Data#1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

ClayGendron
wants to merge
4
commits into

base:main
Choose a base branch

from

 Open


Validate SQLModel on all Non-Database Sourced Data
#1823
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
9b51f27

Validate SQLModel on all Non-Database Sourced Data


ClayGendron Mar 19, 2026
1ca48d9

Remove unused sqlmodel_table_construct


ClayGendron Mar 19, 2026
c79b30a

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 3, 2026
2569005

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


96 changes: 16 additions & 80 deletions
sqlmodel/_compat.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,74 +205,6 @@ def get_field_metadata(field: Any) -> Any:
 return FakeMetadata()


def sqlmodel_table_construct(
 *,
 self_instance: _TSQLModel,
 values: dict[str, Any],
 _fields_set: set[str] | None = None,
) -> _TSQLModel:
 # Copy from Pydantic's BaseModel.construct()
 # Ref: https://github.com/pydantic/pydantic/blob/v2.5.2/pydantic/main.py#L198
 # Modified to not include everything, only the model fields, and to
 # set relationships
 # SQLModel override to get class SQLAlchemy __dict__ attributes and
 # set them back in after creating the object
 # new_obj = cls.__new__(cls)
 cls = type(self_instance)
 old_dict = self_instance.__dict__.copy()
 # End SQLModel override

 fields_values: dict[str, Any] = {}
 defaults: dict[
 str, Any
 ] = {} # keeping this separate from `fields_values` helps us compute `_fields_set`
 for name, field in cls.model_fields.items():
 if field.alias and field.alias in values:
 fields_values[name] = values.pop(field.alias)
 elif name in values:
 fields_values[name] = values.pop(name)
 elif not field.is_required():
 defaults[name] = field.get_default(call_default_factory=True)
 if _fields_set is None:
 _fields_set = set(fields_values.keys())
 fields_values.update(defaults)

 _extra: dict[str, Any] | None = None
 if cls.model_config.get("extra") == "allow":
 _extra = {}
 for k, v in values.items():
 _extra[k] = v
 # SQLModel override, do not include everything, only the model fields
 # else:
 # fields_values.update(values)
 # End SQLModel override
 # SQLModel override
 # Do not set __dict__, instead use setattr to trigger SQLAlchemy
 # object.__setattr__(new_obj, "__dict__", fields_values)
 # instrumentation
 for key, value in {**old_dict, **fields_values}.items():
 setattr(self_instance, key, value)
 # End SQLModel override
 object.__setattr__(self_instance, "__pydantic_fields_set__", _fields_set)
 if not cls.__pydantic_root_model__:
 object.__setattr__(self_instance, "__pydantic_extra__", _extra)

 if cls.__pydantic_post_init__:
 self_instance.model_post_init(None)
 elif not cls.__pydantic_root_model__:
 # Note: if there are any private attributes, cls.__pydantic_post_init__ would exist
 # Since it doesn't, that means that `__pydantic_private__` should be set to None
 object.__setattr__(self_instance, "__pydantic_private__", None)
 # SQLModel override, set relationships
 # Get and set any relationship objects
 for key in self_instance.__sqlmodel_relationships__:
 value = values.get(key, Undefined)
 if value is not Undefined:
 setattr(self_instance, key, value)
 # End SQLModel override
 return self_instance


def sqlmodel_validate(
 cls: type[_TSQLModel],
 obj: Any,
Expand DownExpand Up@@ -328,18 +260,22 @@ def sqlmodel_validate(

def sqlmodel_init(*, self: "SQLModel", data: dict[str, Any]) -> None:
 old_dict = self.__dict__.copy()
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 )
 if not is_table_model_class(self.__class__):
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 else:
 sqlmodel_table_construct(
 self_instance=self,
 values=data,
 )
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 fields_set = self.__pydantic_fields_set__.copy()
 for key, value in {**old_dict, **self.__dict__}.items():
 setattr(self, key, value)
 object.__setattr__(self, "__pydantic_fields_set__", fields_set)
 for key in self.__sqlmodel_relationships__:
 value = data.get(key, Undefined)
 if value is not Undefined:
 setattr(self, key, value)

25 changes: 12 additions & 13 deletions
tests/test_instance_no_args.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,17 @@
from sqlmodel import Field, Session, SQLModel, create_engine, select


def test_allow_instantiation_without_arguments(clear_sqlmodel):
def test_not_allow_instantiation_without_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()


def test_allow_instantiation_with_required_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
Expand All@@ -12,22 +22,11 @@ class Item(SQLModel, table=True):
 engine = create_engine("sqlite:///:memory:")
 SQLModel.metadata.create_all(engine)
 with Session(engine) as db:
 item = Item()
 item.name = "Rick"
 item = Item(name="Rick")
 db.add(item)
 db.commit()
 statement = select(Item)
 result = db.exec(statement).all()
 assert len(result) == 1
 assert isinstance(item.id, int)
 SQLModel.metadata.clear()


def test_not_allow_instantiation_without_arguments_if_not_table():
 class Item(SQLModel):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Validate SQLModel on all Non-Database Sourced Data#1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

ClayGendron
wants to merge
4
commits into

base:main
Choose a base branch

from

 Open


Validate SQLModel on all Non-Database Sourced Data
#1823
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
9b51f27

Validate SQLModel on all Non-Database Sourced Data


ClayGendron Mar 19, 2026
1ca48d9

Remove unused sqlmodel_table_construct


ClayGendron Mar 19, 2026
c79b30a

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 3, 2026
2569005

Merge branch 'main' into validate-table-models-on-construction


ClayGendron Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


96 changes: 16 additions & 80 deletions
sqlmodel/_compat.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -205,74 +205,6 @@ def get_field_metadata(field: Any) -> Any:
 return FakeMetadata()


def sqlmodel_table_construct(
 *,
 self_instance: _TSQLModel,
 values: dict[str, Any],
 _fields_set: set[str] | None = None,
) -> _TSQLModel:
 # Copy from Pydantic's BaseModel.construct()
 # Ref: https://github.com/pydantic/pydantic/blob/v2.5.2/pydantic/main.py#L198
 # Modified to not include everything, only the model fields, and to
 # set relationships
 # SQLModel override to get class SQLAlchemy __dict__ attributes and
 # set them back in after creating the object
 # new_obj = cls.__new__(cls)
 cls = type(self_instance)
 old_dict = self_instance.__dict__.copy()
 # End SQLModel override

 fields_values: dict[str, Any] = {}
 defaults: dict[
 str, Any
 ] = {} # keeping this separate from `fields_values` helps us compute `_fields_set`
 for name, field in cls.model_fields.items():
 if field.alias and field.alias in values:
 fields_values[name] = values.pop(field.alias)
 elif name in values:
 fields_values[name] = values.pop(name)
 elif not field.is_required():
 defaults[name] = field.get_default(call_default_factory=True)
 if _fields_set is None:
 _fields_set = set(fields_values.keys())
 fields_values.update(defaults)

 _extra: dict[str, Any] | None = None
 if cls.model_config.get("extra") == "allow":
 _extra = {}
 for k, v in values.items():
 _extra[k] = v
 # SQLModel override, do not include everything, only the model fields
 # else:
 # fields_values.update(values)
 # End SQLModel override
 # SQLModel override
 # Do not set __dict__, instead use setattr to trigger SQLAlchemy
 # object.__setattr__(new_obj, "__dict__", fields_values)
 # instrumentation
 for key, value in {**old_dict, **fields_values}.items():
 setattr(self_instance, key, value)
 # End SQLModel override
 object.__setattr__(self_instance, "__pydantic_fields_set__", _fields_set)
 if not cls.__pydantic_root_model__:
 object.__setattr__(self_instance, "__pydantic_extra__", _extra)

 if cls.__pydantic_post_init__:
 self_instance.model_post_init(None)
 elif not cls.__pydantic_root_model__:
 # Note: if there are any private attributes, cls.__pydantic_post_init__ would exist
 # Since it doesn't, that means that `__pydantic_private__` should be set to None
 object.__setattr__(self_instance, "__pydantic_private__", None)
 # SQLModel override, set relationships
 # Get and set any relationship objects
 for key in self_instance.__sqlmodel_relationships__:
 value = values.get(key, Undefined)
 if value is not Undefined:
 setattr(self_instance, key, value)
 # End SQLModel override
 return self_instance


def sqlmodel_validate(
 cls: type[_TSQLModel],
 obj: Any,
Expand DownExpand Up@@ -328,18 +260,22 @@ def sqlmodel_validate(

def sqlmodel_init(*, self: "SQLModel", data: dict[str, Any]) -> None:
 old_dict = self.__dict__.copy()
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 )
 if not is_table_model_class(self.__class__):
 self.__pydantic_validator__.validate_python(
 data,
 self_instance=self,
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 else:
 sqlmodel_table_construct(
 self_instance=self,
 values=data,
 )
 object.__setattr__(
 self,
 "__dict__",
 {**old_dict, **self.__dict__},
 )
 fields_set = self.__pydantic_fields_set__.copy()
 for key, value in {**old_dict, **self.__dict__}.items():
 setattr(self, key, value)
 object.__setattr__(self, "__pydantic_fields_set__", fields_set)
 for key in self.__sqlmodel_relationships__:
 value = data.get(key, Undefined)
 if value is not Undefined:
 setattr(self, key, value)

25 changes: 12 additions & 13 deletions
tests/test_instance_no_args.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,17 @@
from sqlmodel import Field, Session, SQLModel, create_engine, select


def test_allow_instantiation_without_arguments(clear_sqlmodel):
def test_not_allow_instantiation_without_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()


def test_allow_instantiation_with_required_arguments(clear_sqlmodel):
 class Item(SQLModel, table=True):
 id: int | None = Field(default=None, primary_key=True)
 name: str
Expand All@@ -12,22 +22,11 @@ class Item(SQLModel, table=True):
 engine = create_engine("sqlite:///:memory:")
 SQLModel.metadata.create_all(engine)
 with Session(engine) as db:
 item = Item()
 item.name = "Rick"
 item = Item(name="Rick")
 db.add(item)
 db.commit()
 statement = select(Item)
 result = db.exec(statement).all()
 assert len(result) == 1
 assert isinstance(item.id, int)
 SQLModel.metadata.clear()


def test_not_allow_instantiation_without_arguments_if_not_table():
 class Item(SQLModel):
 id: int | None = Field(default=None, primary_key=True)
 name: str
 description: str | None = None

 with pytest.raises(ValidationError):
 Item()
Loading
Loading