✨ Update GUID handling to use stdlib `UUID.hex` instead of an `int` by andrewbolster · Pull Request #26 · fastapi/sqlmodel

andrewbolster · 2021-08-26T06:00:16Z

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib UUID.hex method.

This also fixes#25

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib [`UUID.hex`](https://docs.python.org/3/library/uuid.html#uuid.UUID.hex) method. This also fixesfastapi#25

hidaris · 2021-10-09T09:36:18Z

any update?

gnillev · 2021-10-15T10:56:02Z

I will just propose also adding a small test, just to catch this.

I made my own small test to catch the behaviour in a fork to fix this, before finding this pr, so you can maybe work something off of this (probably want to generalize a bit - I made it really quick just to confirm this was causing the issue):

deftest_zero_padded_uuid():
raised=Nonemyid=UUID(hex='00000000000000000000000000000001')
stored_value=GUID().process_bind_param(myid, SQLiteDialect)
try:
back_to_uuid=GUID().process_result_value(stored_value, SQLiteDialect)
exceptValueErrorasex:
raised=exassertraisedisNoneassertmyid==back_to_uuid

At 959f380

chriswhite199 · 2021-11-29T19:09:43Z

@tiangolo - Do you have any other maintainers that can help get small PRs like this merged? I'm also up against this issue, and the PR was opened 2 months ago.

mkarbo · 2021-12-02T09:33:34Z

Any news on this?

alucarddelta · 2021-12-16T02:30:13Z

I am disappointed that this simple fix was not implemented in 0.0.5, as this is causes a lot of headaches when using UUID primary keys.

mkarbo · 2021-12-29T10:44:05Z

We can hope for 0.0.7 to add this @tiangolo?

pythrick · 2021-12-31T02:38:29Z

I was just about to create an issue about it and implement the exactly same solution.

Looks like SQLModel got inspired by the same source of this gist: https://gist.github.com/gmolveau/7caeeefe637679005a7bb9ae1b5e421e

IMHO I think SQLAlquemy-Utils uses a better approach when it provides additional native dialects besides postgresql, like msql and cockroachdb, and also uses the native UUID .hex property in serialization. https://sqlalchemy-utils.readthedocs.io/en/latest/_modules/sqlalchemy_utils/types/uuid.html#UUIDType

Fork 3 (Sourcery refactored)

codecov · 2022-08-27T22:24:26Z

Codecov Report

Merging #26 (9bb4715) into main (db3ad59) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@## main #26 +/- ##
=======================================
Coverage 97.59% 97.59% =======================================
Files 182 182 Lines 6060 6060 =======================================
Hits 5914 5914 Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/sql/sqltypes.py	`56.75% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T22:24:39Z

📝 Docs preview for commit 9bb4715 at: https://630a99822de66e5008e74d00--sqlmodel.netlify.app

tiangolo · 2022-08-27T22:28:04Z

Great! This makes sense, thank you @andrewbolster! 🍰

And thanks everyone for the discussion! ☕

This will be available in the next version, released in the next hours, SQLModel 0.0.7. 🎉

andrewbolster · 2021-08-26T06:00:16Z

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib UUID.hex method.

This also fixes#25

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib [`UUID.hex`](https://docs.python.org/3/library/uuid.html#uuid.UUID.hex) method. This also fixesfastapi#25

hidaris · 2021-10-09T09:36:18Z

any update?

gnillev · 2021-10-15T10:56:02Z

I will just propose also adding a small test, just to catch this.

I made my own small test to catch the behaviour in a fork to fix this, before finding this pr, so you can maybe work something off of this (probably want to generalize a bit - I made it really quick just to confirm this was causing the issue):

deftest_zero_padded_uuid():
raised=Nonemyid=UUID(hex='00000000000000000000000000000001')
stored_value=GUID().process_bind_param(myid, SQLiteDialect)
try:
back_to_uuid=GUID().process_result_value(stored_value, SQLiteDialect)
exceptValueErrorasex:
raised=exassertraisedisNoneassertmyid==back_to_uuid

At 959f380

chriswhite199 · 2021-11-29T19:09:43Z

@tiangolo - Do you have any other maintainers that can help get small PRs like this merged? I'm also up against this issue, and the PR was opened 2 months ago.

mkarbo · 2021-12-02T09:33:34Z

Any news on this?

alucarddelta · 2021-12-16T02:30:13Z

I am disappointed that this simple fix was not implemented in 0.0.5, as this is causes a lot of headaches when using UUID primary keys.

mkarbo · 2021-12-29T10:44:05Z

We can hope for 0.0.7 to add this @tiangolo?

pythrick · 2021-12-31T02:38:29Z

I was just about to create an issue about it and implement the exactly same solution.

Looks like SQLModel got inspired by the same source of this gist: https://gist.github.com/gmolveau/7caeeefe637679005a7bb9ae1b5e421e

IMHO I think SQLAlquemy-Utils uses a better approach when it provides additional native dialects besides postgresql, like msql and cockroachdb, and also uses the native UUID .hex property in serialization. https://sqlalchemy-utils.readthedocs.io/en/latest/_modules/sqlalchemy_utils/types/uuid.html#UUIDType

Fork 3 (Sourcery refactored)

codecov · 2022-08-27T22:24:26Z

Codecov Report

Merging #26 (9bb4715) into main (db3ad59) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@## main #26 +/- ##
=======================================
Coverage 97.59% 97.59% =======================================
Files 182 182 Lines 6060 6060 =======================================
Hits 5914 5914 Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/sql/sqltypes.py	`56.75% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T22:24:39Z

📝 Docs preview for commit 9bb4715 at: https://630a99822de66e5008e74d00--sqlmodel.netlify.app

tiangolo · 2022-08-27T22:28:04Z

Great! This makes sense, thank you @andrewbolster! 🍰

And thanks everyone for the discussion! ☕

This will be available in the next version, released in the next hours, SQLModel 0.0.7. 🎉

andrewbolster · 2021-08-26T06:00:16Z

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib UUID.hex method.

This also fixes#25

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib [`UUID.hex`](https://docs.python.org/3/library/uuid.html#uuid.UUID.hex) method. This also fixesfastapi#25

hidaris · 2021-10-09T09:36:18Z

any update?

gnillev · 2021-10-15T10:56:02Z

I will just propose also adding a small test, just to catch this.

I made my own small test to catch the behaviour in a fork to fix this, before finding this pr, so you can maybe work something off of this (probably want to generalize a bit - I made it really quick just to confirm this was causing the issue):

deftest_zero_padded_uuid():
raised=Nonemyid=UUID(hex='00000000000000000000000000000001')
stored_value=GUID().process_bind_param(myid, SQLiteDialect)
try:
back_to_uuid=GUID().process_result_value(stored_value, SQLiteDialect)
exceptValueErrorasex:
raised=exassertraisedisNoneassertmyid==back_to_uuid

At 959f380

chriswhite199 · 2021-11-29T19:09:43Z

@tiangolo - Do you have any other maintainers that can help get small PRs like this merged? I'm also up against this issue, and the PR was opened 2 months ago.

mkarbo · 2021-12-02T09:33:34Z

Any news on this?

alucarddelta · 2021-12-16T02:30:13Z

I am disappointed that this simple fix was not implemented in 0.0.5, as this is causes a lot of headaches when using UUID primary keys.

mkarbo · 2021-12-29T10:44:05Z

We can hope for 0.0.7 to add this @tiangolo?

pythrick · 2021-12-31T02:38:29Z

I was just about to create an issue about it and implement the exactly same solution.

Looks like SQLModel got inspired by the same source of this gist: https://gist.github.com/gmolveau/7caeeefe637679005a7bb9ae1b5e421e

IMHO I think SQLAlquemy-Utils uses a better approach when it provides additional native dialects besides postgresql, like msql and cockroachdb, and also uses the native UUID .hex property in serialization. https://sqlalchemy-utils.readthedocs.io/en/latest/_modules/sqlalchemy_utils/types/uuid.html#UUIDType

Fork 3 (Sourcery refactored)

codecov · 2022-08-27T22:24:26Z

Codecov Report

Merging #26 (9bb4715) into main (db3ad59) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@## main #26 +/- ##
=======================================
Coverage 97.59% 97.59% =======================================
Files 182 182 Lines 6060 6060 =======================================
Hits 5914 5914 Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/sql/sqltypes.py	`56.75% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T22:24:39Z

📝 Docs preview for commit 9bb4715 at: https://630a99822de66e5008e74d00--sqlmodel.netlify.app

tiangolo · 2022-08-27T22:28:04Z

Great! This makes sense, thank you @andrewbolster! 🍰

And thanks everyone for the discussion! ☕

This will be available in the next version, released in the next hours, SQLModel 0.0.7. 🎉

andrewbolster · 2021-08-26T06:00:16Z

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib UUID.hex method.

This also fixes#25

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib [`UUID.hex`](https://docs.python.org/3/library/uuid.html#uuid.UUID.hex) method. This also fixesfastapi#25

hidaris · 2021-10-09T09:36:18Z

any update?

gnillev · 2021-10-15T10:56:02Z

I will just propose also adding a small test, just to catch this.

I made my own small test to catch the behaviour in a fork to fix this, before finding this pr, so you can maybe work something off of this (probably want to generalize a bit - I made it really quick just to confirm this was causing the issue):

deftest_zero_padded_uuid():
raised=Nonemyid=UUID(hex='00000000000000000000000000000001')
stored_value=GUID().process_bind_param(myid, SQLiteDialect)
try:
back_to_uuid=GUID().process_result_value(stored_value, SQLiteDialect)
exceptValueErrorasex:
raised=exassertraisedisNoneassertmyid==back_to_uuid

At 959f380

chriswhite199 · 2021-11-29T19:09:43Z

@tiangolo - Do you have any other maintainers that can help get small PRs like this merged? I'm also up against this issue, and the PR was opened 2 months ago.

mkarbo · 2021-12-02T09:33:34Z

Any news on this?

alucarddelta · 2021-12-16T02:30:13Z

I am disappointed that this simple fix was not implemented in 0.0.5, as this is causes a lot of headaches when using UUID primary keys.

mkarbo · 2021-12-29T10:44:05Z

We can hope for 0.0.7 to add this @tiangolo?

pythrick · 2021-12-31T02:38:29Z

I was just about to create an issue about it and implement the exactly same solution.

Looks like SQLModel got inspired by the same source of this gist: https://gist.github.com/gmolveau/7caeeefe637679005a7bb9ae1b5e421e

IMHO I think SQLAlquemy-Utils uses a better approach when it provides additional native dialects besides postgresql, like msql and cockroachdb, and also uses the native UUID .hex property in serialization. https://sqlalchemy-utils.readthedocs.io/en/latest/_modules/sqlalchemy_utils/types/uuid.html#UUIDType

Fork 3 (Sourcery refactored)

codecov · 2022-08-27T22:24:26Z

Codecov Report

Merging #26 (9bb4715) into main (db3ad59) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@## main #26 +/- ##
=======================================
Coverage 97.59% 97.59% =======================================
Files 182 182 Lines 6060 6060 =======================================
Hits 5914 5914 Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/sql/sqltypes.py	`56.75% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T22:24:39Z

📝 Docs preview for commit 9bb4715 at: https://630a99822de66e5008e74d00--sqlmodel.netlify.app

tiangolo · 2022-08-27T22:28:04Z

Great! This makes sense, thank you @andrewbolster! 🍰

And thanks everyone for the discussion! ☕

This will be available in the next version, released in the next hours, SQLModel 0.0.7. 🎉

andrewbolster · 2021-08-26T06:00:16Z

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib UUID.hex method.

This also fixes#25

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib [`UUID.hex`](https://docs.python.org/3/library/uuid.html#uuid.UUID.hex) method. This also fixesfastapi#25

hidaris · 2021-10-09T09:36:18Z

any update?

gnillev · 2021-10-15T10:56:02Z

I will just propose also adding a small test, just to catch this.

I made my own small test to catch the behaviour in a fork to fix this, before finding this pr, so you can maybe work something off of this (probably want to generalize a bit - I made it really quick just to confirm this was causing the issue):

deftest_zero_padded_uuid():
raised=Nonemyid=UUID(hex='00000000000000000000000000000001')
stored_value=GUID().process_bind_param(myid, SQLiteDialect)
try:
back_to_uuid=GUID().process_result_value(stored_value, SQLiteDialect)
exceptValueErrorasex:
raised=exassertraisedisNoneassertmyid==back_to_uuid

At 959f380

chriswhite199 · 2021-11-29T19:09:43Z

@tiangolo - Do you have any other maintainers that can help get small PRs like this merged? I'm also up against this issue, and the PR was opened 2 months ago.

mkarbo · 2021-12-02T09:33:34Z

Any news on this?

alucarddelta · 2021-12-16T02:30:13Z

I am disappointed that this simple fix was not implemented in 0.0.5, as this is causes a lot of headaches when using UUID primary keys.

mkarbo · 2021-12-29T10:44:05Z

We can hope for 0.0.7 to add this @tiangolo?

pythrick · 2021-12-31T02:38:29Z

I was just about to create an issue about it and implement the exactly same solution.

Looks like SQLModel got inspired by the same source of this gist: https://gist.github.com/gmolveau/7caeeefe637679005a7bb9ae1b5e421e

IMHO I think SQLAlquemy-Utils uses a better approach when it provides additional native dialects besides postgresql, like msql and cockroachdb, and also uses the native UUID .hex property in serialization. https://sqlalchemy-utils.readthedocs.io/en/latest/_modules/sqlalchemy_utils/types/uuid.html#UUIDType

Fork 3 (Sourcery refactored)

codecov · 2022-08-27T22:24:26Z

Codecov Report

Merging #26 (9bb4715) into main (db3ad59) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@## main #26 +/- ##
=======================================
Coverage 97.59% 97.59% =======================================
Files 182 182 Lines 6060 6060 =======================================
Hits 5914 5914 Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/sql/sqltypes.py	`56.75% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T22:24:39Z

📝 Docs preview for commit 9bb4715 at: https://630a99822de66e5008e74d00--sqlmodel.netlify.app

tiangolo · 2022-08-27T22:28:04Z

Great! This makes sense, thank you @andrewbolster! 🍰

And thanks everyone for the discussion! ☕

This will be available in the next version, released in the next hours, SQLModel 0.0.7. 🎉

andrewbolster · 2021-08-26T06:00:16Z

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib UUID.hex method.

This also fixes#25

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib [`UUID.hex`](https://docs.python.org/3/library/uuid.html#uuid.UUID.hex) method. This also fixesfastapi#25

hidaris · 2021-10-09T09:36:18Z

any update?

gnillev · 2021-10-15T10:56:02Z

I will just propose also adding a small test, just to catch this.

I made my own small test to catch the behaviour in a fork to fix this, before finding this pr, so you can maybe work something off of this (probably want to generalize a bit - I made it really quick just to confirm this was causing the issue):

deftest_zero_padded_uuid():
raised=Nonemyid=UUID(hex='00000000000000000000000000000001')
stored_value=GUID().process_bind_param(myid, SQLiteDialect)
try:
back_to_uuid=GUID().process_result_value(stored_value, SQLiteDialect)
exceptValueErrorasex:
raised=exassertraisedisNoneassertmyid==back_to_uuid

At 959f380

chriswhite199 · 2021-11-29T19:09:43Z

@tiangolo - Do you have any other maintainers that can help get small PRs like this merged? I'm also up against this issue, and the PR was opened 2 months ago.

mkarbo · 2021-12-02T09:33:34Z

Any news on this?

alucarddelta · 2021-12-16T02:30:13Z

I am disappointed that this simple fix was not implemented in 0.0.5, as this is causes a lot of headaches when using UUID primary keys.

mkarbo · 2021-12-29T10:44:05Z

We can hope for 0.0.7 to add this @tiangolo?

pythrick · 2021-12-31T02:38:29Z

I was just about to create an issue about it and implement the exactly same solution.

Looks like SQLModel got inspired by the same source of this gist: https://gist.github.com/gmolveau/7caeeefe637679005a7bb9ae1b5e421e

IMHO I think SQLAlquemy-Utils uses a better approach when it provides additional native dialects besides postgresql, like msql and cockroachdb, and also uses the native UUID .hex property in serialization. https://sqlalchemy-utils.readthedocs.io/en/latest/_modules/sqlalchemy_utils/types/uuid.html#UUIDType

Fork 3 (Sourcery refactored)

codecov · 2022-08-27T22:24:26Z

Codecov Report

Merging #26 (9bb4715) into main (db3ad59) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@## main #26 +/- ##
=======================================
Coverage 97.59% 97.59% =======================================
Files 182 182 Lines 6060 6060 =======================================
Hits 5914 5914 Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/sql/sqltypes.py	`56.75% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T22:24:39Z

📝 Docs preview for commit 9bb4715 at: https://630a99822de66e5008e74d00--sqlmodel.netlify.app

tiangolo · 2022-08-27T22:28:04Z

Great! This makes sense, thank you @andrewbolster! 🍰

And thanks everyone for the discussion! ☕

This will be available in the next version, released in the next hours, SQLModel 0.0.7. 🎉

andrewbolster · 2021-08-26T06:00:16Z

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib UUID.hex method.

This also fixes#25

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib [`UUID.hex`](https://docs.python.org/3/library/uuid.html#uuid.UUID.hex) method. This also fixesfastapi#25

hidaris · 2021-10-09T09:36:18Z

any update?

gnillev · 2021-10-15T10:56:02Z

I will just propose also adding a small test, just to catch this.

I made my own small test to catch the behaviour in a fork to fix this, before finding this pr, so you can maybe work something off of this (probably want to generalize a bit - I made it really quick just to confirm this was causing the issue):

deftest_zero_padded_uuid():
raised=Nonemyid=UUID(hex='00000000000000000000000000000001')
stored_value=GUID().process_bind_param(myid, SQLiteDialect)
try:
back_to_uuid=GUID().process_result_value(stored_value, SQLiteDialect)
exceptValueErrorasex:
raised=exassertraisedisNoneassertmyid==back_to_uuid

At 959f380

chriswhite199 · 2021-11-29T19:09:43Z

@tiangolo - Do you have any other maintainers that can help get small PRs like this merged? I'm also up against this issue, and the PR was opened 2 months ago.

mkarbo · 2021-12-02T09:33:34Z

Any news on this?

alucarddelta · 2021-12-16T02:30:13Z

I am disappointed that this simple fix was not implemented in 0.0.5, as this is causes a lot of headaches when using UUID primary keys.

mkarbo · 2021-12-29T10:44:05Z

We can hope for 0.0.7 to add this @tiangolo?

pythrick · 2021-12-31T02:38:29Z

I was just about to create an issue about it and implement the exactly same solution.

Looks like SQLModel got inspired by the same source of this gist: https://gist.github.com/gmolveau/7caeeefe637679005a7bb9ae1b5e421e

IMHO I think SQLAlquemy-Utils uses a better approach when it provides additional native dialects besides postgresql, like msql and cockroachdb, and also uses the native UUID .hex property in serialization. https://sqlalchemy-utils.readthedocs.io/en/latest/_modules/sqlalchemy_utils/types/uuid.html#UUIDType

Fork 3 (Sourcery refactored)

codecov · 2022-08-27T22:24:26Z

Codecov Report

Merging #26 (9bb4715) into main (db3ad59) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@## main #26 +/- ##
=======================================
Coverage 97.59% 97.59% =======================================
Files 182 182 Lines 6060 6060 =======================================
Hits 5914 5914 Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/sql/sqltypes.py	`56.75% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T22:24:39Z

📝 Docs preview for commit 9bb4715 at: https://630a99822de66e5008e74d00--sqlmodel.netlify.app

tiangolo · 2022-08-27T22:28:04Z

Great! This makes sense, thank you @andrewbolster! 🍰

And thanks everyone for the discussion! ☕

This will be available in the next version, released in the next hours, SQLModel 0.0.7. 🎉

andrewbolster · 2021-08-26T06:00:16Z

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib UUID.hex method.

This also fixes#25

Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib [`UUID.hex`](https://docs.python.org/3/library/uuid.html#uuid.UUID.hex) method. This also fixesfastapi#25

hidaris · 2021-10-09T09:36:18Z

any update?

gnillev · 2021-10-15T10:56:02Z

I will just propose also adding a small test, just to catch this.

I made my own small test to catch the behaviour in a fork to fix this, before finding this pr, so you can maybe work something off of this (probably want to generalize a bit - I made it really quick just to confirm this was causing the issue):

deftest_zero_padded_uuid():
raised=Nonemyid=UUID(hex='00000000000000000000000000000001')
stored_value=GUID().process_bind_param(myid, SQLiteDialect)
try:
back_to_uuid=GUID().process_result_value(stored_value, SQLiteDialect)
exceptValueErrorasex:
raised=exassertraisedisNoneassertmyid==back_to_uuid

At 959f380

chriswhite199 · 2021-11-29T19:09:43Z

@tiangolo - Do you have any other maintainers that can help get small PRs like this merged? I'm also up against this issue, and the PR was opened 2 months ago.

mkarbo · 2021-12-02T09:33:34Z

Any news on this?

alucarddelta · 2021-12-16T02:30:13Z

I am disappointed that this simple fix was not implemented in 0.0.5, as this is causes a lot of headaches when using UUID primary keys.

mkarbo · 2021-12-29T10:44:05Z

We can hope for 0.0.7 to add this @tiangolo?

pythrick · 2021-12-31T02:38:29Z

I was just about to create an issue about it and implement the exactly same solution.

Looks like SQLModel got inspired by the same source of this gist: https://gist.github.com/gmolveau/7caeeefe637679005a7bb9ae1b5e421e

IMHO I think SQLAlquemy-Utils uses a better approach when it provides additional native dialects besides postgresql, like msql and cockroachdb, and also uses the native UUID .hex property in serialization. https://sqlalchemy-utils.readthedocs.io/en/latest/_modules/sqlalchemy_utils/types/uuid.html#UUIDType

Fork 3 (Sourcery refactored)

codecov · 2022-08-27T22:24:26Z

Codecov Report

Merging #26 (9bb4715) into main (db3ad59) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@## main #26 +/- ##
=======================================
Coverage 97.59% 97.59% =======================================
Files 182 182 Lines 6060 6060 =======================================
Hits 5914 5914 Misses 146 146

Impacted Files	Coverage Δ
sqlmodel/sql/sqltypes.py	`56.75% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-08-27T22:24:39Z

📝 Docs preview for commit 9bb4715 at: https://630a99822de66e5008e74d00--sqlmodel.netlify.app

tiangolo · 2022-08-27T22:28:04Z

Great! This makes sense, thank you @andrewbolster! 🍰

And thanks everyone for the discussion! ☕

This will be available in the next version, released in the next hours, SQLModel 0.0.7. 🎉

Update GUID handling use stdlib UUID.hex
959f380
Rather than integer based serialization grandfathered in from sqlalchemy, use the stdlib [`UUID.hex`](https://docs.python.org/3/library/uuid.html#uuid.UUID.hex) method. This also fixesfastapi#25

andrewbolster changed the title ~~Update GUID handling use stdlib UUID.hex~~Update GUID handling to use stdlib UUID.hexAug 26, 2021

RobertRosca added a commit to RobertRosca/sqlmodel that referenced this pull request Nov 2, 2021
Mergefastapi#26
991fa1f
At 959f380

synodriver pushed a commit to synodriver/sqlmodel that referenced this pull request Jun 24, 2022
Merge pull requestfastapi#26from leynier/sourcery/fork-3
31045e5
Fork 3 (Sourcery refactored)

TillerBurr mentioned this pull request Jun 29, 2022
Fixed 31 length UUID error #357
Closed

Merge branch 'main' into patch-1
9bb4715

tiangolo changed the title ~~Update GUID handling to use stdlib UUID.hex~~✨ Update GUID handling to use stdlib UUID.hex instead of an intAug 27, 2022

tiangolo merged commit 5ea9340 into fastapi:mainAug 27, 2022

tiangolo mentioned this pull request Aug 27, 2022
Improper UUID serialisation dropping leading zeros ▶️ "ValueError: badly formed hexadecimal UUID string" #25
Closed
8 tasks

paolodina mentioned this pull request Sep 8, 2022
How we can use fastapi-users-db-sqlmodel fastapi-users/fastapi-users-db-sqlmodel#2
Closed