🐛 Fix allowing using a `ForeignKey` directly, remove repeated column construction from `SQLModelMetaclass.__init__` and upgrade minimum SQLAlchemy to `>=1.4.36` by daniil-berg · Pull Request #443 · fastapi/sqlmodel

daniil-berg · 2022-09-09T11:27:18Z

Summary

There was a bug in the SQLModelMetaclass whereby the SQLAlchemy Column objects were constructed twice for each field defined on a table model: First in the meta class' __new__ method and then again in its __init__ method.

With these changes the get_column_from_field function is called only once for each field, namely in SQLModelMetaclass.__new__.

Example

Construct a table model with a foreign key explicitly constructed via the SQLAlchemy ForeignKey class:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column_args=(ForeignKey("user.id", ondelete="CASCADE"),)
)

Without the proposed changes, even just running these class definitions causes an error:

Traceback (most recent call last):
File "/home/daniil/coding/sqlmodel/experiments/__init__.py", line 12, in <module>
class Post(SQLModel, table=True):
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 329, in __init__
dict_used[field_name] = get_column_from_field(field_value)
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 457, in get_column_from_field
return Column(sa_type, *args, **kwargs) # type: ignore
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 1765, in __init__
self._init_items(*args)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 144, in _init_items
spwd(self, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/base.py", line 1047, in _set_parent_with_dispatch
self._set_parent(parent, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 2559, in _set_parent
raise exc.InvalidRequestError(
sqlalchemy.exc.InvalidRequestError: This ForeignKey already has a parent !

This is fixed with this PR.

Add the following to the example:

sqlite_url="sqlite:///:memory:"engine=create_engine(sqlite_url, echo=True)
SQLModel.metadata.create_all(engine)

There is no more error and the SQL statements are as expected:

CREATETABLEuser (
id INTEGERNOT NULL, PRIMARY KEY (id)
)
CREATETABLEpost (
id INTEGERNOT NULL, user_id INTEGERNOT NULL, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id) ON DELETE CASCADE
)

PS

The codecov bot is weird... I really don't see how coverage could possibly have decreased. The statement below is also inconsistent with the report, if you click on it. Oh well.

have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

codecov · 2022-09-09T11:28:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (5ad7c6a) 97.76%.
Report is 66 commits behind head on main.

❗ Current head 5ad7c6a differs from pull request most recent head 50a3f76. Consider uploading reports for the commit 50a3f76 to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## main #443 +/- ##
==========================================
- Coverage 98.49% 97.76% -0.74% 
==========================================
Files 185 187 +2 Lines 5856 6266 +410 ==========================================
+ Hits 5768 6126 +358 - Misses 88 140 +52

Files	Coverage Δ
sqlmodel/main.py	`84.83% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2022-09-09T11:28:46Z

📝 Docs preview for commit 5ad7c6a at: https://631b234f16d4cf27863512be--sqlmodel.netlify.app

github-actions · 2022-12-16T21:15:26Z

📝 Docs preview for commit eee8e80 at: https://639cdfc1a7c2ed00568a9bc6--sqlmodel.netlify.app

Vanderhoof · 2023-03-03T11:01:02Z

Hey is there a workaround for cascade FK definition now while this fix is being investigated? 😊

UPD, probably something like this:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemyimportColumn, Integerfromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column=Column("user_id", Integer, ForeignKey("user.id", ondelete="CASCADE")),)
)

github-actions · 2023-10-23T13:55:58Z

📝 Docs preview for commit 50a3f76 at: https://7b43a033.sqlmodel.pages.dev

tiangolo · 2023-10-23T13:58:09Z

Awesome, thanks a lot for the thorough explanation @daniil-berg! 🚀

I tweaked it and updated the internals a bit.

This will be available in the next version, 0.0.9. 🎉

# What This updates SQLModel to version 0.0.11, which solves an [issue](fastapi/sqlmodel#443) with foreign key declaration, and another [issue](fastapi/sqlmodel#58) with AsyncSession type annotations. # Why Prior to this update, attempting to delete a document with an associated index record would throw a foreign key violation error. # Test plan Add a document which results in an index record being created. Delete the same document and verify that - The document is deleted without error - The index records associated with the document are also deleted

daniil-berg · 2022-09-09T11:27:18Z

Summary

There was a bug in the SQLModelMetaclass whereby the SQLAlchemy Column objects were constructed twice for each field defined on a table model: First in the meta class' __new__ method and then again in its __init__ method.

With these changes the get_column_from_field function is called only once for each field, namely in SQLModelMetaclass.__new__.

Example

Construct a table model with a foreign key explicitly constructed via the SQLAlchemy ForeignKey class:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column_args=(ForeignKey("user.id", ondelete="CASCADE"),)
)

Without the proposed changes, even just running these class definitions causes an error:

Traceback (most recent call last):
File "/home/daniil/coding/sqlmodel/experiments/__init__.py", line 12, in <module>
class Post(SQLModel, table=True):
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 329, in __init__
dict_used[field_name] = get_column_from_field(field_value)
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 457, in get_column_from_field
return Column(sa_type, *args, **kwargs) # type: ignore
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 1765, in __init__
self._init_items(*args)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 144, in _init_items
spwd(self, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/base.py", line 1047, in _set_parent_with_dispatch
self._set_parent(parent, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 2559, in _set_parent
raise exc.InvalidRequestError(
sqlalchemy.exc.InvalidRequestError: This ForeignKey already has a parent !

This is fixed with this PR.

Add the following to the example:

sqlite_url="sqlite:///:memory:"engine=create_engine(sqlite_url, echo=True)
SQLModel.metadata.create_all(engine)

There is no more error and the SQL statements are as expected:

CREATETABLEuser (
id INTEGERNOT NULL, PRIMARY KEY (id)
)
CREATETABLEpost (
id INTEGERNOT NULL, user_id INTEGERNOT NULL, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id) ON DELETE CASCADE
)

PS

The codecov bot is weird... I really don't see how coverage could possibly have decreased. The statement below is also inconsistent with the report, if you click on it. Oh well.

have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

codecov · 2022-09-09T11:28:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (5ad7c6a) 97.76%.
Report is 66 commits behind head on main.

❗ Current head 5ad7c6a differs from pull request most recent head 50a3f76. Consider uploading reports for the commit 50a3f76 to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## main #443 +/- ##
==========================================
- Coverage 98.49% 97.76% -0.74% 
==========================================
Files 185 187 +2 Lines 5856 6266 +410 ==========================================
+ Hits 5768 6126 +358 - Misses 88 140 +52

Files	Coverage Δ
sqlmodel/main.py	`84.83% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2022-09-09T11:28:46Z

📝 Docs preview for commit 5ad7c6a at: https://631b234f16d4cf27863512be--sqlmodel.netlify.app

github-actions · 2022-12-16T21:15:26Z

📝 Docs preview for commit eee8e80 at: https://639cdfc1a7c2ed00568a9bc6--sqlmodel.netlify.app

Vanderhoof · 2023-03-03T11:01:02Z

Hey is there a workaround for cascade FK definition now while this fix is being investigated? 😊

UPD, probably something like this:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemyimportColumn, Integerfromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column=Column("user_id", Integer, ForeignKey("user.id", ondelete="CASCADE")),)
)

github-actions · 2023-10-23T13:55:58Z

📝 Docs preview for commit 50a3f76 at: https://7b43a033.sqlmodel.pages.dev

tiangolo · 2023-10-23T13:58:09Z

Awesome, thanks a lot for the thorough explanation @daniil-berg! 🚀

I tweaked it and updated the internals a bit.

This will be available in the next version, 0.0.9. 🎉

# What This updates SQLModel to version 0.0.11, which solves an [issue](fastapi/sqlmodel#443) with foreign key declaration, and another [issue](fastapi/sqlmodel#58) with AsyncSession type annotations. # Why Prior to this update, attempting to delete a document with an associated index record would throw a foreign key violation error. # Test plan Add a document which results in an index record being created. Delete the same document and verify that - The document is deleted without error - The index records associated with the document are also deleted

daniil-berg · 2022-09-09T11:27:18Z

Summary

There was a bug in the SQLModelMetaclass whereby the SQLAlchemy Column objects were constructed twice for each field defined on a table model: First in the meta class' __new__ method and then again in its __init__ method.

With these changes the get_column_from_field function is called only once for each field, namely in SQLModelMetaclass.__new__.

Example

Construct a table model with a foreign key explicitly constructed via the SQLAlchemy ForeignKey class:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column_args=(ForeignKey("user.id", ondelete="CASCADE"),)
)

Without the proposed changes, even just running these class definitions causes an error:

Traceback (most recent call last):
File "/home/daniil/coding/sqlmodel/experiments/__init__.py", line 12, in <module>
class Post(SQLModel, table=True):
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 329, in __init__
dict_used[field_name] = get_column_from_field(field_value)
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 457, in get_column_from_field
return Column(sa_type, *args, **kwargs) # type: ignore
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 1765, in __init__
self._init_items(*args)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 144, in _init_items
spwd(self, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/base.py", line 1047, in _set_parent_with_dispatch
self._set_parent(parent, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 2559, in _set_parent
raise exc.InvalidRequestError(
sqlalchemy.exc.InvalidRequestError: This ForeignKey already has a parent !

This is fixed with this PR.

Add the following to the example:

sqlite_url="sqlite:///:memory:"engine=create_engine(sqlite_url, echo=True)
SQLModel.metadata.create_all(engine)

There is no more error and the SQL statements are as expected:

CREATETABLEuser (
id INTEGERNOT NULL, PRIMARY KEY (id)
)
CREATETABLEpost (
id INTEGERNOT NULL, user_id INTEGERNOT NULL, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id) ON DELETE CASCADE
)

PS

The codecov bot is weird... I really don't see how coverage could possibly have decreased. The statement below is also inconsistent with the report, if you click on it. Oh well.

have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

codecov · 2022-09-09T11:28:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (5ad7c6a) 97.76%.
Report is 66 commits behind head on main.

❗ Current head 5ad7c6a differs from pull request most recent head 50a3f76. Consider uploading reports for the commit 50a3f76 to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## main #443 +/- ##
==========================================
- Coverage 98.49% 97.76% -0.74% 
==========================================
Files 185 187 +2 Lines 5856 6266 +410 ==========================================
+ Hits 5768 6126 +358 - Misses 88 140 +52

Files	Coverage Δ
sqlmodel/main.py	`84.83% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2022-09-09T11:28:46Z

📝 Docs preview for commit 5ad7c6a at: https://631b234f16d4cf27863512be--sqlmodel.netlify.app

github-actions · 2022-12-16T21:15:26Z

📝 Docs preview for commit eee8e80 at: https://639cdfc1a7c2ed00568a9bc6--sqlmodel.netlify.app

Vanderhoof · 2023-03-03T11:01:02Z

Hey is there a workaround for cascade FK definition now while this fix is being investigated? 😊

UPD, probably something like this:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemyimportColumn, Integerfromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column=Column("user_id", Integer, ForeignKey("user.id", ondelete="CASCADE")),)
)

github-actions · 2023-10-23T13:55:58Z

📝 Docs preview for commit 50a3f76 at: https://7b43a033.sqlmodel.pages.dev

tiangolo · 2023-10-23T13:58:09Z

Awesome, thanks a lot for the thorough explanation @daniil-berg! 🚀

I tweaked it and updated the internals a bit.

This will be available in the next version, 0.0.9. 🎉

# What This updates SQLModel to version 0.0.11, which solves an [issue](fastapi/sqlmodel#443) with foreign key declaration, and another [issue](fastapi/sqlmodel#58) with AsyncSession type annotations. # Why Prior to this update, attempting to delete a document with an associated index record would throw a foreign key violation error. # Test plan Add a document which results in an index record being created. Delete the same document and verify that - The document is deleted without error - The index records associated with the document are also deleted

daniil-berg · 2022-09-09T11:27:18Z

Summary

There was a bug in the SQLModelMetaclass whereby the SQLAlchemy Column objects were constructed twice for each field defined on a table model: First in the meta class' __new__ method and then again in its __init__ method.

With these changes the get_column_from_field function is called only once for each field, namely in SQLModelMetaclass.__new__.

Example

Construct a table model with a foreign key explicitly constructed via the SQLAlchemy ForeignKey class:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column_args=(ForeignKey("user.id", ondelete="CASCADE"),)
)

Without the proposed changes, even just running these class definitions causes an error:

Traceback (most recent call last):
File "/home/daniil/coding/sqlmodel/experiments/__init__.py", line 12, in <module>
class Post(SQLModel, table=True):
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 329, in __init__
dict_used[field_name] = get_column_from_field(field_value)
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 457, in get_column_from_field
return Column(sa_type, *args, **kwargs) # type: ignore
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 1765, in __init__
self._init_items(*args)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 144, in _init_items
spwd(self, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/base.py", line 1047, in _set_parent_with_dispatch
self._set_parent(parent, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 2559, in _set_parent
raise exc.InvalidRequestError(
sqlalchemy.exc.InvalidRequestError: This ForeignKey already has a parent !

This is fixed with this PR.

Add the following to the example:

sqlite_url="sqlite:///:memory:"engine=create_engine(sqlite_url, echo=True)
SQLModel.metadata.create_all(engine)

There is no more error and the SQL statements are as expected:

CREATETABLEuser (
id INTEGERNOT NULL, PRIMARY KEY (id)
)
CREATETABLEpost (
id INTEGERNOT NULL, user_id INTEGERNOT NULL, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id) ON DELETE CASCADE
)

PS

The codecov bot is weird... I really don't see how coverage could possibly have decreased. The statement below is also inconsistent with the report, if you click on it. Oh well.

have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

codecov · 2022-09-09T11:28:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (5ad7c6a) 97.76%.
Report is 66 commits behind head on main.

❗ Current head 5ad7c6a differs from pull request most recent head 50a3f76. Consider uploading reports for the commit 50a3f76 to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## main #443 +/- ##
==========================================
- Coverage 98.49% 97.76% -0.74% 
==========================================
Files 185 187 +2 Lines 5856 6266 +410 ==========================================
+ Hits 5768 6126 +358 - Misses 88 140 +52

Files	Coverage Δ
sqlmodel/main.py	`84.83% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2022-09-09T11:28:46Z

📝 Docs preview for commit 5ad7c6a at: https://631b234f16d4cf27863512be--sqlmodel.netlify.app

github-actions · 2022-12-16T21:15:26Z

📝 Docs preview for commit eee8e80 at: https://639cdfc1a7c2ed00568a9bc6--sqlmodel.netlify.app

Vanderhoof · 2023-03-03T11:01:02Z

Hey is there a workaround for cascade FK definition now while this fix is being investigated? 😊

UPD, probably something like this:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemyimportColumn, Integerfromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column=Column("user_id", Integer, ForeignKey("user.id", ondelete="CASCADE")),)
)

github-actions · 2023-10-23T13:55:58Z

📝 Docs preview for commit 50a3f76 at: https://7b43a033.sqlmodel.pages.dev

tiangolo · 2023-10-23T13:58:09Z

Awesome, thanks a lot for the thorough explanation @daniil-berg! 🚀

I tweaked it and updated the internals a bit.

This will be available in the next version, 0.0.9. 🎉

# What This updates SQLModel to version 0.0.11, which solves an [issue](fastapi/sqlmodel#443) with foreign key declaration, and another [issue](fastapi/sqlmodel#58) with AsyncSession type annotations. # Why Prior to this update, attempting to delete a document with an associated index record would throw a foreign key violation error. # Test plan Add a document which results in an index record being created. Delete the same document and verify that - The document is deleted without error - The index records associated with the document are also deleted

daniil-berg · 2022-09-09T11:27:18Z

Summary

There was a bug in the SQLModelMetaclass whereby the SQLAlchemy Column objects were constructed twice for each field defined on a table model: First in the meta class' __new__ method and then again in its __init__ method.

With these changes the get_column_from_field function is called only once for each field, namely in SQLModelMetaclass.__new__.

Example

Construct a table model with a foreign key explicitly constructed via the SQLAlchemy ForeignKey class:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column_args=(ForeignKey("user.id", ondelete="CASCADE"),)
)

Without the proposed changes, even just running these class definitions causes an error:

Traceback (most recent call last):
File "/home/daniil/coding/sqlmodel/experiments/__init__.py", line 12, in <module>
class Post(SQLModel, table=True):
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 329, in __init__
dict_used[field_name] = get_column_from_field(field_value)
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 457, in get_column_from_field
return Column(sa_type, *args, **kwargs) # type: ignore
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 1765, in __init__
self._init_items(*args)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 144, in _init_items
spwd(self, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/base.py", line 1047, in _set_parent_with_dispatch
self._set_parent(parent, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 2559, in _set_parent
raise exc.InvalidRequestError(
sqlalchemy.exc.InvalidRequestError: This ForeignKey already has a parent !

This is fixed with this PR.

Add the following to the example:

sqlite_url="sqlite:///:memory:"engine=create_engine(sqlite_url, echo=True)
SQLModel.metadata.create_all(engine)

There is no more error and the SQL statements are as expected:

CREATETABLEuser (
id INTEGERNOT NULL, PRIMARY KEY (id)
)
CREATETABLEpost (
id INTEGERNOT NULL, user_id INTEGERNOT NULL, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id) ON DELETE CASCADE
)

PS

The codecov bot is weird... I really don't see how coverage could possibly have decreased. The statement below is also inconsistent with the report, if you click on it. Oh well.

have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

codecov · 2022-09-09T11:28:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (5ad7c6a) 97.76%.
Report is 66 commits behind head on main.

❗ Current head 5ad7c6a differs from pull request most recent head 50a3f76. Consider uploading reports for the commit 50a3f76 to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## main #443 +/- ##
==========================================
- Coverage 98.49% 97.76% -0.74% 
==========================================
Files 185 187 +2 Lines 5856 6266 +410 ==========================================
+ Hits 5768 6126 +358 - Misses 88 140 +52

Files	Coverage Δ
sqlmodel/main.py	`84.83% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2022-09-09T11:28:46Z

📝 Docs preview for commit 5ad7c6a at: https://631b234f16d4cf27863512be--sqlmodel.netlify.app

github-actions · 2022-12-16T21:15:26Z

📝 Docs preview for commit eee8e80 at: https://639cdfc1a7c2ed00568a9bc6--sqlmodel.netlify.app

Vanderhoof · 2023-03-03T11:01:02Z

Hey is there a workaround for cascade FK definition now while this fix is being investigated? 😊

UPD, probably something like this:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemyimportColumn, Integerfromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column=Column("user_id", Integer, ForeignKey("user.id", ondelete="CASCADE")),)
)

github-actions · 2023-10-23T13:55:58Z

📝 Docs preview for commit 50a3f76 at: https://7b43a033.sqlmodel.pages.dev

tiangolo · 2023-10-23T13:58:09Z

Awesome, thanks a lot for the thorough explanation @daniil-berg! 🚀

I tweaked it and updated the internals a bit.

This will be available in the next version, 0.0.9. 🎉

# What This updates SQLModel to version 0.0.11, which solves an [issue](fastapi/sqlmodel#443) with foreign key declaration, and another [issue](fastapi/sqlmodel#58) with AsyncSession type annotations. # Why Prior to this update, attempting to delete a document with an associated index record would throw a foreign key violation error. # Test plan Add a document which results in an index record being created. Delete the same document and verify that - The document is deleted without error - The index records associated with the document are also deleted

daniil-berg · 2022-09-09T11:27:18Z

Summary

There was a bug in the SQLModelMetaclass whereby the SQLAlchemy Column objects were constructed twice for each field defined on a table model: First in the meta class' __new__ method and then again in its __init__ method.

With these changes the get_column_from_field function is called only once for each field, namely in SQLModelMetaclass.__new__.

Example

Construct a table model with a foreign key explicitly constructed via the SQLAlchemy ForeignKey class:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column_args=(ForeignKey("user.id", ondelete="CASCADE"),)
)

Without the proposed changes, even just running these class definitions causes an error:

Traceback (most recent call last):
File "/home/daniil/coding/sqlmodel/experiments/__init__.py", line 12, in <module>
class Post(SQLModel, table=True):
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 329, in __init__
dict_used[field_name] = get_column_from_field(field_value)
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 457, in get_column_from_field
return Column(sa_type, *args, **kwargs) # type: ignore
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 1765, in __init__
self._init_items(*args)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 144, in _init_items
spwd(self, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/base.py", line 1047, in _set_parent_with_dispatch
self._set_parent(parent, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 2559, in _set_parent
raise exc.InvalidRequestError(
sqlalchemy.exc.InvalidRequestError: This ForeignKey already has a parent !

This is fixed with this PR.

Add the following to the example:

sqlite_url="sqlite:///:memory:"engine=create_engine(sqlite_url, echo=True)
SQLModel.metadata.create_all(engine)

There is no more error and the SQL statements are as expected:

CREATETABLEuser (
id INTEGERNOT NULL, PRIMARY KEY (id)
)
CREATETABLEpost (
id INTEGERNOT NULL, user_id INTEGERNOT NULL, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id) ON DELETE CASCADE
)

PS

The codecov bot is weird... I really don't see how coverage could possibly have decreased. The statement below is also inconsistent with the report, if you click on it. Oh well.

have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

codecov · 2022-09-09T11:28:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (5ad7c6a) 97.76%.
Report is 66 commits behind head on main.

❗ Current head 5ad7c6a differs from pull request most recent head 50a3f76. Consider uploading reports for the commit 50a3f76 to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## main #443 +/- ##
==========================================
- Coverage 98.49% 97.76% -0.74% 
==========================================
Files 185 187 +2 Lines 5856 6266 +410 ==========================================
+ Hits 5768 6126 +358 - Misses 88 140 +52

Files	Coverage Δ
sqlmodel/main.py	`84.83% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2022-09-09T11:28:46Z

📝 Docs preview for commit 5ad7c6a at: https://631b234f16d4cf27863512be--sqlmodel.netlify.app

github-actions · 2022-12-16T21:15:26Z

📝 Docs preview for commit eee8e80 at: https://639cdfc1a7c2ed00568a9bc6--sqlmodel.netlify.app

Vanderhoof · 2023-03-03T11:01:02Z

Hey is there a workaround for cascade FK definition now while this fix is being investigated? 😊

UPD, probably something like this:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemyimportColumn, Integerfromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column=Column("user_id", Integer, ForeignKey("user.id", ondelete="CASCADE")),)
)

github-actions · 2023-10-23T13:55:58Z

📝 Docs preview for commit 50a3f76 at: https://7b43a033.sqlmodel.pages.dev

tiangolo · 2023-10-23T13:58:09Z

Awesome, thanks a lot for the thorough explanation @daniil-berg! 🚀

I tweaked it and updated the internals a bit.

This will be available in the next version, 0.0.9. 🎉

# What This updates SQLModel to version 0.0.11, which solves an [issue](fastapi/sqlmodel#443) with foreign key declaration, and another [issue](fastapi/sqlmodel#58) with AsyncSession type annotations. # Why Prior to this update, attempting to delete a document with an associated index record would throw a foreign key violation error. # Test plan Add a document which results in an index record being created. Delete the same document and verify that - The document is deleted without error - The index records associated with the document are also deleted

daniil-berg · 2022-09-09T11:27:18Z

Summary

There was a bug in the SQLModelMetaclass whereby the SQLAlchemy Column objects were constructed twice for each field defined on a table model: First in the meta class' __new__ method and then again in its __init__ method.

With these changes the get_column_from_field function is called only once for each field, namely in SQLModelMetaclass.__new__.

Example

Construct a table model with a foreign key explicitly constructed via the SQLAlchemy ForeignKey class:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column_args=(ForeignKey("user.id", ondelete="CASCADE"),)
)

Without the proposed changes, even just running these class definitions causes an error:

Traceback (most recent call last):
File "/home/daniil/coding/sqlmodel/experiments/__init__.py", line 12, in <module>
class Post(SQLModel, table=True):
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 329, in __init__
dict_used[field_name] = get_column_from_field(field_value)
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 457, in get_column_from_field
return Column(sa_type, *args, **kwargs) # type: ignore
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 1765, in __init__
self._init_items(*args)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 144, in _init_items
spwd(self, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/base.py", line 1047, in _set_parent_with_dispatch
self._set_parent(parent, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 2559, in _set_parent
raise exc.InvalidRequestError(
sqlalchemy.exc.InvalidRequestError: This ForeignKey already has a parent !

This is fixed with this PR.

Add the following to the example:

sqlite_url="sqlite:///:memory:"engine=create_engine(sqlite_url, echo=True)
SQLModel.metadata.create_all(engine)

There is no more error and the SQL statements are as expected:

CREATETABLEuser (
id INTEGERNOT NULL, PRIMARY KEY (id)
)
CREATETABLEpost (
id INTEGERNOT NULL, user_id INTEGERNOT NULL, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id) ON DELETE CASCADE
)

PS

The codecov bot is weird... I really don't see how coverage could possibly have decreased. The statement below is also inconsistent with the report, if you click on it. Oh well.

have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

codecov · 2022-09-09T11:28:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (5ad7c6a) 97.76%.
Report is 66 commits behind head on main.

❗ Current head 5ad7c6a differs from pull request most recent head 50a3f76. Consider uploading reports for the commit 50a3f76 to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## main #443 +/- ##
==========================================
- Coverage 98.49% 97.76% -0.74% 
==========================================
Files 185 187 +2 Lines 5856 6266 +410 ==========================================
+ Hits 5768 6126 +358 - Misses 88 140 +52

Files	Coverage Δ
sqlmodel/main.py	`84.83% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2022-09-09T11:28:46Z

📝 Docs preview for commit 5ad7c6a at: https://631b234f16d4cf27863512be--sqlmodel.netlify.app

github-actions · 2022-12-16T21:15:26Z

📝 Docs preview for commit eee8e80 at: https://639cdfc1a7c2ed00568a9bc6--sqlmodel.netlify.app

Vanderhoof · 2023-03-03T11:01:02Z

Hey is there a workaround for cascade FK definition now while this fix is being investigated? 😊

UPD, probably something like this:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemyimportColumn, Integerfromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column=Column("user_id", Integer, ForeignKey("user.id", ondelete="CASCADE")),)
)

github-actions · 2023-10-23T13:55:58Z

📝 Docs preview for commit 50a3f76 at: https://7b43a033.sqlmodel.pages.dev

tiangolo · 2023-10-23T13:58:09Z

Awesome, thanks a lot for the thorough explanation @daniil-berg! 🚀

I tweaked it and updated the internals a bit.

This will be available in the next version, 0.0.9. 🎉

# What This updates SQLModel to version 0.0.11, which solves an [issue](fastapi/sqlmodel#443) with foreign key declaration, and another [issue](fastapi/sqlmodel#58) with AsyncSession type annotations. # Why Prior to this update, attempting to delete a document with an associated index record would throw a foreign key violation error. # Test plan Add a document which results in an index record being created. Delete the same document and verify that - The document is deleted without error - The index records associated with the document are also deleted

daniil-berg · 2022-09-09T11:27:18Z

Summary

There was a bug in the SQLModelMetaclass whereby the SQLAlchemy Column objects were constructed twice for each field defined on a table model: First in the meta class' __new__ method and then again in its __init__ method.

With these changes the get_column_from_field function is called only once for each field, namely in SQLModelMetaclass.__new__.

Example

Construct a table model with a foreign key explicitly constructed via the SQLAlchemy ForeignKey class:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column_args=(ForeignKey("user.id", ondelete="CASCADE"),)
)

Without the proposed changes, even just running these class definitions causes an error:

Traceback (most recent call last):
File "/home/daniil/coding/sqlmodel/experiments/__init__.py", line 12, in <module>
class Post(SQLModel, table=True):
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 329, in __init__
dict_used[field_name] = get_column_from_field(field_value)
File "/home/daniil/coding/sqlmodel/sqlmodel/main.py", line 457, in get_column_from_field
return Column(sa_type, *args, **kwargs) # type: ignore
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 1765, in __init__
self._init_items(*args)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 144, in _init_items
spwd(self, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/base.py", line 1047, in _set_parent_with_dispatch
self._set_parent(parent, **kw)
File "/home/daniil/.cache/pypoetry/virtualenvs/sqlmodel-TV15XYpK-py3.10/lib/python3.10/site-packages/sqlalchemy/sql/schema.py", line 2559, in _set_parent
raise exc.InvalidRequestError(
sqlalchemy.exc.InvalidRequestError: This ForeignKey already has a parent !

This is fixed with this PR.

Add the following to the example:

sqlite_url="sqlite:///:memory:"engine=create_engine(sqlite_url, echo=True)
SQLModel.metadata.create_all(engine)

There is no more error and the SQL statements are as expected:

CREATETABLEuser (
id INTEGERNOT NULL, PRIMARY KEY (id)
)
CREATETABLEpost (
id INTEGERNOT NULL, user_id INTEGERNOT NULL, PRIMARY KEY (id), FOREIGN KEY(user_id) REFERENCES user (id) ON DELETE CASCADE
)

PS

The codecov bot is weird... I really don't see how coverage could possibly have decreased. The statement below is also inconsistent with the report, if you click on it. Oh well.

have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

codecov · 2022-09-09T11:28:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (5ad7c6a) 97.76%.
Report is 66 commits behind head on main.

❗ Current head 5ad7c6a differs from pull request most recent head 50a3f76. Consider uploading reports for the commit 50a3f76 to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## main #443 +/- ##
==========================================
- Coverage 98.49% 97.76% -0.74% 
==========================================
Files 185 187 +2 Lines 5856 6266 +410 ==========================================
+ Hits 5768 6126 +358 - Misses 88 140 +52

Files	Coverage Δ
sqlmodel/main.py	`84.83% <ø> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2022-09-09T11:28:46Z

📝 Docs preview for commit 5ad7c6a at: https://631b234f16d4cf27863512be--sqlmodel.netlify.app

github-actions · 2022-12-16T21:15:26Z

📝 Docs preview for commit eee8e80 at: https://639cdfc1a7c2ed00568a9bc6--sqlmodel.netlify.app

Vanderhoof · 2023-03-03T11:01:02Z

Hey is there a workaround for cascade FK definition now while this fix is being investigated? 😊

UPD, probably something like this:

fromsqlmodelimportField, SQLModel, create_enginefromsqlalchemyimportColumn, Integerfromsqlalchemy.sql.schemaimportForeignKeyclassUser(SQLModel, table=True):
id: int=Field(primary_key=True)
classPost(SQLModel, table=True):
id: int=Field(primary_key=True)
user_id: int=Field(
sa_column=Column("user_id", Integer, ForeignKey("user.id", ondelete="CASCADE")),)
)

github-actions · 2023-10-23T13:55:58Z

📝 Docs preview for commit 50a3f76 at: https://7b43a033.sqlmodel.pages.dev

tiangolo · 2023-10-23T13:58:09Z

Awesome, thanks a lot for the thorough explanation @daniil-berg! 🚀

I tweaked it and updated the internals a bit.

This will be available in the next version, 0.0.9. 🎉

# What This updates SQLModel to version 0.0.11, which solves an [issue](fastapi/sqlmodel#443) with foreign key declaration, and another [issue](fastapi/sqlmodel#58) with AsyncSession type annotations. # Why Prior to this update, attempting to delete a document with an associated index record would throw a foreign key violation error. # Test plan Add a document which results in an index record being created. Delete the same document and verify that - The document is deleted without error - The index records associated with the document are also deleted

🐛 Remove repeated column construction from SQLModelMetaclass.__init__;
5ad7c6a
have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

tiangolo added the investigate label Nov 22, 2022

Merge branch 'main' into construct-column-only-once
eee8e80

tiangolo added the bug Something isn't working label Oct 22, 2023

tiangolo added 3 commits October 23, 2023 15:36

Merge branch 'main' into construct-column-only-once
ee150ad

⬆️ Upgrade SQLAlchemy requirement to >=1.4.36
6497f7d

🐛 Do not re-create metaclass dict for new class
50a3f76

tiangolo changed the title ~~🐛 Remove repeated column construction from SQLModelMetaclass.__init__~~🐛 Fix allowing using a ForeignKey directly, remove repeated column construction from SQLModelMetaclass.__init__Oct 23, 2023

tiangolo removed the investigate label Oct 23, 2023

tiangolo merged commit 9809b5b into fastapi:mainOct 23, 2023

shabani1 mentioned this pull request Nov 3, 2023
Updated SQLModel to 0.0.11 lexy-ai/lexy#22
Merged

🐛 Remove repeated column construction from SQLModelMetaclass.__init__;
5ad7c6a
have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

tiangolo added the investigate label Nov 22, 2022

Merge branch 'main' into construct-column-only-once
eee8e80

tiangolo added the bug Something isn't working label Oct 22, 2023

tiangolo added 3 commits October 23, 2023 15:36

Merge branch 'main' into construct-column-only-once
ee150ad

⬆️ Upgrade SQLAlchemy requirement to >=1.4.36
6497f7d

🐛 Do not re-create metaclass dict for new class
50a3f76

tiangolo changed the title ~~🐛 Remove repeated column construction from SQLModelMetaclass.__init__~~🐛 Fix allowing using a ForeignKey directly, remove repeated column construction from SQLModelMetaclass.__init__Oct 23, 2023

tiangolo removed the investigate label Oct 23, 2023

tiangolo merged commit 9809b5b into fastapi:mainOct 23, 2023

shabani1 mentioned this pull request Nov 3, 2023
Updated SQLModel to 0.0.11 lexy-ai/lexy#22
Merged

🐛 Remove repeated column construction from SQLModelMetaclass.__init__;
5ad7c6a
have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

tiangolo added the investigate label Nov 22, 2022

Merge branch 'main' into construct-column-only-once
eee8e80

tiangolo added the bug Something isn't working label Oct 22, 2023

tiangolo added 3 commits October 23, 2023 15:36

Merge branch 'main' into construct-column-only-once
ee150ad

⬆️ Upgrade SQLAlchemy requirement to >=1.4.36
6497f7d

🐛 Do not re-create metaclass dict for new class
50a3f76

tiangolo changed the title ~~🐛 Remove repeated column construction from SQLModelMetaclass.__init__~~🐛 Fix allowing using a ForeignKey directly, remove repeated column construction from SQLModelMetaclass.__init__Oct 23, 2023

tiangolo removed the investigate label Oct 23, 2023

tiangolo merged commit 9809b5b into fastapi:mainOct 23, 2023

shabani1 mentioned this pull request Nov 3, 2023
Updated SQLModel to 0.0.11 lexy-ai/lexy#22
Merged

🐛 Remove repeated column construction from SQLModelMetaclass.__init__;
5ad7c6a
have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

tiangolo added the investigate label Nov 22, 2022

Merge branch 'main' into construct-column-only-once
eee8e80

tiangolo added the bug Something isn't working label Oct 22, 2023

tiangolo added 3 commits October 23, 2023 15:36

Merge branch 'main' into construct-column-only-once
ee150ad

⬆️ Upgrade SQLAlchemy requirement to >=1.4.36
6497f7d

🐛 Do not re-create metaclass dict for new class
50a3f76

tiangolo changed the title ~~🐛 Remove repeated column construction from SQLModelMetaclass.__init__~~🐛 Fix allowing using a ForeignKey directly, remove repeated column construction from SQLModelMetaclass.__init__Oct 23, 2023

tiangolo removed the investigate label Oct 23, 2023

tiangolo merged commit 9809b5b into fastapi:mainOct 23, 2023

shabani1 mentioned this pull request Nov 3, 2023
Updated SQLModel to 0.0.11 lexy-ai/lexy#22
Merged

🐛 Remove repeated column construction from SQLModelMetaclass.__init__;
5ad7c6a
have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

tiangolo added the investigate label Nov 22, 2022

Merge branch 'main' into construct-column-only-once
eee8e80

tiangolo added the bug Something isn't working label Oct 22, 2023

tiangolo added 3 commits October 23, 2023 15:36

Merge branch 'main' into construct-column-only-once
ee150ad

⬆️ Upgrade SQLAlchemy requirement to >=1.4.36
6497f7d

🐛 Do not re-create metaclass dict for new class
50a3f76

tiangolo changed the title ~~🐛 Remove repeated column construction from SQLModelMetaclass.__init__~~🐛 Fix allowing using a ForeignKey directly, remove repeated column construction from SQLModelMetaclass.__init__Oct 23, 2023

tiangolo removed the investigate label Oct 23, 2023

tiangolo merged commit 9809b5b into fastapi:mainOct 23, 2023

shabani1 mentioned this pull request Nov 3, 2023
Updated SQLModel to 0.0.11 lexy-ai/lexy#22
Merged

🐛 Remove repeated column construction from SQLModelMetaclass.__init__;
5ad7c6a
have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

tiangolo added the investigate label Nov 22, 2022

Merge branch 'main' into construct-column-only-once
eee8e80

tiangolo added the bug Something isn't working label Oct 22, 2023

tiangolo added 3 commits October 23, 2023 15:36

Merge branch 'main' into construct-column-only-once
ee150ad

⬆️ Upgrade SQLAlchemy requirement to >=1.4.36
6497f7d

🐛 Do not re-create metaclass dict for new class
50a3f76

tiangolo changed the title ~~🐛 Remove repeated column construction from SQLModelMetaclass.__init__~~🐛 Fix allowing using a ForeignKey directly, remove repeated column construction from SQLModelMetaclass.__init__Oct 23, 2023

tiangolo removed the investigate label Oct 23, 2023

tiangolo merged commit 9809b5b into fastapi:mainOct 23, 2023

shabani1 mentioned this pull request Nov 3, 2023
Updated SQLModel to 0.0.11 lexy-ai/lexy#22
Merged

🐛 Remove repeated column construction from SQLModelMetaclass.__init__;
5ad7c6a
have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

tiangolo added the investigate label Nov 22, 2022

Merge branch 'main' into construct-column-only-once
eee8e80

tiangolo added the bug Something isn't working label Oct 22, 2023

tiangolo added 3 commits October 23, 2023 15:36

Merge branch 'main' into construct-column-only-once
ee150ad

⬆️ Upgrade SQLAlchemy requirement to >=1.4.36
6497f7d

🐛 Do not re-create metaclass dict for new class
50a3f76

tiangolo changed the title ~~🐛 Remove repeated column construction from SQLModelMetaclass.__init__~~🐛 Fix allowing using a ForeignKey directly, remove repeated column construction from SQLModelMetaclass.__init__Oct 23, 2023

tiangolo removed the investigate label Oct 23, 2023

tiangolo merged commit 9809b5b into fastapi:mainOct 23, 2023

shabani1 mentioned this pull request Nov 3, 2023
Updated SQLModel to 0.0.11 lexy-ai/lexy#22
Merged

🐛 Remove repeated column construction from SQLModelMetaclass.__init__;
5ad7c6a
have `get_column_from_field` be called once for each field (in `SQLModelMetaclass.__new__`)

tiangolo added the investigate label Nov 22, 2022

Merge branch 'main' into construct-column-only-once
eee8e80

tiangolo added the bug Something isn't working label Oct 22, 2023

tiangolo added 3 commits October 23, 2023 15:36

Merge branch 'main' into construct-column-only-once
ee150ad

⬆️ Upgrade SQLAlchemy requirement to >=1.4.36
6497f7d

🐛 Do not re-create metaclass dict for new class
50a3f76

tiangolo changed the title ~~🐛 Remove repeated column construction from SQLModelMetaclass.__init__~~🐛 Fix allowing using a ForeignKey directly, remove repeated column construction from SQLModelMetaclass.__init__Oct 23, 2023

tiangolo removed the investigate label Oct 23, 2023

tiangolo merged commit 9809b5b into fastapi:mainOct 23, 2023

shabani1 mentioned this pull request Nov 3, 2023
Updated SQLModel to 0.0.11 lexy-ai/lexy#22
Merged

Uh oh!

Uh oh!

Conversation

daniil-berg commented Sep 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Example

PS

Uh oh!

codecovBot commented Sep 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actionsBot commented Sep 9, 2022

Uh oh!

github-actionsBot commented Dec 16, 2022

Uh oh!

Vanderhoof commented Mar 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Oct 23, 2023

Uh oh!

tiangolo commented Oct 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

daniil-berg commented Sep 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Example

PS

Uh oh!

codecovBot commented Sep 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actionsBot commented Sep 9, 2022

Uh oh!

github-actionsBot commented Dec 16, 2022

Uh oh!

Vanderhoof commented Mar 3, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Oct 23, 2023

Uh oh!

tiangolo commented Oct 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

daniil-berg commented Sep 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Example

PS

Uh oh!

codecovBot commented Sep 9, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actionsBot commented Sep 9, 2022

Uh oh!

github-actionsBot commented Dec 16, 2022

daniil-berg commented Sep 9, 2022•
edited
Loading

codecovBot commented Sep 9, 2022•
edited
Loading

Vanderhoof commented Mar 3, 2023•
edited
Loading

daniil-berg commented Sep 9, 2022•
edited
Loading

codecovBot commented Sep 9, 2022•
edited
Loading

Vanderhoof commented Mar 3, 2023•
edited
Loading

daniil-berg commented Sep 9, 2022•
edited
Loading

codecovBot commented Sep 9, 2022•
edited
Loading

Vanderhoof commented Mar 3, 2023•
edited
Loading

daniil-berg commented Sep 9, 2022•
edited
Loading

codecovBot commented Sep 9, 2022•
edited
Loading

Vanderhoof commented Mar 3, 2023•
edited
Loading