🔧 fix(type annotation): Add SelectOfScalar to AsyncSession exec statement type annotation

[AlexShein]

Hi, the statement argument type annotation of the exec method in the AsyncSession doesn't include SelectOfScalar[_T] causing mypy to complain about using await session.exec(select(Model)):

error: Argument 1 to "exec" of "AsyncSession" has incompatible type "SelectOfScalar[Model]"; expected "Union[Select[<nothing>], Executable[<nothing>]]"

Since the synchronous self.sync_session.execis used under the hood, type annotations for the statement argument should be the same.

[github-actions]

📝 Docs preview for commit 43b4d4a at: https://6437d39190ee0c0f959f8b51--sqlmodel.netlify.app

[antont]

Hi, just a question, if you don't mind:

We are using, with SA 1.4, session and select from there directly:

from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.future import select

is there some benefit to using them via SQLModel? I haven't noticed any problems with just using the SA ones directly. The version in SQLModel that this PR touches does not seem to do much?

[tiangolo]

Thank you! This was solved in #58

The fix will be available in the next version, 0.0.9 🎉

Given that I'll close this one, but thanks for the work! ☕

[AlexShein]

Hi, the statement argument type annotation of the exec method in the AsyncSession doesn't include SelectOfScalar[_T] causing mypy to complain about using await session.exec(select(Model)):

error: Argument 1 to "exec" of "AsyncSession" has incompatible type "SelectOfScalar[Model]"; expected "Union[Select[<nothing>], Executable[<nothing>]]"

Since the synchronous self.sync_session.execis used under the hood, type annotations for the statement argument should be the same.

[github-actions]

📝 Docs preview for commit 43b4d4a at: https://6437d39190ee0c0f959f8b51--sqlmodel.netlify.app

[antont]

Hi, just a question, if you don't mind:

We are using, with SA 1.4, session and select from there directly:

from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.future import select

is there some benefit to using them via SQLModel? I haven't noticed any problems with just using the SA ones directly. The version in SQLModel that this PR touches does not seem to do much?

[tiangolo]

Thank you! This was solved in #58

The fix will be available in the next version, 0.0.9 🎉

Given that I'll close this one, but thanks for the work! ☕

[AlexShein]

Hi, the statement argument type annotation of the exec method in the AsyncSession doesn't include SelectOfScalar[_T] causing mypy to complain about using await session.exec(select(Model)):

error: Argument 1 to "exec" of "AsyncSession" has incompatible type "SelectOfScalar[Model]"; expected "Union[Select[<nothing>], Executable[<nothing>]]"

Since the synchronous self.sync_session.execis used under the hood, type annotations for the statement argument should be the same.

[github-actions]

📝 Docs preview for commit 43b4d4a at: https://6437d39190ee0c0f959f8b51--sqlmodel.netlify.app

[antont]

Hi, just a question, if you don't mind:

We are using, with SA 1.4, session and select from there directly:

from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.future import select

is there some benefit to using them via SQLModel? I haven't noticed any problems with just using the SA ones directly. The version in SQLModel that this PR touches does not seem to do much?

[tiangolo]

Thank you! This was solved in #58

The fix will be available in the next version, 0.0.9 🎉

Given that I'll close this one, but thanks for the work! ☕

[AlexShein]

Hi, the statement argument type annotation of the exec method in the AsyncSession doesn't include SelectOfScalar[_T] causing mypy to complain about using await session.exec(select(Model)):

error: Argument 1 to "exec" of "AsyncSession" has incompatible type "SelectOfScalar[Model]"; expected "Union[Select[<nothing>], Executable[<nothing>]]"

Since the synchronous self.sync_session.execis used under the hood, type annotations for the statement argument should be the same.

[github-actions]

📝 Docs preview for commit 43b4d4a at: https://6437d39190ee0c0f959f8b51--sqlmodel.netlify.app

[antont]

Hi, just a question, if you don't mind:

We are using, with SA 1.4, session and select from there directly:

from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.future import select

is there some benefit to using them via SQLModel? I haven't noticed any problems with just using the SA ones directly. The version in SQLModel that this PR touches does not seem to do much?

[tiangolo]

Thank you! This was solved in #58

The fix will be available in the next version, 0.0.9 🎉

Given that I'll close this one, but thanks for the work! ☕

[AlexShein]

Hi, the statement argument type annotation of the exec method in the AsyncSession doesn't include SelectOfScalar[_T] causing mypy to complain about using await session.exec(select(Model)):

error: Argument 1 to "exec" of "AsyncSession" has incompatible type "SelectOfScalar[Model]"; expected "Union[Select[<nothing>], Executable[<nothing>]]"

Since the synchronous self.sync_session.execis used under the hood, type annotations for the statement argument should be the same.

[github-actions]

📝 Docs preview for commit 43b4d4a at: https://6437d39190ee0c0f959f8b51--sqlmodel.netlify.app

[antont]

Hi, just a question, if you don't mind:

We are using, with SA 1.4, session and select from there directly:

from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.future import select

is there some benefit to using them via SQLModel? I haven't noticed any problems with just using the SA ones directly. The version in SQLModel that this PR touches does not seem to do much?

[tiangolo]

Thank you! This was solved in #58

The fix will be available in the next version, 0.0.9 🎉

Given that I'll close this one, but thanks for the work! ☕

[AlexShein]

Hi, the statement argument type annotation of the exec method in the AsyncSession doesn't include SelectOfScalar[_T] causing mypy to complain about using await session.exec(select(Model)):

error: Argument 1 to "exec" of "AsyncSession" has incompatible type "SelectOfScalar[Model]"; expected "Union[Select[<nothing>], Executable[<nothing>]]"

Since the synchronous self.sync_session.execis used under the hood, type annotations for the statement argument should be the same.

[github-actions]

📝 Docs preview for commit 43b4d4a at: https://6437d39190ee0c0f959f8b51--sqlmodel.netlify.app

[antont]

Hi, just a question, if you don't mind:

We are using, with SA 1.4, session and select from there directly:

from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.future import select

is there some benefit to using them via SQLModel? I haven't noticed any problems with just using the SA ones directly. The version in SQLModel that this PR touches does not seem to do much?

[tiangolo]

Thank you! This was solved in #58

The fix will be available in the next version, 0.0.9 🎉

Given that I'll close this one, but thanks for the work! ☕

[AlexShein]

Hi, the statement argument type annotation of the exec method in the AsyncSession doesn't include SelectOfScalar[_T] causing mypy to complain about using await session.exec(select(Model)):

error: Argument 1 to "exec" of "AsyncSession" has incompatible type "SelectOfScalar[Model]"; expected "Union[Select[<nothing>], Executable[<nothing>]]"

Since the synchronous self.sync_session.execis used under the hood, type annotations for the statement argument should be the same.

[github-actions]

📝 Docs preview for commit 43b4d4a at: https://6437d39190ee0c0f959f8b51--sqlmodel.netlify.app

[antont]

Hi, just a question, if you don't mind:

We are using, with SA 1.4, session and select from there directly:

from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.future import select

is there some benefit to using them via SQLModel? I haven't noticed any problems with just using the SA ones directly. The version in SQLModel that this PR touches does not seem to do much?

[tiangolo]

Thank you! This was solved in #58

The fix will be available in the next version, 0.0.9 🎉

Given that I'll close this one, but thanks for the work! ☕

[AlexShein]

Hi, the statement argument type annotation of the exec method in the AsyncSession doesn't include SelectOfScalar[_T] causing mypy to complain about using await session.exec(select(Model)):

error: Argument 1 to "exec" of "AsyncSession" has incompatible type "SelectOfScalar[Model]"; expected "Union[Select[<nothing>], Executable[<nothing>]]"

Since the synchronous self.sync_session.execis used under the hood, type annotations for the statement argument should be the same.

[github-actions]

📝 Docs preview for commit 43b4d4a at: https://6437d39190ee0c0f959f8b51--sqlmodel.netlify.app

[antont]

Hi, just a question, if you don't mind:

We are using, with SA 1.4, session and select from there directly:

from sqlalchemy.ext.asyncio import AsyncSession
from sqlalchemy.future import select

is there some benefit to using them via SQLModel? I haven't noticed any problems with just using the SA ones directly. The version in SQLModel that this PR touches does not seem to do much?

[tiangolo]

Thank you! This was solved in #58

The fix will be available in the next version, 0.0.9 🎉

Given that I'll close this one, but thanks for the work! ☕