Uh oh!
There was an error while loading. Please reload this page.
docs: add fastfields-helpers to the CONTRIBUTING.md layer diagram - #11
Merged
Conversation
The layer diagram in CONTRIBUTING.md enumerated the six original repos but predates fastfields-helpers -- the pure-Python enums/normalisation package extracted from fastfields-dlpack. Add it as an independent sibling (neither depends on the other) consumed by the numpy/torch/cupy wrappers and the umbrella fastfields package. Also note in the Workflows section that fastfields-helpers is the one repo that needs neither fastfields-dlpack nor the C++ build toolchain, via the reusable workflow's new `needs-dlpack: false` input (#10). Factual housekeeping only, not a design change -- the cu124 wheel-lane naming drift a few sections down is pre-existing and out of scope here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
…ly wrote a placeholder) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CONTRIBUTING.md's layer diagram enumerates every repo in the project, and now predatesfastfields-helpers— the pure-Python enums/normalisation package extracted fromfastfields-dlpackin this migration.What
fastfields-helpersto the ASCII layer diagram, as an independent sibling offastfields-dlpack(neither depends on the other), consumed by the numpy/torch/cupy wrappers and the umbrellafastfieldspackage.fastfields-helpersis the one repo needing neitherfastfields-dlpacknor the C++ toolchain, via the reusable workflow'sneeds-dlpack: falseinput (python-test: add aneeds-dlpackinput to skip the dlpack source build #10, already merged).Scope
Factual housekeeping only — matches this migration's "note the package count is now six" instruction. Deliberately does not touch the pre-existing
cu124wheel-lane naming drift a few sections down (superseded byfastfields/whl's owncu118/cu126/cu130convention) — that's a separate, unrelated cleanup outside this task's scope.Note: the first commit on this branch accidentally pushed placeholder text instead of the real file; the second commit restores and applies the intended diff. The end state (visible in the diff below) is correct.
🤖 Generated with Claude Code
https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Generated by Claude Code