Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 20, 2026. It is now read-only.
chore(ci): bump impl submodule to current fastfields-cpu-impl main - #6
Merged
Conversation
The gitlink pinned an old cpu-impl commit (predating distance_euclidean.h at the repo root), so the real-submodule CI checkout couldn't find impl/*.h. Point it at fastfields-cpu-impl@main (which itself now pins the current kernels). Co-lands with the checkout-token change (#5) to get `make test` green in CI. Part of fastfields/fastfields-lib#10. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Uh oh!
There was an error while loading. Please reload this page.
balbasty pushed a commit
that referenced
this pull request
Jul 24, 2026
DLPack permits DLTensor.strides == NULL for a compact row-major tensor, but every cpu-lib module fed x.strides straight into CANUSE32BITS / copy_if_needed and the impl loops, all of which dereference it -> a producer that omits strides would segfault. nanobind always supplies strides so the current bindings never hit it, but the "accepts any __dlpack__ object" contract means an external DLPack producer can. - autocast.h: add a ContiguousStrides RAII wrapper holding a normalised copy of the (POD) descriptor; when strides are NULL it synthesises explicit contiguous strides (in elements) that outlive the call. An `enable` flag skips optional placeholder tensors (posdef `weight`, mesh `nearest_vertex`) whose shape may be invalid and whose strides are never read. - Every public entry (distance/posdef/resize/restrict/splinc/pushpull/reg_field/ reg_flow) normalises its tensors through the wrapper before dispatch; the bodies are otherwise unchanged, so the strides-supplied path is identical. - tests/test_resize: a null-strides regression (strides=NULL must match the same call with explicit contiguous strides). Verified: all 8 module test suites pass (test_resize now 211 checks incl. the null-strides case). Companion kernels change guards canUse32BitIndexMath. Part of #6. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
balbasty added a commit
that referenced
this pull request
Jul 24, 2026
DLPack permits DLTensor.strides == NULL for a compact row-major tensor, but every cpu-lib module fed x.strides straight into CANUSE32BITS / copy_if_needed and the impl loops, all of which dereference it -> a producer that omits strides would segfault. nanobind always supplies strides so the current bindings never hit it, but the "accepts any __dlpack__ object" contract means an external DLPack producer can. - autocast.h: add a ContiguousStrides RAII wrapper holding a normalised copy of the (POD) descriptor; when strides are NULL it synthesises explicit contiguous strides (in elements) that outlive the call. An `enable` flag skips optional placeholder tensors (posdef `weight`, mesh `nearest_vertex`) whose shape may be invalid and whose strides are never read. - Every public entry (distance/posdef/resize/restrict/splinc/pushpull/reg_field/ reg_flow) normalises its tensors through the wrapper before dispatch; the bodies are otherwise unchanged, so the strides-supplied path is identical. - tests/test_resize: a null-strides regression (strides=NULL must match the same call with explicit contiguous strides). Verified: all 8 module test suites pass (test_resize now 211 checks incl. the null-strides case). Companion kernels change guards canUse32BitIndexMath. Part of #6. Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
implgitlink pinned an old cpu-impl commit (predatingdistance_euclidean.hat the repo root), so the real-submodule CI checkout resolvedimpl/kernels/*but not cpu-impl's own headers —fatal error: 'impl/distance_euclidean.h' file not found. Point it atfastfields-cpu-impl@main(which now pins current kernels).Co-lands with the checkout-token PR #5 — neither goes green alone (this one lacks the token; #5 has the stale pointer), so they merge together and
mainCI verifies green.Part of fastfields/fastfields-lib#10.
🤖 Generated with Claude Code
Generated by Claude Code