Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 20, 2026. It is now read-only.
deps: bump impl pin to the diag_bending/diag_all corner cross-term fix - #88
Merged
Conversation
Picks up fastfields-cpu-impl#72 (5e2c78e), which in turn moves the kernels pin to fastfields-kernels#81 (1df9fd3) -- the fix for the doubled fx1*fy0 / dropped fx0*fy1 corner term in the boundary-corrected diagonal of diag_bending (field 2d/3d, flow 2d/3d) and diag_all (flow 2d/3d). That defect corrupted the shipped field_diag/flow_diag output at boundary voxels under sign-flipping bounds (Zero/DST1/DST2) whenever bending was active, and so any Jacobi preconditioner built from that diagonal. Also carries kernels#79 (93a954b), the restrict.h -> batch.h include for index2sub that the previous chain predated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Submodule staleness (non-blocking -- fastfields-lib#15)
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the
implgitlink from41d66b3to5e2c78e(currentfastfields-cpu-implmain). Gitlink-only —git diff-treebetweenmainand this branch reports exactly one modified path,impl.Resulting chain
which brings the CPU path onto:
1df9fd3fx1*fy0/ droppedfx0*fy1corner term in the boundary-corrected diagonal ofdiag_bending(field 2d/3d, flow 2d/3d) anddiag_all(flow 2d/3d). The defect corruptedfield_diag/flow_diagat boundary voxels under sign-flipping bounds (Zero/DST1/DST2) with bending active, and hence any Jacobi preconditioner built from that diagonal.93a954brestrict.hincludesbatch.hforindex2sub; the previous chain predated it, so g++ could not compile this tree at all.Pin hygiene
Both pins are the squash-merge commits that actually exist on their repos'
main, not pre-merge branch heads — this project has hit dangling pins that way before. Verified each resolves before opening.Verification
Full CPU suite over this exact chain,
make -j4 test CXX=clang++— 13/13 suites pass, 0 failures:Note the existing suite is green both before and after this bump — nothing currently on
maincovers the corrected boundary corners. The regression test that does fail without kernels#81 follows immediately in a separate PR, which this bump unblocks.🤖 Generated with Claude Code
https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Generated by Claude Code