Skip to content
This repository was archived by the owner on Aug 20, 2026. It is now read-only.

deps: bump kernels pin to the diag_bending/diag_all corner cross-term fix - #49

Merged
balbasty merged 1 commit into
mainfrom
claude/bump-kernels-cuda-pin-skew
Aug 18, 2026
Merged

deps: bump kernels pin to the diag_bending/diag_all corner cross-term fix#49
balbasty merged 1 commit into
mainfrom
claude/bump-kernels-cuda-pin-skew

Conversation

@balbasty

Copy link
Copy Markdown
Contributor

What

Moves the kernels gitlink from 3e38c85 to 1df9fd3 (current fastfields-kernelsmain), putting the CUDA path on the same kernels commit the CPU path now uses. Gitlink-only — exactly one modified path.

Why: a real, live pin skew

Tracing the actual gitlinks on main before this PR:

CPU path : cpu-lib -> cpu-impl 41d66b3 -> kernels be7be08
CUDA path: cuda-lib -> cuda-impl a099a04 -> kernels b09b284

The two backends resolved to different kernels commits, with CUDA three behind (b09b284..be7be08 = kernels #74, #76, #78). This repo's own main was in a third state again (3e38c85), because cuda-lib's impl pin is itself well behind cuda-implmain.

This PR fixes the lower half of that chain. The cuda-libcuda-impl half follows in a separate PR.

What it picks up here (3e38c851df9fd3)

kernels PRcommiteffect
#78be7be08drops the pointless virtual destructors from distance/meshNode/BoundingSphere
#7993a954brestrict.h includes batch.h for index2sub
#811df9fd3correctness. The doubled fx1*fy0 / dropped fx0*fy1 corner term in the boundary-corrected diagonal of diag_bending (field 2d/3d, flow 2d/3d) and diag_all (flow 2d/3d). These are shared kernel headers, so the CUDA backend carried the identical defect.

3e38c85 is an ancestor of 1df9fd3, so this is a fast-forward of the pin.

Verification

Per this project's standard: the shared kernel math is validated by the CPU suite (the same headers compile for both backends), and the CUDA-only glue by nvcc compile+link, since there is no GPU in CI.

  • Shared math — full CPU suite over kernels 1df9fd3: 13/13 suites, 0 failures (test_reg_field 18284 checks, test_reg_flow 11415). Additionally, the new boundary-symmetry regression tests fail loudly against the pre-fix kernels (328 + 1696 failures) and pass against 1df9fd3, so the corrected corner term is genuinely exercised.
  • CUDA compile+link — this PR's build-via-cuda-lib job, which runs the repo's real invocation (make -C . -j2 CXX=clang++ CXXFLAGS="-std=c++14 -O1"), preserving the -O1 host-code setting and cuda-lib's split MODULES list.

Pin hygiene

1df9fd3 is the squash-merge commit that actually exists on fastfields-kernelsmain, not a pre-merge branch head. Verified it resolves before opening.

🤖 Generated with Claude Code

https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z


Generated by Claude Code

… fix
Moves the kernels gitlink from 3e38c85 to 1df9fd3, bringing the CUDA path
onto the same kernels commit the CPU path now uses.
Picks up:
* kernels#81 (1df9fd3) -- corrects the doubled fx1*fy0 / dropped fx0*fy1
corner term in the boundary-corrected diagonal of diag_bending (field
2d/3d, flow 2d/3d) and diag_all (flow 2d/3d). These are shared kernel
headers, so the CUDA backend had the same defect.
* kernels#79 (93a954b) -- restrict.h includes batch.h for index2sub.
* kernels#78 (be7be08) -- drop the pointless virtual destructors from
distance/mesh Node/BoundingSphere.
This is one half of closing the CPU/CUDA pin skew: the two paths resolved to
different kernels commits, with the CUDA side behind.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
@github-actions

Copy link
Copy Markdown

Submodule staleness (non-blocking -- fastfields-lib#15)

submodulepinned committracksstatusbehind by
kernels1df9fd3fastfields/fastfields-kernels@mainup to date0

@balbasty
balbasty merged commit 83fa026 into mainAug 18, 2026
5 checks passed
@balbasty
balbasty deleted the claude/bump-kernels-cuda-pin-skew branch August 18, 2026 15:50
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@balbasty@claude