Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 20, 2026. It is now read-only.
deps: bump kernels pin to the diag_bending/diag_all corner cross-term fix - #49
Merged
Merged
Conversation
… fix Moves the kernels gitlink from 3e38c85 to 1df9fd3, bringing the CUDA path onto the same kernels commit the CPU path now uses. Picks up: * kernels#81 (1df9fd3) -- corrects the doubled fx1*fy0 / dropped fx0*fy1 corner term in the boundary-corrected diagonal of diag_bending (field 2d/3d, flow 2d/3d) and diag_all (flow 2d/3d). These are shared kernel headers, so the CUDA backend had the same defect. * kernels#79 (93a954b) -- restrict.h includes batch.h for index2sub. * kernels#78 (be7be08) -- drop the pointless virtual destructors from distance/mesh Node/BoundingSphere. This is one half of closing the CPU/CUDA pin skew: the two paths resolved to different kernels commits, with the CUDA side behind. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Submodule staleness (non-blocking -- fastfields-lib#15)
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the
kernelsgitlink from3e38c85to1df9fd3(currentfastfields-kernelsmain), putting the CUDA path on the same kernels commit the CPU path now uses. Gitlink-only — exactly one modified path.Why: a real, live pin skew
Tracing the actual gitlinks on
mainbefore this PR:The two backends resolved to different kernels commits, with CUDA three behind (
b09b284..be7be08= kernels #74, #76, #78). This repo's ownmainwas in a third state again (3e38c85), becausecuda-lib'simplpin is itself well behindcuda-implmain.This PR fixes the lower half of that chain. The
cuda-lib→cuda-implhalf follows in a separate PR.What it picks up here (
3e38c85→1df9fd3)be7be08distance/meshNode/BoundingSphere93a954brestrict.hincludesbatch.hforindex2sub1df9fd3fx1*fy0/ droppedfx0*fy1corner term in the boundary-corrected diagonal ofdiag_bending(field 2d/3d, flow 2d/3d) anddiag_all(flow 2d/3d). These are shared kernel headers, so the CUDA backend carried the identical defect.3e38c85is an ancestor of1df9fd3, so this is a fast-forward of the pin.Verification
Per this project's standard: the shared kernel math is validated by the CPU suite (the same headers compile for both backends), and the CUDA-only glue by nvcc compile+link, since there is no GPU in CI.
1df9fd3: 13/13 suites, 0 failures (test_reg_field18284 checks,test_reg_flow11415). Additionally, the new boundary-symmetry regression tests fail loudly against the pre-fix kernels (328 + 1696 failures) and pass against1df9fd3, so the corrected corner term is genuinely exercised.build-via-cuda-libjob, which runs the repo's real invocation (make -C . -j2 CXX=clang++ CXXFLAGS="-std=c++14 -O1"), preserving the-O1host-code setting andcuda-lib's splitMODULESlist.Pin hygiene
1df9fd3is the squash-merge commit that actually exists onfastfields-kernelsmain, not a pre-merge branch head. Verified it resolves before opening.🤖 Generated with Claude Code
https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Generated by Claude Code