Skip to content
This repository was archived by the owner on Aug 20, 2026. It is now read-only.

deps: bump impl pin to close the CPU/CUDA kernels skew - #47

Merged
balbasty merged 1 commit into
mainfrom
claude/bump-impl-close-pin-skew
Aug 18, 2026
Merged

deps: bump impl pin to close the CPU/CUDA kernels skew#47
balbasty merged 1 commit into
mainfrom
claude/bump-impl-close-pin-skew

Conversation

@balbasty

Copy link
Copy Markdown
Contributor

What

Moves the impl gitlink from a099a04 to 83fa026 (current fastfields-cuda-implmain). Gitlink-only — exactly one modified path.

The skew this closes

Traced by walking the actual gitlinks on main rather than trusting the submodule branch labels:

CPU path : lib -> cpu-lib dbd3274 -> cpu-impl 41d66b3 -> kernels be7be08
CUDA path: lib -> cuda-lib 6ae52bd -> cuda-impl a099a04 -> kernels b09b284

The two backends genuinely resolved to different kernels commits, with CUDA three behind (b09b284..be7be08):

kernels PRcommitwhat CUDA was missing
#7432951daheap over-read from the past-the-end FaceIterator — a memory-safety fix
#763e38c85make the host BVH/normal builders visible to nvcc's host pass — a CUDA-specific fix that the CUDA path itself lacked
#78be7be08drop the pointless virtual destructors from Node/BoundingSphere

A detail worth recording: cuda-impl's own main already pinned 3e38c85, so the stale link was this repo's impl pin, which was 11 commits behind cuda-implmain. That is why the CUDA path resolved to a third kernels commit that neither leaf repo pointed at directly.

What this pin picks up

Beyond closing the kernels skew (b09b2841df9fd3), advancing impl by 11 commits also brings in the mesh sdt launcher/dispatch work and cuda-impl#48 (the eight missing #pragma once guards).

a099a04 is an ancestor of 83fa026, so this is a fast-forward of the pin.

Resulting state

cuda-lib (this PR) -> cuda-impl 83fa026 -> kernels 1df9fd3
cpu-lib 1fb2b37 -> cpu-impl 5e2c78e -> kernels 1df9fd3

Both backends on one kernels commit. The matching fastfields-lib bump follows, after which all six repos agree.

Verification

Per this project's standard — shared kernel math via the CPU suite, CUDA-only glue via nvcc compile+link, since there is no GPU in CI:

  • Shared math: full CPU suite over kernels 1df9fd3 — 13/13 suites, 0 failures. The new boundary-symmetry regression tests (cpu-lib#89) fail with 328 + 1696 failures against the pre-fix kernels and pass at 1df9fd3.
  • CUDA compile+link: fastfields-cuda-impl's build-via-cuda-lib job already passed against exactly this cuda-impl content — twice, on #48 (5c68cf9) and #49 (83fa026), each a full make -C . -j2 CXX=clang++ CXXFLAGS="-std=c++14 -O1" run. This PR's own build job re-confirms it from this side.
  • -O1 and the split MODULES list (reg_field/reg_field_rls/reg_flow/reg_flow_rls separately, to cap ptxas memory) are untouched.

Pin hygiene

83fa026 is the squash-merge commit on cuda-implmain, not a pre-merge branch head — verified it resolves before opening.

🤖 Generated with Claude Code

https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z


Generated by Claude Code

Moves the impl gitlink from a099a04 to 83fa026 (current fastfields-cuda-impl
main), which brings the CUDA path onto kernels 1df9fd3 -- the same kernels
commit the CPU path already uses.
Before this, the two backends resolved to different kernels commits:
CPU path : cpu-lib -> cpu-impl -> kernels be7be08
CUDA path: cuda-lib -> cuda-impl -> kernels b09b284 (three behind)
The CUDA side was missing kernels#74 (heap over-read from the past-the-end
FaceIterator, a memory-safety fix), #76 (make the host BVH/normal builders
visible to nvcc's host pass -- a CUDA-specific fix the CUDA path itself
lacked) and #78 (drop the pointless virtual destructors).
The impl pin was also 11 commits behind cuda-impl main on its own, so this
additionally picks up the mesh sdt launcher work and the missing include
guards (cuda-impl#48).
After this and the matching fastfields-lib bump, all six repos agree on
kernels 1df9fd3.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
@github-actions

Copy link
Copy Markdown

Submodule staleness (non-blocking -- fastfields-lib#15)

submodulepinned committracksstatusbehind by
impl83fa026fastfields/fastfields-cuda-impl@mainup to date0

@balbasty
balbasty merged commit 2b2ad55 into mainAug 18, 2026
4 checks passed
@balbasty
balbasty deleted the claude/bump-impl-close-pin-skew branch August 18, 2026 16:32
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@balbasty@claude