Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 20, 2026. It is now read-only.
deps: bump impl pin to close the CPU/CUDA kernels skew - #47
Merged
Conversation
Moves the impl gitlink from a099a04 to 83fa026 (current fastfields-cuda-impl main), which brings the CUDA path onto kernels 1df9fd3 -- the same kernels commit the CPU path already uses. Before this, the two backends resolved to different kernels commits: CPU path : cpu-lib -> cpu-impl -> kernels be7be08 CUDA path: cuda-lib -> cuda-impl -> kernels b09b284 (three behind) The CUDA side was missing kernels#74 (heap over-read from the past-the-end FaceIterator, a memory-safety fix), #76 (make the host BVH/normal builders visible to nvcc's host pass -- a CUDA-specific fix the CUDA path itself lacked) and #78 (drop the pointless virtual destructors). The impl pin was also 11 commits behind cuda-impl main on its own, so this additionally picks up the mesh sdt launcher work and the missing include guards (cuda-impl#48). After this and the matching fastfields-lib bump, all six repos agree on kernels 1df9fd3. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Submodule staleness (non-blocking -- fastfields-lib#15)
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the
implgitlink froma099a04to83fa026(currentfastfields-cuda-implmain). Gitlink-only — exactly one modified path.The skew this closes
Traced by walking the actual gitlinks on
mainrather than trusting the submodule branch labels:The two backends genuinely resolved to different kernels commits, with CUDA three behind (
b09b284..be7be08):32951daFaceIterator— a memory-safety fix3e38c85be7be08Node/BoundingSphereA detail worth recording:
cuda-impl's ownmainalready pinned3e38c85, so the stale link was this repo'simplpin, which was 11 commits behindcuda-implmain. That is why the CUDA path resolved to a third kernels commit that neither leaf repo pointed at directly.What this pin picks up
Beyond closing the kernels skew (
b09b284→1df9fd3), advancingimplby 11 commits also brings in the meshsdtlauncher/dispatch work and cuda-impl#48 (the eight missing#pragma onceguards).a099a04is an ancestor of83fa026, so this is a fast-forward of the pin.Resulting state
Both backends on one kernels commit. The matching
fastfields-libbump follows, after which all six repos agree.Verification
Per this project's standard — shared kernel math via the CPU suite, CUDA-only glue via nvcc compile+link, since there is no GPU in CI:
1df9fd3— 13/13 suites, 0 failures. The new boundary-symmetry regression tests (cpu-lib#89) fail with 328 + 1696 failures against the pre-fix kernels and pass at1df9fd3.fastfields-cuda-impl'sbuild-via-cuda-libjob already passed against exactly thiscuda-implcontent — twice, on #48 (5c68cf9) and #49 (83fa026), each a fullmake -C . -j2 CXX=clang++ CXXFLAGS="-std=c++14 -O1"run. This PR's own build job re-confirms it from this side.-O1and the splitMODULESlist (reg_field/reg_field_rls/reg_flow/reg_flow_rlsseparately, to cap ptxas memory) are untouched.Pin hygiene
83fa026is the squash-merge commit oncuda-implmain, not a pre-merge branch head — verified it resolves before opening.🤖 Generated with Claude Code
https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Generated by Claude Code