Uh oh!
There was an error while loading. Please reload this page.
Depend on fastfields-helpers for enums and argument normalisation - #29
Merged
Conversation
The Spline/Bound enums and the as_spline/as_bound/anchor_scale_shift/ infer_ndim/resolve_out_spatial normalisers have moved out of fastfields-dlpack into the new, dependency-free fastfields-helpers package (fastfields/fastfields-helpers#1 in this migration). Switch this wrapper's imports accordingly. - pyproject.toml: add "fastfields-helpers==0.*" to dependencies, same bare-wildcard-no-floor convention as fastfields-dlpack. - fastfields/numpy/__init__.py: `from fastfields.dlpack import Bound, Spline` -> `from fastfields.helpers import Bound, Spline`. - fastfields/numpy/_util.py: as_bound/as_spline re-exports now come from fastfields.helpers; comment updated. - fastfields/numpy/_resample.py: anchor_scale_shift/infer_ndim/ resolve_out_spatial now come from fastfields.helpers; docstring reference updated. `import fastfields.dlpack as _ff` (the compiled resample/ restriction/spline_coeff bindings) is untouched. - tests/test_numpy.py: the two `from fastfields.dlpack import anchor_scale_shift` imports now read from fastfields.helpers. - CLAUDE.md: "Depends only on fastfields-dlpack + numpy" corrected to name both dependencies. Every `import fastfields.dlpack as _ff` (compiled-binding usage, in _dt.py/ _sym.py/_reg.py/_pushpull.py/_resample.py) is untouched -- only the pure- Python symbol imports moved. Verified against a real build: installed fastfields-helpers, reinstalled this tree (pip install .), confirmed `fastfields.numpy.Bound.__module__ == "fastfields.helpers"` and that `fastfields.dlpack.dt_euclidean` (an actual compiled binding) is still reachable and untouched, then ran the full suite out-of-tree: 170 passed (0 failed -- the pre-existing dt_mesh failures from this migration's baseline cleared after a clean dlpack reinstall, unrelated to this change's scope). ruff check + ruff format --check clean on every changed file. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switches this wrapper from
fastfields.dlpack's (now-removed) pure-Python helpers to the new, dependency-freefastfields-helperspackage.pyproject.toml: add"fastfields-helpers==0.*"to dependencies, same bare-wildcard-no-floor convention asfastfields-dlpack.fastfields/numpy/__init__.py:from fastfields.dlpack import Bound, Spline→from fastfields.helpers import Bound, Spline.fastfields/numpy/_util.py:as_bound/as_splinere-exports now come fromfastfields.helpers.fastfields/numpy/_resample.py:anchor_scale_shift/infer_ndim/resolve_out_spatialnow come fromfastfields.helpers; docstring cross-reference updated.tests/test_numpy.py: the twoanchor_scale_shiftimports now read fromfastfields.helpers.CLAUDE.md: "Depends only on fastfields-dlpack + numpy" corrected to name both.Every
import fastfields.dlpack as _ff(the compiled-binding usage in_dt.py/_sym.py/_reg.py/_pushpull.py/_resample.py) is untouched — only the pure-Python symbol imports moved.Verification
Against a real build: installed
fastfields-helpers, reinstalled this tree (pip install .), confirmedfastfields.numpy.Bound.__module__ == "fastfields.helpers"and thatfastfields.dlpack.dt_euclidean(an actual compiled binding) is still reachable and untouched. Ran the full suite out-of-tree: 170 passed (0 failed — the 11 pre-existingdt_meshfailures in this migration's baseline cleared after a cleanfastfields-dlpackreinstall, unrelated to this change's scope).ruff check+ruff format --checkclean.Sequencing
Companion to
fastfields-dlpack#31(removes the helpers this PR stops using) and the equivalent PRs on-torch/-cupy/fastfields, merged together to keep the broken-dependency window short.🤖 Generated with Claude Code
https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Generated by Claude Code