Skip to content

Fix typescript error due to schema type - #137

Merged
mcollina merged 1 commit into
fastify:masterfrom
klaseca:schema-type-fix
Nov 11, 2022
Merged

mcollina merged 1 commit into
fastify:masterfrom
klaseca:schema-type-fix

Conversation

@klaseca

@klaseca klaseca commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Checklist

Description:

Schema type was changed in pull request #134. One of the available schema types was ObjectSchema from fluent-json-schema package. Since fluent-json-schema is a development dependency, we cannot use it for production code

Now, if we do not install fluent-json-schema manually, we will get the wrong type for schema, or an error if we use "skipLibCheck": false in the typescript config file

After this fix, we can still use fluent-json-schema, but we will not get wrong type or error if this package is missing

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants