') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix: fix spelling and grammar issues found in the codebase by jsoref by anthony-gomez-fastly · Pull Request #1768 · fastly/cli · GitHub
Skip to content

fix: fix spelling and grammar issues found in the codebase by jsoref - #1768

Merged
anthony-gomez-fastly merged 6 commits into
mainfrom
spelling-and-grammar
Apr 28, 2026
Merged

fix: fix spelling and grammar issues found in the codebase by jsoref#1768
anthony-gomez-fastly merged 6 commits into
mainfrom
spelling-and-grammar

Conversation

@anthony-gomez-fastly

@anthony-gomez-fastlyanthony-gomez-fastly commented Apr 28, 2026

Copy link
Copy Markdown
Member

Change summary

Fix a few of the errors found in this PR

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

rcaril
rcaril reviewed Apr 28, 2026
View reviewed changes
Comment threadpkg/commands/ngwaf/workspace/update.go
rcaril
rcaril previously requested changes Apr 28, 2026
View reviewed changes

@rcarilrcaril left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern around ipAnonimization → IPAnonymization - otherwise looks good!

jsoref
jsoref reviewed Apr 28, 2026
View reviewed changes
Comment threadpkg/commands/objectstorage/accesskeys/accesskeys_test.go Outdated
@anthony-gomez-fastly
anthony-gomez-fastly marked this pull request as ready for review April 28, 2026 14:32
@anthony-gomez-fastly
anthony-gomez-fastly requested a review from a team as a code ownerApril 28, 2026 14:32
philippschulte
philippschulte approved these changes Apr 28, 2026
View reviewed changes

@philippschultephilippschulte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

rcaril
rcaril approved these changes Apr 28, 2026
View reviewed changes

@rcarilrcaril left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

rcaril
rcaril reviewed Apr 28, 2026
View reviewed changes
Comment threadCHANGELOG.md Outdated
@anthony-gomez-fastly@rcaril
Update CHANGELOG.md
459d308
Co-authored-by: Richard Carillo <77027245+rcaril@users.noreply.github.com>
@anthony-gomez-fastly
anthony-gomez-fastly enabled auto-merge (squash) April 28, 2026 14:51
@anthony-gomez-fastly
anthony-gomez-fastly merged commit 9993aeb into mainApr 28, 2026
9 checks passed
@anthony-gomez-fastly
anthony-gomez-fastly deleted the spelling-and-grammar branch April 28, 2026 15:07
@BrewTestBotBrewTestBot mentioned this pull request May 8, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpflemingkpflemingkpfleming left review comments
@rcarilrcarilrcaril approved these changes
@philippschultephilippschultephilippschulte approved these changes
@jsorefjsorefAwaiting requested review from jsoref

Assignees

No one assigned

Labels

breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anthony-gomez-fastly@kpfleming@jsoref@philippschulte@rcaril