') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [CDTOOL-1317] Add Support for the `max_use` and `max_lifetime` backend parameters by rcaril · Pull Request #1779 · fastly/cli · GitHub
Skip to content

[CDTOOL-1317] Add Support for the max_use and max_lifetime backend parameters - #1779

Merged
rcaril merged 4 commits into
mainfrom
CDTOOL-1317-support-for-backend-connection-reuse-limits
May 7, 2026
Merged

[CDTOOL-1317] Add Support for the max_use and max_lifetime backend parameters#1779
rcaril merged 4 commits into
mainfrom
CDTOOL-1317-support-for-backend-connection-reuse-limits

Conversation

@rcaril

@rcarilrcaril commented May 7, 2026

Copy link
Copy Markdown
Member

Change summary

This PR adds new --max-use and --max-lifetime parameters to fastly service backend create and fastly service backend update, which can be used to specify the max_use and max_lifetime backend fields.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
make test TEST_ARGS="-run TestBackendCreate ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.204s
make test TEST_ARGS="-run TestBackendList ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.130s
make test TEST_ARGS="-run TestBackendDescribe ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.071s
make test TEST_ARGS="-run TestBackendUpdate ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.133s
make test TEST_ARGS="-run TestBackendDelete ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.065s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@rcaril
rcaril marked this pull request as ready for review May 7, 2026 13:58
@rcaril
rcaril requested a review from a team as a code ownerMay 7, 2026 13:58
@rcaril
rcaril requested a review from jedisct1May 7, 2026 13:58
@rcaril
rcaril requested a review from ulyssaMay 7, 2026 13:59
Comment threadpkg/commands/service/backend/create.go Outdated
@rcaril
rcaril requested a review from philippschulteMay 7, 2026 14:00

@philippschultephilippschulte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me overall. One small consistency nitt: CreateCommand.MaxUse and CreateCommand.MaxLifetime should probably be unexported as maxUse and maxLifetime, matching nearby fields like maxConn, firstByteTimeout, and healthCheck. They do not appear to need to be exported. The update command already uses exported fields consistently, so no issue there.

Comment threadpkg/commands/service/backend/create.go Outdated
@rcaril
rcaril requested a review from philippschulteMay 7, 2026 14:33

@philippschultephilippschulte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rcaril
rcaril merged commit c7f3337 into mainMay 7, 2026
13 checks passed
@rcaril
rcaril deleted the CDTOOL-1317-support-for-backend-connection-reuse-limits branch May 7, 2026 14:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rcaril@philippschulte@ulyssa