You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds new --max-use and --max-lifetime parameters to fastly service backend create and fastly service backend update, which can be used to specify the max_use and max_lifetime backend fields.
All Submissions:
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
Does your submission pass tests?
make test TEST_ARGS="-run TestBackendCreate ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.204s
make test TEST_ARGS="-run TestBackendList ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.130s
make test TEST_ARGS="-run TestBackendDescribe ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.071s
make test TEST_ARGS="-run TestBackendUpdate ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.133s
make test TEST_ARGS="-run TestBackendDelete ./pkg/commands/service/backend"
ok github.com/fastly/cli/pkg/commands/service/backend 1.065s
Changes to Core Features:
Have you written new tests for your core changes, as applicable?
Have you successfully run tests with your changes locally?
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me overall. One small consistency nitt: CreateCommand.MaxUse and CreateCommand.MaxLifetime should probably be unexported as maxUse and maxLifetime, matching nearby fields like maxConn, firstByteTimeout, and healthCheck. They do not appear to need to be exported. The update command already uses exported fields consistently, so no issue there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
This PR adds new
--max-useand--max-lifetimeparameters tofastly service backend createandfastly service backend update, which can be used to specify themax_useandmax_lifetimebackend fields.All Submissions:
New Feature Submissions:
Changes to Core Features: