') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Send deprecation warnings to stderr instead of stdout by anthony-gomez-fastly · Pull Request #1782 · fastly/cli · GitHub
Skip to content

Send deprecation warnings to stderr instead of stdout - #1782

Merged
anthony-gomez-fastly merged 3 commits into
mainfrom
chore-change-deprecation-warnings
May 8, 2026
Merged

Send deprecation warnings to stderr instead of stdout#1782
anthony-gomez-fastly merged 3 commits into
mainfrom
chore-change-deprecation-warnings

Conversation

@anthony-gomez-fastly

@anthony-gomez-fastlyanthony-gomez-fastly commented May 8, 2026

Copy link
Copy Markdown
Member

Change summary

Previously, the text.Deprecated() function wrote warnings to stdout (via the provided io.Writer parameter), which mixed warnings with actual command output. This made it difficult for users to redirect output cleanly or for tools to parse stdout.

Changes:

  • Modified text.Deprecated() to write directly to os.Stderr
  • Added TestDeprecated() to verify stderr output
  • Updated test expectations to not check for deprecation messages in stdout

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

No more deprecation warnings in stdOut

@anthony-gomez-fastly
anthony-gomez-fastly requested a review from a team as a code ownerMay 8, 2026 13:57
anthony-gomez-fastly
anthony-gomez-fastly commented May 8, 2026
View reviewed changes
Comment threadpkg/text/text.go
@anthony-gomez-fastly
fix: send deprecation warnings to stderr instead of stdout
856fba1
Previously, the text.Deprecated() function wrote warnings to stdout (via the provided io.Writer parameter), which mixed warnings with actual command output. This made it difficult for users to redirect output cleanly or for tools to parse stdout.
Changes:
- Modified text.Deprecated() to write directly to os.Stderr
- Added TestDeprecated() to verify stderr output
- Updated test expectations to not check for deprecation messages in stdout
@anthony-gomez-fastly
anthony-gomez-fastlyforce-pushed the chore-change-deprecation-warnings branch from b14a38b to 856fba1CompareMay 8, 2026 14:04
@anthony-gomez-fastly
anthony-gomez-fastly merged commit bacc844 into mainMay 8, 2026
13 checks passed
@anthony-gomez-fastly
anthony-gomez-fastly deleted the chore-change-deprecation-warnings branch May 8, 2026 17:07
@BrewTestBotBrewTestBot mentioned this pull request May 13, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpflemingkpflemingkpfleming approved these changes
@jedisct1jedisct1Awaiting requested review from jedisct1jedisct1 is a code owner automatically assigned from fastly/developer-tools

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anthony-gomez-fastly@kpfleming