') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [CDTOOL-1332] Honor --profile when resolving the API token by jedisct1 · Pull Request #1792 · fastly/cli · GitHub
Skip to content

[CDTOOL-1332] Honor --profile when resolving the API token - #1792

Merged
jedisct1 merged 3 commits into
mainfrom
fdenis/profilo
May 13, 2026
Merged

[CDTOOL-1332] Honor --profile when resolving the API token#1792
jedisct1 merged 3 commits into
mainfrom
fdenis/profilo

Conversation

@jedisct1

@jedisct1jedisct1 commented May 12, 2026

Copy link
Copy Markdown
Contributor

Change summary

The deprecated --profile/-o flag was parsed into Data.Flags.Profile but never consulted during token lookup, so commands silently ran against the default token instead of the profile the user named on the command line.

Token resolution now consults --profile after --token and before FASTLY_API_TOKEN.

An unknown profile name is treated as a hard error rather than a silent fallback, so the wrong token can no longer slip through under --quiet.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

Users who pass --profile <name> (or -o <name>) will now have the command run against the named profile's token, as the help text already promised.

Users who pass an unknown profile name will see a clear remediation error instead of the command silently using the wrong token.

Are there any considerations that need to be addressed for release?

No breaking changes to documented behavior.

Scripts that relied on --profile <bogus> silently being ignored will now exit with an error.

@jedisct1
[CDTOOL-1332] Honor --profile when resolving the API token
803c7b1
The deprecated `--profile` flag (`-o`) was silently ignored during
token lookup, so commands ran against the default token regardless
of the profile the user named on the command line.
Token resolution now consults `--profile` after `--token` and
before the environment variable, the manifest profile, and the
default token.
An unknown profile name is a hard error rather than a silent
fallback, so the wrong token can no longer slip through under
`--quiet`.
@jedisct1
jedisct1 requested a review from a team as a code ownerMay 12, 2026 11:18
anthony-gomez-fastly
anthony-gomez-fastly approved these changes May 13, 2026
View reviewed changes

@anthony-gomez-fastlyanthony-gomez-fastly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedisct1
jedisct1 enabled auto-merge (squash) May 13, 2026 14:57
philippschulte
philippschulte approved these changes May 13, 2026
View reviewed changes

@philippschultephilippschulte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jedisct1
jedisct1 merged commit fcb79bb into mainMay 13, 2026
13 checks passed
@jedisct1
jedisct1 deleted the fdenis/profilo branch May 13, 2026 15:21
@rcarilrcaril mentioned this pull request May 13, 2026
Merged
3 tasks
@BrewTestBotBrewTestBot mentioned this pull request May 13, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philippschultephilippschultephilippschulte approved these changes
@anthony-gomez-fastlyanthony-gomez-fastlyanthony-gomez-fastly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jedisct1@philippschulte@anthony-gomez-fastly