You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add --autoclone support to fastly service version stage.
The command already recommends --autoclone when the selected version is active or locked, but previously rejected the flag as invalid. This change aligns stage with service version activate by cloning the selected version before staging it.
Tests cover staging clones of both active and locked versions.
All Submissions:
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Changes to Core Features:
Have you written new tests for your core changes, as applicable?
Have you successfully run tests with your changes locally?
User Impact
The recommended suggestion is finally supported.
Are there any considerations that need to be addressed for release?
The reason will be displayed to describe this comment to others. Learn more.
The formatting changes in CHANGELOG.md should be in a separate PR if they are valuable enough to do that. I'm not sure we need to change the unordered list markers and indentation for a CHANGELOG entry which was added many months ago.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Add
--autoclonesupport tofastly service version stage.The command already recommends
--autoclonewhen the selected version is active or locked, but previously rejected the flag as invalid. This change alignsstagewithservice version activateby cloning the selected version before staging it.Tests cover staging clones of both active and locked versions.
All Submissions:
Changes to Core Features:
User Impact
The recommended suggestion is finally supported.
Are there any considerations that need to be addressed for release?
No.