') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [CDTOOL-1704] Allow Logging `placement` Flag to be reset back to `null` & Bump `fastly/go-fastly` to v17 by rcaril · Pull Request #1855 · fastly/cli · GitHub
Skip to content

[CDTOOL-1704] Allow Logging placement Flag to be reset back to null & Bump fastly/go-fastly to v17 - #1855

Merged
rcaril merged 5 commits into
mainfrom
rcaril/allow-logging-placement-to-be-nullable
Jul 28, 2026
Merged

[CDTOOL-1704] Allow Logging placement Flag to be reset back to null & Bump fastly/go-fastly to v17#1855
rcaril merged 5 commits into
mainfrom
rcaril/allow-logging-placement-to-be-nullable

Conversation

@rcaril

@rcarilrcaril commented Jul 28, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Change summary

This PR updates the CLI Logging commands to be compatible with the go-fastly v17.0.0 release:

  • All logging commands now support reset the placement attribute back to null when the value was previously set otherwise [d15db05]
  • fastly/go-fastly bumped from v16.0.1 to v17.0.0 [f063b54]

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

rcariland others added 4 commits July 28, 2026 15:24
@rcaril
fix(logging): ensure that the placement flag can be reset to null v…
d15db05
…ia `""`
Leverages the changes in `go-fastly` v17 to use the nullable helper to allow `placement` to actually be set to `null` on the API side.
@rcaril
(dep): bumped go-fastly to v17
f063b54
@rcaril
Merge branch 'main' into rcaril/allow-logging-placement-to-be-nullable
aa1eba4
@rcaril
updated changelog
ae41102
@rcaril

rcaril commented Jul 28, 2026

Copy link
Copy Markdown
MemberAuthor

Validated locally that setting --placement "" updates placement on the API side to null as well as sending none still sets the value to none on the API side.

@rcaril
rcaril marked this pull request as ready for review July 28, 2026 19:44
@rcaril
rcaril requested a review from a team as a code ownerJuly 28, 2026 19:44
@rcarilrcaril changed the title Allow Logging placement Flag to be reset back to null & Bump fastly/go-fastly to v17[CDTOOL-1704] Allow Logging placement Flag to be reset back to null & Bump fastly/go-fastly to v17Jul 28, 2026
rcaril
rcaril commented Jul 28, 2026
View reviewed changes
Comment threadpkg/commands/service/logging/sumologic/update.go
rcaril
rcaril commented Jul 28, 2026
View reviewed changes
Comment threadpkg/commands/service/logging/azureblob/azureblob_test.go
@rcaril
rcaril merged commit f853e51 into mainJul 28, 2026
14 checks passed
@rcaril
rcaril deleted the rcaril/allow-logging-placement-to-be-nullable branch July 28, 2026 20:10
@BrewTestBotBrewTestBot mentioned this pull request Aug 4, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-gomez-fastlyanthony-gomez-fastlyanthony-gomez-fastly approved these changes
@jedisct1jedisct1Awaiting requested review from jedisct1jedisct1 is a code owner automatically assigned from fastly/developer-tools

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rcaril@anthony-gomez-fastly