Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should really avoid having users do
pip installsteps at all in favor of having dependencies be modeled in pyproject.toml for relevant examples and pushinguv; I glossed over thepipinstructions on first read and think it is detrimental given our prior decision to makeuvthe paved path and the greater importance of having an isolated virtualenv or similar for targeting the wasm environment.The manual steps listed are likely to go away in favor of templates for a better getting-started experience, but even then I think as-is, this is probably pushing users down a suboptimal path. Even though there's pretty good flexibility in terms of how things can be done, I think it may be better to document as if use of
uvis what is to be used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine. I wrote it in terms of pip because I have 20 years of acclimation to putting (and seeing) it in install instructions, and I expected most customers to create a venv implicitly (and those who wouldn't to just get confused by one). But I like your writeup, especially its explanation of each step. We will have to be sure and hold people's hands w.r.t. uv throughout all our docs (e.g. always saying
uv run fastly-compute-py), as pip is still the modal path in the community and will turn up in general "what the heck's broken?" searches.