Update WIT definitions, add tests & CI infra by posborne · Pull Request #7 · fastly/compute-sdk-python

posborne · 2025-09-02T22:14:16Z

No description provided.

erikrose

Hooray! Looking great! Just a few notes.

Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

We key off extra output included when running the server in verbose mode to know when viceroy is ready.

A lot of the extra stuff we had for logging exceptions and such aren't required any longer as the WASI bits are working as they ought to, so we can gut all of that. Also, fixed vcpu_time which does return an integer number of milliseconds in the viceroy impl, so assert on that.

erikrose

So nice to get rid of that 10s sleep. :-D

We are using these helpers internally and it probably makes sense to have some sort of easier setup for end users. This is the first stab at making that available. Along with those changes, I also incorporated a few chanes to reduce the code for viceroy setup using asyncio (still a bit verbose but is working) and a few other small tweaks. The plugin to get Viceroy output on failure is a hack and we may scrap or have to revisit other approaches (e.g. just immediately outputting to host stdout/stderr) but it is functional and may be a reasonable approach (if ugly in implementation).

We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

erikrose

Looking good. I just want to conclude the threads on mark.integration and the lock that I was curious about.

erikrose · 2025-09-05T14:59:56Z

+ Returns:
+ requests.Response: The HTTP response
+ """
+ timeout = kwargs.pop("timeout", self.REQUEST_TIMEOUT)


It'd be nice to lift timeout up into the function signature. Not a blocker. More a note to my future self.

Deferring this for now.

erikrose · 2025-09-05T17:45:51Z

+
+```bash
+make test # Build and run tests
+pytest -m integration # Run integration tests only


One more spot

erikrose

Thanks again, Paul!

posborne · 2025-09-02T22:14:16Z

No description provided.

erikrose

Hooray! Looking great! Just a few notes.

Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

We key off extra output included when running the server in verbose mode to know when viceroy is ready.

A lot of the extra stuff we had for logging exceptions and such aren't required any longer as the WASI bits are working as they ought to, so we can gut all of that. Also, fixed vcpu_time which does return an integer number of milliseconds in the viceroy impl, so assert on that.

erikrose

So nice to get rid of that 10s sleep. :-D

We are using these helpers internally and it probably makes sense to have some sort of easier setup for end users. This is the first stab at making that available. Along with those changes, I also incorporated a few chanes to reduce the code for viceroy setup using asyncio (still a bit verbose but is working) and a few other small tweaks. The plugin to get Viceroy output on failure is a hack and we may scrap or have to revisit other approaches (e.g. just immediately outputting to host stdout/stderr) but it is functional and may be a reasonable approach (if ugly in implementation).

We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

erikrose

Looking good. I just want to conclude the threads on mark.integration and the lock that I was curious about.

erikrose · 2025-09-05T14:59:56Z

+ Returns:
+ requests.Response: The HTTP response
+ """
+ timeout = kwargs.pop("timeout", self.REQUEST_TIMEOUT)


It'd be nice to lift timeout up into the function signature. Not a blocker. More a note to my future self.

Deferring this for now.

erikrose · 2025-09-05T17:45:51Z

+
+```bash
+make test # Build and run tests
+pytest -m integration # Run integration tests only


One more spot

erikrose

Thanks again, Paul!

posborne · 2025-09-02T22:14:16Z

No description provided.

erikrose

Hooray! Looking great! Just a few notes.

Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

We key off extra output included when running the server in verbose mode to know when viceroy is ready.

A lot of the extra stuff we had for logging exceptions and such aren't required any longer as the WASI bits are working as they ought to, so we can gut all of that. Also, fixed vcpu_time which does return an integer number of milliseconds in the viceroy impl, so assert on that.

erikrose

So nice to get rid of that 10s sleep. :-D

We are using these helpers internally and it probably makes sense to have some sort of easier setup for end users. This is the first stab at making that available. Along with those changes, I also incorporated a few chanes to reduce the code for viceroy setup using asyncio (still a bit verbose but is working) and a few other small tweaks. The plugin to get Viceroy output on failure is a hack and we may scrap or have to revisit other approaches (e.g. just immediately outputting to host stdout/stderr) but it is functional and may be a reasonable approach (if ugly in implementation).

We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

erikrose

Looking good. I just want to conclude the threads on mark.integration and the lock that I was curious about.

erikrose · 2025-09-05T14:59:56Z

+ Returns:
+ requests.Response: The HTTP response
+ """
+ timeout = kwargs.pop("timeout", self.REQUEST_TIMEOUT)


It'd be nice to lift timeout up into the function signature. Not a blocker. More a note to my future self.

Deferring this for now.

erikrose · 2025-09-05T17:45:51Z

+
+```bash
+make test # Build and run tests
+pytest -m integration # Run integration tests only


One more spot

erikrose

Thanks again, Paul!

posborne · 2025-09-02T22:14:16Z

No description provided.

erikrose

Hooray! Looking great! Just a few notes.

Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

We key off extra output included when running the server in verbose mode to know when viceroy is ready.

A lot of the extra stuff we had for logging exceptions and such aren't required any longer as the WASI bits are working as they ought to, so we can gut all of that. Also, fixed vcpu_time which does return an integer number of milliseconds in the viceroy impl, so assert on that.

erikrose

So nice to get rid of that 10s sleep. :-D

We are using these helpers internally and it probably makes sense to have some sort of easier setup for end users. This is the first stab at making that available. Along with those changes, I also incorporated a few chanes to reduce the code for viceroy setup using asyncio (still a bit verbose but is working) and a few other small tweaks. The plugin to get Viceroy output on failure is a hack and we may scrap or have to revisit other approaches (e.g. just immediately outputting to host stdout/stderr) but it is functional and may be a reasonable approach (if ugly in implementation).

We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

erikrose

Looking good. I just want to conclude the threads on mark.integration and the lock that I was curious about.

erikrose · 2025-09-05T14:59:56Z

+ Returns:
+ requests.Response: The HTTP response
+ """
+ timeout = kwargs.pop("timeout", self.REQUEST_TIMEOUT)


It'd be nice to lift timeout up into the function signature. Not a blocker. More a note to my future self.

Deferring this for now.

erikrose · 2025-09-05T17:45:51Z

+
+```bash
+make test # Build and run tests
+pytest -m integration # Run integration tests only


One more spot

erikrose

Thanks again, Paul!

posborne · 2025-09-02T22:14:16Z

No description provided.

erikrose

Hooray! Looking great! Just a few notes.

Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

We key off extra output included when running the server in verbose mode to know when viceroy is ready.

A lot of the extra stuff we had for logging exceptions and such aren't required any longer as the WASI bits are working as they ought to, so we can gut all of that. Also, fixed vcpu_time which does return an integer number of milliseconds in the viceroy impl, so assert on that.

erikrose

So nice to get rid of that 10s sleep. :-D

We are using these helpers internally and it probably makes sense to have some sort of easier setup for end users. This is the first stab at making that available. Along with those changes, I also incorporated a few chanes to reduce the code for viceroy setup using asyncio (still a bit verbose but is working) and a few other small tweaks. The plugin to get Viceroy output on failure is a hack and we may scrap or have to revisit other approaches (e.g. just immediately outputting to host stdout/stderr) but it is functional and may be a reasonable approach (if ugly in implementation).

We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

erikrose

Looking good. I just want to conclude the threads on mark.integration and the lock that I was curious about.

erikrose · 2025-09-05T14:59:56Z

+ Returns:
+ requests.Response: The HTTP response
+ """
+ timeout = kwargs.pop("timeout", self.REQUEST_TIMEOUT)


It'd be nice to lift timeout up into the function signature. Not a blocker. More a note to my future self.

Deferring this for now.

erikrose · 2025-09-05T17:45:51Z

+
+```bash
+make test # Build and run tests
+pytest -m integration # Run integration tests only


One more spot

erikrose

Thanks again, Paul!

posborne · 2025-09-02T22:14:16Z

No description provided.

erikrose

Hooray! Looking great! Just a few notes.

Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

We key off extra output included when running the server in verbose mode to know when viceroy is ready.

A lot of the extra stuff we had for logging exceptions and such aren't required any longer as the WASI bits are working as they ought to, so we can gut all of that. Also, fixed vcpu_time which does return an integer number of milliseconds in the viceroy impl, so assert on that.

erikrose

So nice to get rid of that 10s sleep. :-D

We are using these helpers internally and it probably makes sense to have some sort of easier setup for end users. This is the first stab at making that available. Along with those changes, I also incorporated a few chanes to reduce the code for viceroy setup using asyncio (still a bit verbose but is working) and a few other small tweaks. The plugin to get Viceroy output on failure is a hack and we may scrap or have to revisit other approaches (e.g. just immediately outputting to host stdout/stderr) but it is functional and may be a reasonable approach (if ugly in implementation).

We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

erikrose

Looking good. I just want to conclude the threads on mark.integration and the lock that I was curious about.

erikrose · 2025-09-05T14:59:56Z

+ Returns:
+ requests.Response: The HTTP response
+ """
+ timeout = kwargs.pop("timeout", self.REQUEST_TIMEOUT)


It'd be nice to lift timeout up into the function signature. Not a blocker. More a note to my future self.

Deferring this for now.

erikrose · 2025-09-05T17:45:51Z

+
+```bash
+make test # Build and run tests
+pytest -m integration # Run integration tests only


One more spot

erikrose

Thanks again, Paul!

posborne · 2025-09-02T22:14:16Z

No description provided.

erikrose

Hooray! Looking great! Just a few notes.

Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

We key off extra output included when running the server in verbose mode to know when viceroy is ready.

A lot of the extra stuff we had for logging exceptions and such aren't required any longer as the WASI bits are working as they ought to, so we can gut all of that. Also, fixed vcpu_time which does return an integer number of milliseconds in the viceroy impl, so assert on that.

erikrose

So nice to get rid of that 10s sleep. :-D

We are using these helpers internally and it probably makes sense to have some sort of easier setup for end users. This is the first stab at making that available. Along with those changes, I also incorporated a few chanes to reduce the code for viceroy setup using asyncio (still a bit verbose but is working) and a few other small tweaks. The plugin to get Viceroy output on failure is a hack and we may scrap or have to revisit other approaches (e.g. just immediately outputting to host stdout/stderr) but it is functional and may be a reasonable approach (if ugly in implementation).

We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

erikrose

Looking good. I just want to conclude the threads on mark.integration and the lock that I was curious about.

erikrose · 2025-09-05T14:59:56Z

+ Returns:
+ requests.Response: The HTTP response
+ """
+ timeout = kwargs.pop("timeout", self.REQUEST_TIMEOUT)


It'd be nice to lift timeout up into the function signature. Not a blocker. More a note to my future self.

Deferring this for now.

erikrose · 2025-09-05T17:45:51Z

+
+```bash
+make test # Build and run tests
+pytest -m integration # Run integration tests only


One more spot

erikrose

Thanks again, Paul!

posborne · 2025-09-02T22:14:16Z

No description provided.

erikrose

Hooray! Looking great! Just a few notes.

Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

We key off extra output included when running the server in verbose mode to know when viceroy is ready.

A lot of the extra stuff we had for logging exceptions and such aren't required any longer as the WASI bits are working as they ought to, so we can gut all of that. Also, fixed vcpu_time which does return an integer number of milliseconds in the viceroy impl, so assert on that.

erikrose

So nice to get rid of that 10s sleep. :-D

We are using these helpers internally and it probably makes sense to have some sort of easier setup for end users. This is the first stab at making that available. Along with those changes, I also incorporated a few chanes to reduce the code for viceroy setup using asyncio (still a bit verbose but is working) and a few other small tweaks. The plugin to get Viceroy output on failure is a hack and we may scrap or have to revisit other approaches (e.g. just immediately outputting to host stdout/stderr) but it is functional and may be a reasonable approach (if ugly in implementation).

We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

erikrose

Looking good. I just want to conclude the threads on mark.integration and the lock that I was curious about.

erikrose · 2025-09-05T14:59:56Z

+ Returns:
+ requests.Response: The HTTP response
+ """
+ timeout = kwargs.pop("timeout", self.REQUEST_TIMEOUT)


It'd be nice to lift timeout up into the function signature. Not a blocker. More a note to my future self.

Deferring this for now.

erikrose · 2025-09-05T17:45:51Z

+
+```bash
+make test # Build and run tests
+pytest -m integration # Run integration tests only


One more spot

erikrose

Thanks again, Paul!

posborne requested a review from erikrose September 2, 2025 22:14

posborne force-pushed the posborne/update-wit-ci-and-tests branch 2 times, most recently from 30919ef to a279d39Compare September 2, 2025 22:41

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment thread.github/workflows/python-ci.yml Outdated
Comment thread.github/workflows/python-ci.yml
Comment threadapp.py Outdated
Comment threadapp.py
Comment threadpyproject.toml Outdated
Comment threadtests/test_integration.py Outdated

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 29f294e to c239fccCompare September 3, 2025 17:28

posborne added 7 commits September 3, 2025 18:13

Update WIT definitions, add tests & CI infra
1a38384

Constrain dependency versions more tightly
08afbdf

tests: avoid using the default viceroy port
985b293
Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

tests: removed fixed blocking time for viceroy startup
090ca4f
We key off extra output included when running the server in verbose mode to know when viceroy is ready.

Fix lint errors and add ruff --fix helper
a234982

Use sys.stderror directly for wsgi.errors
ef3406b

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 8165059 to ef3406bCompare September 3, 2025 18:13

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated

posborne commented Sep 3, 2025
View reviewed changes

Comment threadfastly_compute/testing.py Outdated

testing: fix output capturing & simplify
2bc81e9

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 5c8041a to 2bc81e9Compare September 4, 2025 19:04

testing: remove need to pass viceroy_server around
7751eeb
We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

This was referenced Sep 4, 2025
fd_write crash on send_downstream() when updating to latest Viceroy #5
Closed
Make writing to stdout and stderr not crash #2
Closed

erikrose reviewed Sep 5, 2025
View reviewed changes

posborne added 2 commits September 5, 2025 16:26

testing: drop integration test marker
040e3c1

docs: fix typo and small updates
dbd2cf3

erikrose reviewed Sep 5, 2025
View reviewed changes

erikrose approved these changes Sep 5, 2025
View reviewed changes

docs: remove references to "integration" tests in a few more places
7ff2a5a

posborne merged commit 7f5856a into mainSep 5, 2025
3 checks passed

posborne deleted the posborne/update-wit-ci-and-tests branch September 5, 2025 19:45

erikrose mentioned this pull request Sep 12, 2025
Flask support! #8
Merged

posborne requested a review from erikrose September 2, 2025 22:14

posborne force-pushed the posborne/update-wit-ci-and-tests branch 2 times, most recently from 30919ef to a279d39Compare September 2, 2025 22:41

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment thread.github/workflows/python-ci.yml Outdated
Comment thread.github/workflows/python-ci.yml
Comment threadapp.py Outdated
Comment threadapp.py
Comment threadpyproject.toml Outdated
Comment threadtests/test_integration.py Outdated

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 29f294e to c239fccCompare September 3, 2025 17:28

posborne added 7 commits September 3, 2025 18:13

Update WIT definitions, add tests & CI infra
1a38384

Constrain dependency versions more tightly
08afbdf

tests: avoid using the default viceroy port
985b293
Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

tests: removed fixed blocking time for viceroy startup
090ca4f
We key off extra output included when running the server in verbose mode to know when viceroy is ready.

Fix lint errors and add ruff --fix helper
a234982

Use sys.stderror directly for wsgi.errors
ef3406b

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 8165059 to ef3406bCompare September 3, 2025 18:13

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated

posborne commented Sep 3, 2025
View reviewed changes

Comment threadfastly_compute/testing.py Outdated

testing: fix output capturing & simplify
2bc81e9

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 5c8041a to 2bc81e9Compare September 4, 2025 19:04

testing: remove need to pass viceroy_server around
7751eeb
We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

This was referenced Sep 4, 2025
fd_write crash on send_downstream() when updating to latest Viceroy #5
Closed
Make writing to stdout and stderr not crash #2
Closed

erikrose reviewed Sep 5, 2025
View reviewed changes

posborne added 2 commits September 5, 2025 16:26

testing: drop integration test marker
040e3c1

docs: fix typo and small updates
dbd2cf3

erikrose reviewed Sep 5, 2025
View reviewed changes

erikrose approved these changes Sep 5, 2025
View reviewed changes

docs: remove references to "integration" tests in a few more places
7ff2a5a

posborne merged commit 7f5856a into mainSep 5, 2025
3 checks passed

posborne deleted the posborne/update-wit-ci-and-tests branch September 5, 2025 19:45

erikrose mentioned this pull request Sep 12, 2025
Flask support! #8
Merged

posborne requested a review from erikrose September 2, 2025 22:14

posborne force-pushed the posborne/update-wit-ci-and-tests branch 2 times, most recently from 30919ef to a279d39Compare September 2, 2025 22:41

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment thread.github/workflows/python-ci.yml Outdated
Comment thread.github/workflows/python-ci.yml
Comment threadapp.py Outdated
Comment threadapp.py
Comment threadpyproject.toml Outdated
Comment threadtests/test_integration.py Outdated

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 29f294e to c239fccCompare September 3, 2025 17:28

posborne added 7 commits September 3, 2025 18:13

Update WIT definitions, add tests & CI infra
1a38384

Constrain dependency versions more tightly
08afbdf

tests: avoid using the default viceroy port
985b293
Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

tests: removed fixed blocking time for viceroy startup
090ca4f
We key off extra output included when running the server in verbose mode to know when viceroy is ready.

Fix lint errors and add ruff --fix helper
a234982

Use sys.stderror directly for wsgi.errors
ef3406b

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 8165059 to ef3406bCompare September 3, 2025 18:13

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated

posborne commented Sep 3, 2025
View reviewed changes

Comment threadfastly_compute/testing.py Outdated

testing: fix output capturing & simplify
2bc81e9

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 5c8041a to 2bc81e9Compare September 4, 2025 19:04

testing: remove need to pass viceroy_server around
7751eeb
We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

This was referenced Sep 4, 2025
fd_write crash on send_downstream() when updating to latest Viceroy #5
Closed
Make writing to stdout and stderr not crash #2
Closed

erikrose reviewed Sep 5, 2025
View reviewed changes

posborne added 2 commits September 5, 2025 16:26

testing: drop integration test marker
040e3c1

docs: fix typo and small updates
dbd2cf3

erikrose reviewed Sep 5, 2025
View reviewed changes

erikrose approved these changes Sep 5, 2025
View reviewed changes

docs: remove references to "integration" tests in a few more places
7ff2a5a

posborne merged commit 7f5856a into mainSep 5, 2025
3 checks passed

posborne deleted the posborne/update-wit-ci-and-tests branch September 5, 2025 19:45

erikrose mentioned this pull request Sep 12, 2025
Flask support! #8
Merged

posborne requested a review from erikrose September 2, 2025 22:14

posborne force-pushed the posborne/update-wit-ci-and-tests branch 2 times, most recently from 30919ef to a279d39Compare September 2, 2025 22:41

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment thread.github/workflows/python-ci.yml Outdated
Comment thread.github/workflows/python-ci.yml
Comment threadapp.py Outdated
Comment threadapp.py
Comment threadpyproject.toml Outdated
Comment threadtests/test_integration.py Outdated

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 29f294e to c239fccCompare September 3, 2025 17:28

posborne added 7 commits September 3, 2025 18:13

Update WIT definitions, add tests & CI infra
1a38384

Constrain dependency versions more tightly
08afbdf

tests: avoid using the default viceroy port
985b293
Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

tests: removed fixed blocking time for viceroy startup
090ca4f
We key off extra output included when running the server in verbose mode to know when viceroy is ready.

Fix lint errors and add ruff --fix helper
a234982

Use sys.stderror directly for wsgi.errors
ef3406b

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 8165059 to ef3406bCompare September 3, 2025 18:13

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated

posborne commented Sep 3, 2025
View reviewed changes

Comment threadfastly_compute/testing.py Outdated

testing: fix output capturing & simplify
2bc81e9

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 5c8041a to 2bc81e9Compare September 4, 2025 19:04

testing: remove need to pass viceroy_server around
7751eeb
We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

This was referenced Sep 4, 2025
fd_write crash on send_downstream() when updating to latest Viceroy #5
Closed
Make writing to stdout and stderr not crash #2
Closed

erikrose reviewed Sep 5, 2025
View reviewed changes

posborne added 2 commits September 5, 2025 16:26

testing: drop integration test marker
040e3c1

docs: fix typo and small updates
dbd2cf3

erikrose reviewed Sep 5, 2025
View reviewed changes

erikrose approved these changes Sep 5, 2025
View reviewed changes

docs: remove references to "integration" tests in a few more places
7ff2a5a

posborne merged commit 7f5856a into mainSep 5, 2025
3 checks passed

posborne deleted the posborne/update-wit-ci-and-tests branch September 5, 2025 19:45

erikrose mentioned this pull request Sep 12, 2025
Flask support! #8
Merged

posborne requested a review from erikrose September 2, 2025 22:14

posborne force-pushed the posborne/update-wit-ci-and-tests branch 2 times, most recently from 30919ef to a279d39Compare September 2, 2025 22:41

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment thread.github/workflows/python-ci.yml Outdated
Comment thread.github/workflows/python-ci.yml
Comment threadapp.py Outdated
Comment threadapp.py
Comment threadpyproject.toml Outdated
Comment threadtests/test_integration.py Outdated

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 29f294e to c239fccCompare September 3, 2025 17:28

posborne added 7 commits September 3, 2025 18:13

Update WIT definitions, add tests & CI infra
1a38384

Constrain dependency versions more tightly
08afbdf

tests: avoid using the default viceroy port
985b293
Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

tests: removed fixed blocking time for viceroy startup
090ca4f
We key off extra output included when running the server in verbose mode to know when viceroy is ready.

Fix lint errors and add ruff --fix helper
a234982

Use sys.stderror directly for wsgi.errors
ef3406b

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 8165059 to ef3406bCompare September 3, 2025 18:13

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated

posborne commented Sep 3, 2025
View reviewed changes

Comment threadfastly_compute/testing.py Outdated

testing: fix output capturing & simplify
2bc81e9

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 5c8041a to 2bc81e9Compare September 4, 2025 19:04

testing: remove need to pass viceroy_server around
7751eeb
We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

This was referenced Sep 4, 2025
fd_write crash on send_downstream() when updating to latest Viceroy #5
Closed
Make writing to stdout and stderr not crash #2
Closed

erikrose reviewed Sep 5, 2025
View reviewed changes

posborne added 2 commits September 5, 2025 16:26

testing: drop integration test marker
040e3c1

docs: fix typo and small updates
dbd2cf3

erikrose reviewed Sep 5, 2025
View reviewed changes

erikrose approved these changes Sep 5, 2025
View reviewed changes

docs: remove references to "integration" tests in a few more places
7ff2a5a

posborne merged commit 7f5856a into mainSep 5, 2025
3 checks passed

posborne deleted the posborne/update-wit-ci-and-tests branch September 5, 2025 19:45

erikrose mentioned this pull request Sep 12, 2025
Flask support! #8
Merged

posborne requested a review from erikrose September 2, 2025 22:14

posborne force-pushed the posborne/update-wit-ci-and-tests branch 2 times, most recently from 30919ef to a279d39Compare September 2, 2025 22:41

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment thread.github/workflows/python-ci.yml Outdated
Comment thread.github/workflows/python-ci.yml
Comment threadapp.py Outdated
Comment threadapp.py
Comment threadpyproject.toml Outdated
Comment threadtests/test_integration.py Outdated

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 29f294e to c239fccCompare September 3, 2025 17:28

posborne added 7 commits September 3, 2025 18:13

Update WIT definitions, add tests & CI infra
1a38384

Constrain dependency versions more tightly
08afbdf

tests: avoid using the default viceroy port
985b293
Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

tests: removed fixed blocking time for viceroy startup
090ca4f
We key off extra output included when running the server in verbose mode to know when viceroy is ready.

Fix lint errors and add ruff --fix helper
a234982

Use sys.stderror directly for wsgi.errors
ef3406b

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 8165059 to ef3406bCompare September 3, 2025 18:13

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated

posborne commented Sep 3, 2025
View reviewed changes

Comment threadfastly_compute/testing.py Outdated

testing: fix output capturing & simplify
2bc81e9

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 5c8041a to 2bc81e9Compare September 4, 2025 19:04

testing: remove need to pass viceroy_server around
7751eeb
We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

This was referenced Sep 4, 2025
fd_write crash on send_downstream() when updating to latest Viceroy #5
Closed
Make writing to stdout and stderr not crash #2
Closed

erikrose reviewed Sep 5, 2025
View reviewed changes

posborne added 2 commits September 5, 2025 16:26

testing: drop integration test marker
040e3c1

docs: fix typo and small updates
dbd2cf3

erikrose reviewed Sep 5, 2025
View reviewed changes

erikrose approved these changes Sep 5, 2025
View reviewed changes

docs: remove references to "integration" tests in a few more places
7ff2a5a

posborne merged commit 7f5856a into mainSep 5, 2025
3 checks passed

posborne deleted the posborne/update-wit-ci-and-tests branch September 5, 2025 19:45

erikrose mentioned this pull request Sep 12, 2025
Flask support! #8
Merged

posborne requested a review from erikrose September 2, 2025 22:14

posborne force-pushed the posborne/update-wit-ci-and-tests branch 2 times, most recently from 30919ef to a279d39Compare September 2, 2025 22:41

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment thread.github/workflows/python-ci.yml Outdated
Comment thread.github/workflows/python-ci.yml
Comment threadapp.py Outdated
Comment threadapp.py
Comment threadpyproject.toml Outdated
Comment threadtests/test_integration.py Outdated

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 29f294e to c239fccCompare September 3, 2025 17:28

posborne added 7 commits September 3, 2025 18:13

Update WIT definitions, add tests & CI infra
1a38384

Constrain dependency versions more tightly
08afbdf

tests: avoid using the default viceroy port
985b293
Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

tests: removed fixed blocking time for viceroy startup
090ca4f
We key off extra output included when running the server in verbose mode to know when viceroy is ready.

Fix lint errors and add ruff --fix helper
a234982

Use sys.stderror directly for wsgi.errors
ef3406b

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 8165059 to ef3406bCompare September 3, 2025 18:13

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated

posborne commented Sep 3, 2025
View reviewed changes

Comment threadfastly_compute/testing.py Outdated

testing: fix output capturing & simplify
2bc81e9

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 5c8041a to 2bc81e9Compare September 4, 2025 19:04

testing: remove need to pass viceroy_server around
7751eeb
We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

This was referenced Sep 4, 2025
fd_write crash on send_downstream() when updating to latest Viceroy #5
Closed
Make writing to stdout and stderr not crash #2
Closed

erikrose reviewed Sep 5, 2025
View reviewed changes

posborne added 2 commits September 5, 2025 16:26

testing: drop integration test marker
040e3c1

docs: fix typo and small updates
dbd2cf3

erikrose reviewed Sep 5, 2025
View reviewed changes

erikrose approved these changes Sep 5, 2025
View reviewed changes

docs: remove references to "integration" tests in a few more places
7ff2a5a

posborne merged commit 7f5856a into mainSep 5, 2025
3 checks passed

posborne deleted the posborne/update-wit-ci-and-tests branch September 5, 2025 19:45

erikrose mentioned this pull request Sep 12, 2025
Flask support! #8
Merged

posborne requested a review from erikrose September 2, 2025 22:14

posborne force-pushed the posborne/update-wit-ci-and-tests branch 2 times, most recently from 30919ef to a279d39Compare September 2, 2025 22:41

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment thread.github/workflows/python-ci.yml Outdated
Comment thread.github/workflows/python-ci.yml
Comment threadapp.py Outdated
Comment threadapp.py
Comment threadpyproject.toml Outdated
Comment threadtests/test_integration.py Outdated

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 29f294e to c239fccCompare September 3, 2025 17:28

posborne added 7 commits September 3, 2025 18:13

Update WIT definitions, add tests & CI infra
1a38384

Constrain dependency versions more tightly
08afbdf

tests: avoid using the default viceroy port
985b293
Find an available port and use that for a given test run to avoid interference with other running viceroy instances or services on the local machine.

tests: removed fixed blocking time for viceroy startup
090ca4f
We key off extra output included when running the server in verbose mode to know when viceroy is ready.

Fix lint errors and add ruff --fix helper
a234982

Use sys.stderror directly for wsgi.errors
ef3406b

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 8165059 to ef3406bCompare September 3, 2025 18:13

erikrose reviewed Sep 3, 2025
View reviewed changes

Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated
Comment threadtests/test_integration.py Outdated

posborne commented Sep 3, 2025
View reviewed changes

Comment threadfastly_compute/testing.py Outdated

testing: fix output capturing & simplify
2bc81e9

posborne force-pushed the posborne/update-wit-ci-and-tests branch from 5c8041a to 2bc81e9Compare September 4, 2025 19:04

testing: remove need to pass viceroy_server around
7751eeb
We hide the viceroy_server by making it be an autouse fixture on the class which lets us clean things up a fair bit. It stands to reason that all viceroy based tests will want a server.

This was referenced Sep 4, 2025
fd_write crash on send_downstream() when updating to latest Viceroy #5
Closed
Make writing to stdout and stderr not crash #2
Closed

erikrose reviewed Sep 5, 2025
View reviewed changes

posborne added 2 commits September 5, 2025 16:26

testing: drop integration test marker
040e3c1

docs: fix typo and small updates
dbd2cf3

erikrose reviewed Sep 5, 2025
View reviewed changes

erikrose approved these changes Sep 5, 2025
View reviewed changes

docs: remove references to "integration" tests in a few more places
7ff2a5a

posborne merged commit 7f5856a into mainSep 5, 2025
3 checks passed

posborne deleted the posborne/update-wit-ci-and-tests branch September 5, 2025 19:45

erikrose mentioned this pull request Sep 12, 2025
Flask support! #8
Merged

Uh oh!

Conversation

posborne commented Sep 2, 2025

Uh oh!

erikrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erikrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erikrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erikrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

posborne commented Sep 2, 2025

Uh oh!

erikrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erikrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erikrose left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erikrose left a comment

Choose a reason for hiding this comment