Skip to content

Run black and update setup.cfg for flake8 to ignore E701 and E704 - #609

Merged
wbarnha merged 1 commit into
faust-streaming:masterfrom
Tim-Thomas:fix_lint
Feb 16, 2024
Merged

Run black and update setup.cfg for flake8 to ignore E701 and E704#609
wbarnha merged 1 commit into
faust-streaming:masterfrom
Tim-Thomas:fix_lint

Conversation

@Tim-Thomas

Copy link
Copy Markdown
Contributor

This re-formats everything to match current black configuration and allow flake8 to succeed.

@Tim-Thomas

Tim-Thomas commented Feb 16, 2024

Copy link
Copy Markdown
ContributorAuthor

This seems to be a deliberate change to black: https://github.com/psf/black/pull/4066/files and the conflict with flake8 as well as the solution (tell flake8 to ignore e701 and e704) is documented here: psf/black#4173

@Tim-Thomas
Tim-Thomas marked this pull request as draft February 16, 2024 18:57
@Tim-Thomas
Tim-Thomas marked this pull request as ready for review February 16, 2024 19:01
@codecov

codecovBot commented Feb 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4a09533) 93.73% compared to head (307f4fd) 93.72%.

FilesPatch %Lines
faust/transport/consumer.py50.00%0 Missing and 2 partials ⚠️
faust/contrib/sentry.py0.00%1 Missing ⚠️
faust/livecheck/case.py50.00%0 Missing and 1 partial ⚠️
faust/sensors/base.py0.00%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #609 +/- ##
==========================================
- Coverage 93.73% 93.72% -0.02% 
==========================================
Files 102 102 Lines 11158 11122 -36 Branches 1536 1545 +9 ==========================================
- Hits 10459 10424 -35 + Misses 612 607 -5 - Partials 87 91 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wbarnhawbarnha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR as well! LGTM!

@wbarnha
wbarnha merged commit 6d248bf into faust-streaming:masterFeb 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Tim-Thomas@wbarnha