Show max time per request in statistics - #228
Merged
Merged
Conversation
Add a "Max time per request" line to both the per-task and global statistics blocks. The output previously stopped at the 99.9th percentile, which hides the true worst-case latency. The value is read from the existing hdrhistogram via `max()`, so no extra bookkeeping is needed. Closes #188 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Max time per request line to both the per-task and global statistics blocks. Previously the worst-case figure shown was the 99.9th percentile, which (as noted in #188) often is not enough to understand a system's tail behavior. The max is read straight from the existing
hdrhistogramviamax(), so there is no extra bookkeeping or memory cost.Example output
Notes
cargo fmt --check,cargo clippy, andcargo buildall pass.Closes #188
🤖 Generated with Claude Code