Uh oh!
There was an error while loading. Please reload this page.
Modifying a bit weighting of completion list SmartMatch - #1173
Open
elsassph wants to merge 1 commit into
Open
Conversation
…artMatch. Collateral damage is that abbreviation matching is now only enabled for all-uppercase words.
Meychi
commented
Jun 17, 2016
Member
@Neverbirth, @SlavaRa, @wise0704, comments? |
Neverbirth
commented
Jun 17, 2016
Contributor
I think I completely missed this PR until now... not a part of code I really know. I'd need to try out how the completion feel with the abbreviation change, by looking at the changes it seems to me the issue is already fixed without that behaviour change? |
Contributor
elsassph
commented
Jun 19, 2016
MemberAuthor
It needs unit tests as well, because the weighting was changed a bit randomly. |
Meychi
commented
Jun 20, 2016
Member
@elsassph: Will you add tests here or should we merge as such? |
elsassph
commented
Jun 21, 2016
MemberAuthor
We shouldn't merge without tests I believe. I'll try to do it quickly. |
Meychi
commented
Aug 24, 2016
Member
@elsassph, any progress? :) |
elsassph
commented
Aug 24, 2016
MemberAuthor
Well... I haven't been able to run tests at all so far :/ |
Meychi
commented
Oct 21, 2016
Member
Any progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes issue #1161
Note: collateral damage is that abbreviation matching is now only enabled for all-uppercase words.