Skip to content

support haxe final keyword - #2971

Open
romamik wants to merge 4 commits into
fdorg:developmentfrom
romamik:final_keyword
Open

support haxe final keyword#2971
romamik wants to merge 4 commits into
fdorg:developmentfrom
romamik:final_keyword

Conversation

@romamik

@romamikromamik commented Jan 27, 2020

Copy link
Copy Markdown
Contributor

Support haxe final keyword for variable completion and coloring.
Resolves#2775 and partially resolves#1925 (does not support final as method modifier.)

r.miklashevskiand others added 2 commits January 27, 2020 18:18
@SlavaRa

Copy link
Copy Markdown

@romamik should this work under haxe < 4.0.0?

@romamik

Copy link
Copy Markdown
ContributorAuthor

I did not test with older haxe versions. IMHO it should not break anything, but may display final in autocompletion list.

@SlavaRa

Copy link
Copy Markdown

I did not test with older haxe versions. IMHO it should not break anything, but may display final in autocompletion list.

I would not be so sure without the tests :)
This shouldn't work for versions < 4.0.0

@romamik

Copy link
Copy Markdown
ContributorAuthor

Do you mean to enable/disable this code depending on haxe version? Is there some example of how can this be accomplished?

@romamik

romamik commented Jan 31, 2020

Copy link
Copy Markdown
ContributorAuthor

I've added version check. Now final is not shown in completion if haxe version is < 4. Also I've tested with haxe 3.4.7.

Not sure if the way I add/remove/check item existense in features.codeKeywords and features.declKeywords arrays is correct.

@SlavaRa

Copy link
Copy Markdown

@romamik i'll check and merge today.

@SlavaRaSlavaRa self-assigned this Dec 6, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Haxe4] Auto-indent wrong after final keyword [Haxe4] Support for final keyword

2 participants

@romamik@SlavaRa