Bbundled annotation type reachability - #182
Merged
Merged
Conversation
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
The annotation reachability trimmer established reachability from attribute usages only, but a using alias names its target type as well. Whenever no [NotNull] usage survived cleanup, the code-analysis NotNullAttribute polyfill was trimmed while the alias directive that names it remained, which does not compile - reproducible with a netstandard2.0 whitelist export that retains no annotated assertion. Bind the target of every alias directive and mark the bundled type it resolves to, using the same degraded-binding fallback as attribute usages, so a failed binding keeps too much rather than too little. Compile every export of the trimmer tests through the generated-file build validator: an over-eager trim removes a declaration that the generated file still names, which no assertion about emitted types can catch. The export that supplies the JetBrains annotations externally is the one exception because it cannot compile on its own. Group the test classes that run MSBuild on the shared source validation project into one collection so their builds no longer race for its intermediate output. Also resolve the exporter's metadata references through a Lazy, annotate TryGetBundledType with MaybeNullWhen, expose the bundled type catalog as read-only lists, and print the merger's progress in execution order. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#181
Also addresses the non-JetBrains attributes.