Skip to content

Materialize via feature server for on-demand feature views crashes #5727

Description

@astronautas

Expected Behavior

I propose we expose an optional parameter to /materialize, to specify whether full_feature_names are passed-in. This way, for projects that really use full_feature_names, the materialize flow won't break.

Current Behavior

We stumbled upon a peculiar issue while working on materializing some ODFVs. It appears deep within the flow, ODFV materialization calls get_historical_features. Why it is done, not sure. In any case, for projects where feature names collide and feature_views act as namespaces, this causes the following issue:

/materialize

    raise FeatureNameCollisionError(collided_feature_refs, full_feature_names)
feast.errors.FeatureNameCollisionError: Duplicate features named <my_feature_1>
To resolve this collision, either use the full feature name by setting 'full_feature_names=True', or ensure that the features in question have different names.

Steps to reproduce

Call /materialize for any arbritrary ODFV.

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions