Uh oh!
There was an error while loading. Please reload this page.
Fix NuGet pack CI step: build in Release mode and exclude Benchmarks - #46
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fixes CI failure in NuGet pack step by ensuring Release mode build and excluding the Benchmarks project from packaging.
- Changed pack command to explicitly build in Release configuration instead of skipping build
- Excluded Benchmarks project from NuGet packaging
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/F23.StringSimilarity.Benchmarks/F23.StringSimilarity.Benchmarks.csproj | Added IsPackable property to prevent benchmark project from being packaged |
| .github/workflows/dotnet.yml | Modified pack command to build in Release mode instead of using pre-built artifacts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
…project Remove --no-build flag to allow dotnet pack to build in Release mode instead of reusing the Debug build. Add IsPackable=false to Benchmarks project to prevent it from being included in NuGet packs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
d9aaadd to
7a37d45CompareThere was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Summary
--no-buildflag from pack command so it builds in Release modeIsPackable=falseFixes the CI failure from the previous NuGet pack PR.
Changes
.github/workflows/dotnet.ymlto usedotnet pack -c Releaseinstead ofdotnet pack --no-build<IsPackable>false</IsPackable>to Benchmarks project fileTest plan
🤖 Generated with Claude Code