Skip to content

Add .NET 8-10 targets - #51

Merged
paulirwin merged 4 commits into
mainfrom
issue/50
Oct 23, 2025
Merged

Add .NET 8-10 targets#51
paulirwin merged 4 commits into
mainfrom
issue/50

Conversation

@paulirwin

Copy link
Copy Markdown
Member

This PR adds the net8.0, net9.0, and net10.0 targets per the discussion/roadmap in #44. These new targets are not signed with a strong name key; only the netstandard2.0 target will be signed.

Fixes#50

@paulirwin
paulirwin marked this pull request as ready for review October 22, 2025 18:15
CopilotAI review requested due to automatic review settings October 22, 2025 18:15

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for .NET 8, 9, and 10 as additional target frameworks alongside the existing netstandard2.0 target. The key architectural change is that only the netstandard2.0 target will be signed with a strong name key, while the newer .NET targets remain unsigned.

  • Adds net8.0, net9.0, and net10.0 as new target frameworks
  • Conditionally applies strong-name signing only to netstandard2.0 target
  • Updates project structure to use newer .slnx solution format and removes legacy Directory.Build.props files

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
src/F23.StringSimilarity/F23.StringSimilarity.csprojAdds multiple target frameworks, conditional signing for netstandard2.0, and updates package versions
src/F23.StringSimilarity/Properties/AssemblyInfo.csConditionally applies InternalsVisibleTo with public key only for signed assemblies
test/F23.StringSimilarity.Tests/F23.StringSimilarity.Tests.csprojAdds conditional signing configuration for net481 target
benchmarks/F23.StringSimilarity.Benchmarks/F23.StringSimilarity.Benchmarks.csprojUpdates target framework to net10.0 and BenchmarkDotNet package version
F23.StringSimilarity.slnxAdds new .slnx solution file format
F23.StringSimilarity.slnRemoves legacy .sln file
Directory.Build.propsRemoves global signing configuration
src/Directory.Build.propsRemoves source-level build props file
test/Directory.Build.propsRemoves test-level build props file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@paulirwin
paulirwin marked this pull request as draft October 22, 2025 20:49
@paulirwin
paulirwin marked this pull request as ready for review October 22, 2025 20:50
@paulirwin
paulirwin merged commit adc3f27 into mainOct 23, 2025
3 checks passed
@paulirwin
paulirwin deleted the issue/50 branch October 23, 2025 18:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .NET 8-10 Targets

3 participants

@paulirwin@jamesmblair