refactor: 2.0 readiness - #280
Merged
Merged
Conversation
- removed Substitute.disableFor
ffMathy
commented
Aug 13, 2025
OwnerAuthor
The king has returned @notanengineercom! ❤️ 🙏 |
notanengineercom
commented
Aug 18, 2025
Collaborator
I finally found the time to focus on the finishing touches 😄. |
Uh oh!
There was an error while loading. Please reload this page.
ffMathy
commented
Aug 20, 2025
OwnerAuthor
So does that mean we can merge it? ❤️ |
notanengineercom
marked this pull request as ready for review
August 21, 2025 09:58
notanengineercom
commented
Aug 21, 2025
Collaborator
I'd say we can yes 😄 All regressions and tests are passing! |
notanengineercom
approved these changes
Aug 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
ffMathy
commented
Aug 21, 2025
OwnerAuthor
Wow I can't believe it's out then! Awesome stuff! 😍 |
ffMathy
commented
Sep 19, 2025
OwnerAuthor
For some reason it's not on NPM yet. Investigating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is work in progress for getting 2.0 released. Thanks Bitwarden and @notanengineercom for fueling this.