feat(AuthUIConfiguration): implement configuration model, DSL builder and tests by demolaf · Pull Request #2216 · firebase/FirebaseUI-Android

demolaf · 2025-09-15T14:16:16Z

Add AuthUIConfiguration data class with all properties
Implement authUIConfiguration DSL builder function
Add AuthProvider, AuthUITheme, AuthUIStringProvider, and PasswordRule models
Create comprehensive tests for default and custom configurations

… and tests

Lyokone · 2025-09-16T07:52:15Z

+import kotlin.reflect.KMutableProperty
+import kotlin.reflect.full.memberProperties
+
+class AuthUIConfigurationTest {


Would like to see a test for the Builder pattern as well

not sure if i understand, doesn't the authUIConfiguration dsl function tests handle the builder pattern test also?

Lyokone · 2025-09-16T13:33:19Z

+ /**
+ * The expected length of the SMS verification code. Defaults to 6.
+ */
+ val smsCodeLength: Int = 6,


is this verified against what we get from Firebase by default?

I got this from the API Design docs, is there somewhere else I could check this from?

Lyokone · 2025-09-16T13:33:47Z

+interface AuthUIStringProvider {
+ fun initializing(): String
+ fun signInWithGoogle(): String
+ fun invalidEmail(): String
+ fun passwordsDoNotMatch(): String
+}
+
+class DefaultAuthUIStringProvider(private val context: Context) : AuthUIStringProvider {
+ override fun initializing(): String = ""
+
+ override fun signInWithGoogle(): String =
+ context.getString(R.string.fui_sign_in_with_google)
+
+ override fun invalidEmail(): String = ""
+
+ override fun passwordsDoNotMatch(): String = ""


We'll need documentation for this

Yes, that's a different ticket here

Lyokone · 2025-09-16T13:35:11Z

+sealed class PasswordRule {
+ /**
+ * Requires the password to have at least a certain number of characters.
+ */
+ data class MinimumLength(val value: Int) : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one uppercase letter (A-Z).
+ */
+ object RequireUppercase : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one lowercase letter (a-z).
+ */
+ object RequireLowercase: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one numeric digit (0-9).
+ */
+ object RequireDigit: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one special character (e.g., !@#$%^&*).
+ */
+ object RequireSpecialCharacter: PasswordRule()
+
+ /**
+ * Defines a custom validation rule using a regular expression and provides a specific error
+ * message on failure.
+ */
+ data class Custom(val regex: Regex, val errorMessage: String)
+}


Would be nice to have the actual validation inside of this sealed class (maybe even something that can validate a list of PasswordRules

Yeah this is a different ticket too here, don't want to cramp them all in a single PR.

replaced sealed with abstract class, data with regular class use isXX prefix for booleans

…droid into feat/C1

demolaf · 2025-09-15T14:16:16Z

Add AuthUIConfiguration data class with all properties
Implement authUIConfiguration DSL builder function
Add AuthProvider, AuthUITheme, AuthUIStringProvider, and PasswordRule models
Create comprehensive tests for default and custom configurations

… and tests

…baseUI-Android into feat/C1

Lyokone · 2025-09-16T07:52:15Z

+import kotlin.reflect.KMutableProperty
+import kotlin.reflect.full.memberProperties
+
+class AuthUIConfigurationTest {


Would like to see a test for the Builder pattern as well

not sure if i understand, doesn't the authUIConfiguration dsl function tests handle the builder pattern test also?

Lyokone · 2025-09-16T13:33:19Z

+ /**
+ * The expected length of the SMS verification code. Defaults to 6.
+ */
+ val smsCodeLength: Int = 6,


is this verified against what we get from Firebase by default?

I got this from the API Design docs, is there somewhere else I could check this from?

Lyokone · 2025-09-16T13:33:47Z

+interface AuthUIStringProvider {
+ fun initializing(): String
+ fun signInWithGoogle(): String
+ fun invalidEmail(): String
+ fun passwordsDoNotMatch(): String
+}
+
+class DefaultAuthUIStringProvider(private val context: Context) : AuthUIStringProvider {
+ override fun initializing(): String = ""
+
+ override fun signInWithGoogle(): String =
+ context.getString(R.string.fui_sign_in_with_google)
+
+ override fun invalidEmail(): String = ""
+
+ override fun passwordsDoNotMatch(): String = ""


We'll need documentation for this

Yes, that's a different ticket here

Lyokone · 2025-09-16T13:35:11Z

+sealed class PasswordRule {
+ /**
+ * Requires the password to have at least a certain number of characters.
+ */
+ data class MinimumLength(val value: Int) : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one uppercase letter (A-Z).
+ */
+ object RequireUppercase : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one lowercase letter (a-z).
+ */
+ object RequireLowercase: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one numeric digit (0-9).
+ */
+ object RequireDigit: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one special character (e.g., !@#$%^&*).
+ */
+ object RequireSpecialCharacter: PasswordRule()
+
+ /**
+ * Defines a custom validation rule using a regular expression and provides a specific error
+ * message on failure.
+ */
+ data class Custom(val regex: Regex, val errorMessage: String)
+}


Would be nice to have the actual validation inside of this sealed class (maybe even something that can validate a list of PasswordRules

Yeah this is a different ticket too here, don't want to cramp them all in a single PR.

replaced sealed with abstract class, data with regular class use isXX prefix for booleans

…droid into feat/C1

demolaf · 2025-09-15T14:16:16Z

Add AuthUIConfiguration data class with all properties
Implement authUIConfiguration DSL builder function
Add AuthProvider, AuthUITheme, AuthUIStringProvider, and PasswordRule models
Create comprehensive tests for default and custom configurations

… and tests

…baseUI-Android into feat/C1

Lyokone · 2025-09-16T07:52:15Z

+import kotlin.reflect.KMutableProperty
+import kotlin.reflect.full.memberProperties
+
+class AuthUIConfigurationTest {


Would like to see a test for the Builder pattern as well

not sure if i understand, doesn't the authUIConfiguration dsl function tests handle the builder pattern test also?

Lyokone · 2025-09-16T13:33:19Z

+ /**
+ * The expected length of the SMS verification code. Defaults to 6.
+ */
+ val smsCodeLength: Int = 6,


is this verified against what we get from Firebase by default?

I got this from the API Design docs, is there somewhere else I could check this from?

Lyokone · 2025-09-16T13:33:47Z

+interface AuthUIStringProvider {
+ fun initializing(): String
+ fun signInWithGoogle(): String
+ fun invalidEmail(): String
+ fun passwordsDoNotMatch(): String
+}
+
+class DefaultAuthUIStringProvider(private val context: Context) : AuthUIStringProvider {
+ override fun initializing(): String = ""
+
+ override fun signInWithGoogle(): String =
+ context.getString(R.string.fui_sign_in_with_google)
+
+ override fun invalidEmail(): String = ""
+
+ override fun passwordsDoNotMatch(): String = ""


We'll need documentation for this

Yes, that's a different ticket here

Lyokone · 2025-09-16T13:35:11Z

+sealed class PasswordRule {
+ /**
+ * Requires the password to have at least a certain number of characters.
+ */
+ data class MinimumLength(val value: Int) : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one uppercase letter (A-Z).
+ */
+ object RequireUppercase : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one lowercase letter (a-z).
+ */
+ object RequireLowercase: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one numeric digit (0-9).
+ */
+ object RequireDigit: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one special character (e.g., !@#$%^&*).
+ */
+ object RequireSpecialCharacter: PasswordRule()
+
+ /**
+ * Defines a custom validation rule using a regular expression and provides a specific error
+ * message on failure.
+ */
+ data class Custom(val regex: Regex, val errorMessage: String)
+}


Would be nice to have the actual validation inside of this sealed class (maybe even something that can validate a list of PasswordRules

Yeah this is a different ticket too here, don't want to cramp them all in a single PR.

replaced sealed with abstract class, data with regular class use isXX prefix for booleans

…droid into feat/C1

demolaf · 2025-09-15T14:16:16Z

Add AuthUIConfiguration data class with all properties
Implement authUIConfiguration DSL builder function
Add AuthProvider, AuthUITheme, AuthUIStringProvider, and PasswordRule models
Create comprehensive tests for default and custom configurations

… and tests

…baseUI-Android into feat/C1

Lyokone · 2025-09-16T07:52:15Z

+import kotlin.reflect.KMutableProperty
+import kotlin.reflect.full.memberProperties
+
+class AuthUIConfigurationTest {


Would like to see a test for the Builder pattern as well

not sure if i understand, doesn't the authUIConfiguration dsl function tests handle the builder pattern test also?

Lyokone · 2025-09-16T13:33:19Z

+ /**
+ * The expected length of the SMS verification code. Defaults to 6.
+ */
+ val smsCodeLength: Int = 6,


is this verified against what we get from Firebase by default?

I got this from the API Design docs, is there somewhere else I could check this from?

Lyokone · 2025-09-16T13:33:47Z

+interface AuthUIStringProvider {
+ fun initializing(): String
+ fun signInWithGoogle(): String
+ fun invalidEmail(): String
+ fun passwordsDoNotMatch(): String
+}
+
+class DefaultAuthUIStringProvider(private val context: Context) : AuthUIStringProvider {
+ override fun initializing(): String = ""
+
+ override fun signInWithGoogle(): String =
+ context.getString(R.string.fui_sign_in_with_google)
+
+ override fun invalidEmail(): String = ""
+
+ override fun passwordsDoNotMatch(): String = ""


We'll need documentation for this

Yes, that's a different ticket here

Lyokone · 2025-09-16T13:35:11Z

+sealed class PasswordRule {
+ /**
+ * Requires the password to have at least a certain number of characters.
+ */
+ data class MinimumLength(val value: Int) : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one uppercase letter (A-Z).
+ */
+ object RequireUppercase : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one lowercase letter (a-z).
+ */
+ object RequireLowercase: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one numeric digit (0-9).
+ */
+ object RequireDigit: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one special character (e.g., !@#$%^&*).
+ */
+ object RequireSpecialCharacter: PasswordRule()
+
+ /**
+ * Defines a custom validation rule using a regular expression and provides a specific error
+ * message on failure.
+ */
+ data class Custom(val regex: Regex, val errorMessage: String)
+}


Would be nice to have the actual validation inside of this sealed class (maybe even something that can validate a list of PasswordRules

Yeah this is a different ticket too here, don't want to cramp them all in a single PR.

replaced sealed with abstract class, data with regular class use isXX prefix for booleans

…droid into feat/C1

demolaf · 2025-09-15T14:16:16Z

Add AuthUIConfiguration data class with all properties
Implement authUIConfiguration DSL builder function
Add AuthProvider, AuthUITheme, AuthUIStringProvider, and PasswordRule models
Create comprehensive tests for default and custom configurations

… and tests

…baseUI-Android into feat/C1

Lyokone · 2025-09-16T07:52:15Z

+import kotlin.reflect.KMutableProperty
+import kotlin.reflect.full.memberProperties
+
+class AuthUIConfigurationTest {


Would like to see a test for the Builder pattern as well

not sure if i understand, doesn't the authUIConfiguration dsl function tests handle the builder pattern test also?

Lyokone · 2025-09-16T13:33:19Z

+ /**
+ * The expected length of the SMS verification code. Defaults to 6.
+ */
+ val smsCodeLength: Int = 6,


is this verified against what we get from Firebase by default?

I got this from the API Design docs, is there somewhere else I could check this from?

Lyokone · 2025-09-16T13:33:47Z

+interface AuthUIStringProvider {
+ fun initializing(): String
+ fun signInWithGoogle(): String
+ fun invalidEmail(): String
+ fun passwordsDoNotMatch(): String
+}
+
+class DefaultAuthUIStringProvider(private val context: Context) : AuthUIStringProvider {
+ override fun initializing(): String = ""
+
+ override fun signInWithGoogle(): String =
+ context.getString(R.string.fui_sign_in_with_google)
+
+ override fun invalidEmail(): String = ""
+
+ override fun passwordsDoNotMatch(): String = ""


We'll need documentation for this

Yes, that's a different ticket here

Lyokone · 2025-09-16T13:35:11Z

+sealed class PasswordRule {
+ /**
+ * Requires the password to have at least a certain number of characters.
+ */
+ data class MinimumLength(val value: Int) : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one uppercase letter (A-Z).
+ */
+ object RequireUppercase : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one lowercase letter (a-z).
+ */
+ object RequireLowercase: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one numeric digit (0-9).
+ */
+ object RequireDigit: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one special character (e.g., !@#$%^&*).
+ */
+ object RequireSpecialCharacter: PasswordRule()
+
+ /**
+ * Defines a custom validation rule using a regular expression and provides a specific error
+ * message on failure.
+ */
+ data class Custom(val regex: Regex, val errorMessage: String)
+}


Would be nice to have the actual validation inside of this sealed class (maybe even something that can validate a list of PasswordRules

Yeah this is a different ticket too here, don't want to cramp them all in a single PR.

replaced sealed with abstract class, data with regular class use isXX prefix for booleans

…droid into feat/C1

demolaf · 2025-09-15T14:16:16Z

Add AuthUIConfiguration data class with all properties
Implement authUIConfiguration DSL builder function
Add AuthProvider, AuthUITheme, AuthUIStringProvider, and PasswordRule models
Create comprehensive tests for default and custom configurations

… and tests

…baseUI-Android into feat/C1

Lyokone · 2025-09-16T07:52:15Z

+import kotlin.reflect.KMutableProperty
+import kotlin.reflect.full.memberProperties
+
+class AuthUIConfigurationTest {


Would like to see a test for the Builder pattern as well

not sure if i understand, doesn't the authUIConfiguration dsl function tests handle the builder pattern test also?

Lyokone · 2025-09-16T13:33:19Z

+ /**
+ * The expected length of the SMS verification code. Defaults to 6.
+ */
+ val smsCodeLength: Int = 6,


is this verified against what we get from Firebase by default?

I got this from the API Design docs, is there somewhere else I could check this from?

Lyokone · 2025-09-16T13:33:47Z

+interface AuthUIStringProvider {
+ fun initializing(): String
+ fun signInWithGoogle(): String
+ fun invalidEmail(): String
+ fun passwordsDoNotMatch(): String
+}
+
+class DefaultAuthUIStringProvider(private val context: Context) : AuthUIStringProvider {
+ override fun initializing(): String = ""
+
+ override fun signInWithGoogle(): String =
+ context.getString(R.string.fui_sign_in_with_google)
+
+ override fun invalidEmail(): String = ""
+
+ override fun passwordsDoNotMatch(): String = ""


We'll need documentation for this

Yes, that's a different ticket here

Lyokone · 2025-09-16T13:35:11Z

+sealed class PasswordRule {
+ /**
+ * Requires the password to have at least a certain number of characters.
+ */
+ data class MinimumLength(val value: Int) : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one uppercase letter (A-Z).
+ */
+ object RequireUppercase : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one lowercase letter (a-z).
+ */
+ object RequireLowercase: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one numeric digit (0-9).
+ */
+ object RequireDigit: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one special character (e.g., !@#$%^&*).
+ */
+ object RequireSpecialCharacter: PasswordRule()
+
+ /**
+ * Defines a custom validation rule using a regular expression and provides a specific error
+ * message on failure.
+ */
+ data class Custom(val regex: Regex, val errorMessage: String)
+}


Would be nice to have the actual validation inside of this sealed class (maybe even something that can validate a list of PasswordRules

Yeah this is a different ticket too here, don't want to cramp them all in a single PR.

replaced sealed with abstract class, data with regular class use isXX prefix for booleans

…droid into feat/C1

demolaf · 2025-09-15T14:16:16Z

Add AuthUIConfiguration data class with all properties
Implement authUIConfiguration DSL builder function
Add AuthProvider, AuthUITheme, AuthUIStringProvider, and PasswordRule models
Create comprehensive tests for default and custom configurations

… and tests

…baseUI-Android into feat/C1

Lyokone · 2025-09-16T07:52:15Z

+import kotlin.reflect.KMutableProperty
+import kotlin.reflect.full.memberProperties
+
+class AuthUIConfigurationTest {


Would like to see a test for the Builder pattern as well

not sure if i understand, doesn't the authUIConfiguration dsl function tests handle the builder pattern test also?

Lyokone · 2025-09-16T13:33:19Z

+ /**
+ * The expected length of the SMS verification code. Defaults to 6.
+ */
+ val smsCodeLength: Int = 6,


is this verified against what we get from Firebase by default?

I got this from the API Design docs, is there somewhere else I could check this from?

Lyokone · 2025-09-16T13:33:47Z

+interface AuthUIStringProvider {
+ fun initializing(): String
+ fun signInWithGoogle(): String
+ fun invalidEmail(): String
+ fun passwordsDoNotMatch(): String
+}
+
+class DefaultAuthUIStringProvider(private val context: Context) : AuthUIStringProvider {
+ override fun initializing(): String = ""
+
+ override fun signInWithGoogle(): String =
+ context.getString(R.string.fui_sign_in_with_google)
+
+ override fun invalidEmail(): String = ""
+
+ override fun passwordsDoNotMatch(): String = ""


We'll need documentation for this

Yes, that's a different ticket here

Lyokone · 2025-09-16T13:35:11Z

+sealed class PasswordRule {
+ /**
+ * Requires the password to have at least a certain number of characters.
+ */
+ data class MinimumLength(val value: Int) : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one uppercase letter (A-Z).
+ */
+ object RequireUppercase : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one lowercase letter (a-z).
+ */
+ object RequireLowercase: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one numeric digit (0-9).
+ */
+ object RequireDigit: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one special character (e.g., !@#$%^&*).
+ */
+ object RequireSpecialCharacter: PasswordRule()
+
+ /**
+ * Defines a custom validation rule using a regular expression and provides a specific error
+ * message on failure.
+ */
+ data class Custom(val regex: Regex, val errorMessage: String)
+}


Would be nice to have the actual validation inside of this sealed class (maybe even something that can validate a list of PasswordRules

Yeah this is a different ticket too here, don't want to cramp them all in a single PR.

replaced sealed with abstract class, data with regular class use isXX prefix for booleans

…droid into feat/C1

demolaf · 2025-09-15T14:16:16Z

Add AuthUIConfiguration data class with all properties
Implement authUIConfiguration DSL builder function
Add AuthProvider, AuthUITheme, AuthUIStringProvider, and PasswordRule models
Create comprehensive tests for default and custom configurations

… and tests

…baseUI-Android into feat/C1

Lyokone · 2025-09-16T07:52:15Z

+import kotlin.reflect.KMutableProperty
+import kotlin.reflect.full.memberProperties
+
+class AuthUIConfigurationTest {


Would like to see a test for the Builder pattern as well

not sure if i understand, doesn't the authUIConfiguration dsl function tests handle the builder pattern test also?

Lyokone · 2025-09-16T13:33:19Z

+ /**
+ * The expected length of the SMS verification code. Defaults to 6.
+ */
+ val smsCodeLength: Int = 6,


is this verified against what we get from Firebase by default?

I got this from the API Design docs, is there somewhere else I could check this from?

Lyokone · 2025-09-16T13:33:47Z

+interface AuthUIStringProvider {
+ fun initializing(): String
+ fun signInWithGoogle(): String
+ fun invalidEmail(): String
+ fun passwordsDoNotMatch(): String
+}
+
+class DefaultAuthUIStringProvider(private val context: Context) : AuthUIStringProvider {
+ override fun initializing(): String = ""
+
+ override fun signInWithGoogle(): String =
+ context.getString(R.string.fui_sign_in_with_google)
+
+ override fun invalidEmail(): String = ""
+
+ override fun passwordsDoNotMatch(): String = ""


We'll need documentation for this

Yes, that's a different ticket here

Lyokone · 2025-09-16T13:35:11Z

+sealed class PasswordRule {
+ /**
+ * Requires the password to have at least a certain number of characters.
+ */
+ data class MinimumLength(val value: Int) : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one uppercase letter (A-Z).
+ */
+ object RequireUppercase : PasswordRule()
+
+ /**
+ * Requires the password to contain at least one lowercase letter (a-z).
+ */
+ object RequireLowercase: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one numeric digit (0-9).
+ */
+ object RequireDigit: PasswordRule()
+
+ /**
+ * Requires the password to contain at least one special character (e.g., !@#$%^&*).
+ */
+ object RequireSpecialCharacter: PasswordRule()
+
+ /**
+ * Defines a custom validation rule using a regular expression and provides a specific error
+ * message on failure.
+ */
+ data class Custom(val regex: Regex, val errorMessage: String)
+}


Would be nice to have the actual validation inside of this sealed class (maybe even something that can validate a list of PasswordRules

Yeah this is a different ticket too here, don't want to cramp them all in a single PR.

replaced sealed with abstract class, data with regular class use isXX prefix for booleans

…droid into feat/C1

demolaf marked this pull request as draft September 15, 2025 14:16

demolaf marked this pull request as ready for review September 15, 2025 14:17

demolaf added 2 commits September 15, 2025 15:59

feat(AuthUIConfiguration): implement configuration model, DSL builder…
a62097d
… and tests

Merge branch 'version-10.0.0-dev' ofhttps://github.com/firebase/Fire…
bf7c10b
…baseUI-Android into feat/C1

demolaf force-pushed the feat/C1 branch from e4d1ef3 to bf7c10bCompare September 15, 2025 15:01

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 11:13

refactor: use OAuthProvider base class for common properties
2c563bd

feat: add Provider enum class for provider ids
1ba20ae

feat: setup default provider styles for each provider
63c8e18

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 21:01

test: added builder validation logic from old auth library and tests
a5a944a

refactor: changes in API design docs
19787df
replaced sealed with abstract class, data with regular class use isXX prefix for booleans

test: fix AuthUIConfiguration constructor test
7e010e4

Lyokone approved these changes Sep 18, 2025
View reviewed changes

Merge branch 'version-10.0.0-dev' of github.com:demolaf/FirebaseUI-An…
4c9cc5e
…droid into feat/C1

Lyokone merged commit ed436cf into firebase:version-10.0.0-devSep 19, 2025
2 checks passed

demolaf mentioned this pull request Oct 2, 2025
release: internal release candidate (2025-10-02) #2232
Closed

demolaf mentioned this pull request Nov 26, 2025
release: internal release candidate (2025-10-02) #2275
Merged

demolaf marked this pull request as draft September 15, 2025 14:16

demolaf marked this pull request as ready for review September 15, 2025 14:17

demolaf added 2 commits September 15, 2025 15:59

feat(AuthUIConfiguration): implement configuration model, DSL builder…
a62097d
… and tests

Merge branch 'version-10.0.0-dev' ofhttps://github.com/firebase/Fire…
bf7c10b
…baseUI-Android into feat/C1

demolaf force-pushed the feat/C1 branch from e4d1ef3 to bf7c10bCompare September 15, 2025 15:01

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 11:13

refactor: use OAuthProvider base class for common properties
2c563bd

feat: add Provider enum class for provider ids
1ba20ae

feat: setup default provider styles for each provider
63c8e18

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 21:01

test: added builder validation logic from old auth library and tests
a5a944a

refactor: changes in API design docs
19787df
replaced sealed with abstract class, data with regular class use isXX prefix for booleans

test: fix AuthUIConfiguration constructor test
7e010e4

Lyokone approved these changes Sep 18, 2025
View reviewed changes

Merge branch 'version-10.0.0-dev' of github.com:demolaf/FirebaseUI-An…
4c9cc5e
…droid into feat/C1

Lyokone merged commit ed436cf into firebase:version-10.0.0-devSep 19, 2025
2 checks passed

demolaf mentioned this pull request Oct 2, 2025
release: internal release candidate (2025-10-02) #2232
Closed

demolaf mentioned this pull request Nov 26, 2025
release: internal release candidate (2025-10-02) #2275
Merged

demolaf marked this pull request as draft September 15, 2025 14:16

demolaf marked this pull request as ready for review September 15, 2025 14:17

demolaf added 2 commits September 15, 2025 15:59

feat(AuthUIConfiguration): implement configuration model, DSL builder…
a62097d
… and tests

Merge branch 'version-10.0.0-dev' ofhttps://github.com/firebase/Fire…
bf7c10b
…baseUI-Android into feat/C1

demolaf force-pushed the feat/C1 branch from e4d1ef3 to bf7c10bCompare September 15, 2025 15:01

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 11:13

refactor: use OAuthProvider base class for common properties
2c563bd

feat: add Provider enum class for provider ids
1ba20ae

feat: setup default provider styles for each provider
63c8e18

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 21:01

test: added builder validation logic from old auth library and tests
a5a944a

refactor: changes in API design docs
19787df
replaced sealed with abstract class, data with regular class use isXX prefix for booleans

test: fix AuthUIConfiguration constructor test
7e010e4

Lyokone approved these changes Sep 18, 2025
View reviewed changes

Merge branch 'version-10.0.0-dev' of github.com:demolaf/FirebaseUI-An…
4c9cc5e
…droid into feat/C1

Lyokone merged commit ed436cf into firebase:version-10.0.0-devSep 19, 2025
2 checks passed

demolaf mentioned this pull request Oct 2, 2025
release: internal release candidate (2025-10-02) #2232
Closed

demolaf mentioned this pull request Nov 26, 2025
release: internal release candidate (2025-10-02) #2275
Merged

demolaf marked this pull request as draft September 15, 2025 14:16

demolaf marked this pull request as ready for review September 15, 2025 14:17

demolaf added 2 commits September 15, 2025 15:59

feat(AuthUIConfiguration): implement configuration model, DSL builder…
a62097d
… and tests

Merge branch 'version-10.0.0-dev' ofhttps://github.com/firebase/Fire…
bf7c10b
…baseUI-Android into feat/C1

demolaf force-pushed the feat/C1 branch from e4d1ef3 to bf7c10bCompare September 15, 2025 15:01

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 11:13

refactor: use OAuthProvider base class for common properties
2c563bd

feat: add Provider enum class for provider ids
1ba20ae

feat: setup default provider styles for each provider
63c8e18

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 21:01

test: added builder validation logic from old auth library and tests
a5a944a

refactor: changes in API design docs
19787df
replaced sealed with abstract class, data with regular class use isXX prefix for booleans

test: fix AuthUIConfiguration constructor test
7e010e4

Lyokone approved these changes Sep 18, 2025
View reviewed changes

Merge branch 'version-10.0.0-dev' of github.com:demolaf/FirebaseUI-An…
4c9cc5e
…droid into feat/C1

Lyokone merged commit ed436cf into firebase:version-10.0.0-devSep 19, 2025
2 checks passed

demolaf mentioned this pull request Oct 2, 2025
release: internal release candidate (2025-10-02) #2232
Closed

demolaf mentioned this pull request Nov 26, 2025
release: internal release candidate (2025-10-02) #2275
Merged

demolaf marked this pull request as draft September 15, 2025 14:16

demolaf marked this pull request as ready for review September 15, 2025 14:17

demolaf added 2 commits September 15, 2025 15:59

feat(AuthUIConfiguration): implement configuration model, DSL builder…
a62097d
… and tests

Merge branch 'version-10.0.0-dev' ofhttps://github.com/firebase/Fire…
bf7c10b
…baseUI-Android into feat/C1

demolaf force-pushed the feat/C1 branch from e4d1ef3 to bf7c10bCompare September 15, 2025 15:01

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 11:13

refactor: use OAuthProvider base class for common properties
2c563bd

feat: add Provider enum class for provider ids
1ba20ae

feat: setup default provider styles for each provider
63c8e18

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 21:01

test: added builder validation logic from old auth library and tests
a5a944a

refactor: changes in API design docs
19787df
replaced sealed with abstract class, data with regular class use isXX prefix for booleans

test: fix AuthUIConfiguration constructor test
7e010e4

Lyokone approved these changes Sep 18, 2025
View reviewed changes

Merge branch 'version-10.0.0-dev' of github.com:demolaf/FirebaseUI-An…
4c9cc5e
…droid into feat/C1

Lyokone merged commit ed436cf into firebase:version-10.0.0-devSep 19, 2025
2 checks passed

demolaf mentioned this pull request Oct 2, 2025
release: internal release candidate (2025-10-02) #2232
Closed

demolaf mentioned this pull request Nov 26, 2025
release: internal release candidate (2025-10-02) #2275
Merged

demolaf marked this pull request as draft September 15, 2025 14:16

demolaf marked this pull request as ready for review September 15, 2025 14:17

demolaf added 2 commits September 15, 2025 15:59

feat(AuthUIConfiguration): implement configuration model, DSL builder…
a62097d
… and tests

Merge branch 'version-10.0.0-dev' ofhttps://github.com/firebase/Fire…
bf7c10b
…baseUI-Android into feat/C1

demolaf force-pushed the feat/C1 branch from e4d1ef3 to bf7c10bCompare September 15, 2025 15:01

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 11:13

refactor: use OAuthProvider base class for common properties
2c563bd

feat: add Provider enum class for provider ids
1ba20ae

feat: setup default provider styles for each provider
63c8e18

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 21:01

test: added builder validation logic from old auth library and tests
a5a944a

refactor: changes in API design docs
19787df
replaced sealed with abstract class, data with regular class use isXX prefix for booleans

test: fix AuthUIConfiguration constructor test
7e010e4

Lyokone approved these changes Sep 18, 2025
View reviewed changes

Merge branch 'version-10.0.0-dev' of github.com:demolaf/FirebaseUI-An…
4c9cc5e
…droid into feat/C1

Lyokone merged commit ed436cf into firebase:version-10.0.0-devSep 19, 2025
2 checks passed

demolaf mentioned this pull request Oct 2, 2025
release: internal release candidate (2025-10-02) #2232
Closed

demolaf mentioned this pull request Nov 26, 2025
release: internal release candidate (2025-10-02) #2275
Merged

demolaf marked this pull request as draft September 15, 2025 14:16

demolaf marked this pull request as ready for review September 15, 2025 14:17

demolaf added 2 commits September 15, 2025 15:59

feat(AuthUIConfiguration): implement configuration model, DSL builder…
a62097d
… and tests

Merge branch 'version-10.0.0-dev' ofhttps://github.com/firebase/Fire…
bf7c10b
…baseUI-Android into feat/C1

demolaf force-pushed the feat/C1 branch from e4d1ef3 to bf7c10bCompare September 15, 2025 15:01

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 11:13

refactor: use OAuthProvider base class for common properties
2c563bd

feat: add Provider enum class for provider ids
1ba20ae

feat: setup default provider styles for each provider
63c8e18

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 21:01

test: added builder validation logic from old auth library and tests
a5a944a

refactor: changes in API design docs
19787df
replaced sealed with abstract class, data with regular class use isXX prefix for booleans

test: fix AuthUIConfiguration constructor test
7e010e4

Lyokone approved these changes Sep 18, 2025
View reviewed changes

Merge branch 'version-10.0.0-dev' of github.com:demolaf/FirebaseUI-An…
4c9cc5e
…droid into feat/C1

Lyokone merged commit ed436cf into firebase:version-10.0.0-devSep 19, 2025
2 checks passed

demolaf mentioned this pull request Oct 2, 2025
release: internal release candidate (2025-10-02) #2232
Closed

demolaf mentioned this pull request Nov 26, 2025
release: internal release candidate (2025-10-02) #2275
Merged

demolaf marked this pull request as draft September 15, 2025 14:16

demolaf marked this pull request as ready for review September 15, 2025 14:17

demolaf added 2 commits September 15, 2025 15:59

feat(AuthUIConfiguration): implement configuration model, DSL builder…
a62097d
… and tests

Merge branch 'version-10.0.0-dev' ofhttps://github.com/firebase/Fire…
bf7c10b
…baseUI-Android into feat/C1

demolaf force-pushed the feat/C1 branch from e4d1ef3 to bf7c10bCompare September 15, 2025 15:01

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 11:13

refactor: use OAuthProvider base class for common properties
2c563bd

feat: add Provider enum class for provider ids
1ba20ae

feat: setup default provider styles for each provider
63c8e18

Lyokone reviewed Sep 16, 2025
View reviewed changes

demolaf added 3 commits September 16, 2025 21:01

test: added builder validation logic from old auth library and tests
a5a944a

refactor: changes in API design docs
19787df
replaced sealed with abstract class, data with regular class use isXX prefix for booleans

test: fix AuthUIConfiguration constructor test
7e010e4

Lyokone approved these changes Sep 18, 2025
View reviewed changes

Merge branch 'version-10.0.0-dev' of github.com:demolaf/FirebaseUI-An…
4c9cc5e
…droid into feat/C1

Lyokone merged commit ed436cf into firebase:version-10.0.0-devSep 19, 2025
2 checks passed

demolaf mentioned this pull request Oct 2, 2025
release: internal release candidate (2025-10-02) #2232
Closed

demolaf mentioned this pull request Nov 26, 2025
release: internal release candidate (2025-10-02) #2275
Merged

Uh oh!

Conversation

demolaf commented Sep 15, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

demolaf commented Sep 15, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

demolaf commented Sep 15, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment