fix(auth): validate display name only when required in sign-up form by demolaf · Pull Request #2383 · firebase/FirebaseUI-Android

demolaf · 2026-07-10T12:24:33Z

SignUpUI's isFormValid always validated displayName, even when AuthProvider.Email.isDisplayNameRequired = false and the field is hidden. Since the hidden field's value stays "", GeneralFieldValidator always treated it as a missing required field, so the sign-up button could never become enabled.

Now the display name check is skipped when isDisplayNameRequired is false.

Added SignUpUITest covering this case (name field hidden, other fields valid, sign-up button enabled) — verified it fails on the old code and passes with the fix.

gemini-code-assist

Code Review

This pull request updates the form validation logic in SignUpUI to ensure the form is considered valid when the display name is not required, even if it is left empty. It also introduces a new unit test class SignUpUITest to verify this behavior. The review feedback suggests improving the robustness of the new test by combining text and click action matchers to locate the sign-up button, preventing potential AmbiguousNodeException errors in certain locales.

…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

…2404) * fix(auth): validate display name only when required in sign-up form (#2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test * fix(internal): append CHAR_LIMIT to translation descriptions in export script (#2417) Fixes#1613 * fix(auth): mitigate tapjacking on the auth activity window (#2416) Fixes#2041 * sample(app): add Firestore, Database & Storage demos to sample app (#2406) * fix(auth): allow customizing top app bar colors via AuthUITheme (#2391) * fix(auth): handle edge-to-edge insets in MFA challenge and auth screens (#2413) * fix(auth): use fixed padding for method picker provider buttons (#2424) (#2426) * fix(firestore): catch InterruptedException in FirestorePagingSource * fix(firestore): drop load error logging and restore rx error handler in test * fix(firestore): return LoadResult.Error for every load failure instead of throwing * fix(firestore): fix PageKey.equals NPE on null snapshots and add hashCode * test(firestore): run paging source test in CI via robolectric and replace sleeps with latches * fix(firestore): log genuine load failures while keeping cancellations silent --------- Co-authored-by: Oluwatobi Shokunbi <ayoshokz@gmail.com>

demolaf · 2026-07-10T12:24:33Z

Fixes#2381

SignUpUI's isFormValid always validated displayName, even when AuthProvider.Email.isDisplayNameRequired = false and the field is hidden. Since the hidden field's value stays "", GeneralFieldValidator always treated it as a missing required field, so the sign-up button could never become enabled.

Now the display name check is skipped when isDisplayNameRequired is false.

Added SignUpUITest covering this case (name field hidden, other fields valid, sign-up button enabled) — verified it fails on the old code and passes with the fix.

gemini-code-assist

Code Review

This pull request updates the form validation logic in SignUpUI to ensure the form is considered valid when the display name is not required, even if it is left empty. It also introduces a new unit test class SignUpUITest to verify this behavior. The review feedback suggests improving the robustness of the new test by combining text and click action matchers to locate the sign-up button, preventing potential AmbiguousNodeException errors in certain locales.

…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

…2404) * fix(auth): validate display name only when required in sign-up form (#2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test * fix(internal): append CHAR_LIMIT to translation descriptions in export script (#2417) Fixes#1613 * fix(auth): mitigate tapjacking on the auth activity window (#2416) Fixes#2041 * sample(app): add Firestore, Database & Storage demos to sample app (#2406) * fix(auth): allow customizing top app bar colors via AuthUITheme (#2391) * fix(auth): handle edge-to-edge insets in MFA challenge and auth screens (#2413) * fix(auth): use fixed padding for method picker provider buttons (#2424) (#2426) * fix(firestore): catch InterruptedException in FirestorePagingSource * fix(firestore): drop load error logging and restore rx error handler in test * fix(firestore): return LoadResult.Error for every load failure instead of throwing * fix(firestore): fix PageKey.equals NPE on null snapshots and add hashCode * test(firestore): run paging source test in CI via robolectric and replace sleeps with latches * fix(firestore): log genuine load failures while keeping cancellations silent --------- Co-authored-by: Oluwatobi Shokunbi <ayoshokz@gmail.com>

demolaf · 2026-07-10T12:24:33Z

Fixes#2381

SignUpUI's isFormValid always validated displayName, even when AuthProvider.Email.isDisplayNameRequired = false and the field is hidden. Since the hidden field's value stays "", GeneralFieldValidator always treated it as a missing required field, so the sign-up button could never become enabled.

Now the display name check is skipped when isDisplayNameRequired is false.

Added SignUpUITest covering this case (name field hidden, other fields valid, sign-up button enabled) — verified it fails on the old code and passes with the fix.

gemini-code-assist

Code Review

This pull request updates the form validation logic in SignUpUI to ensure the form is considered valid when the display name is not required, even if it is left empty. It also introduces a new unit test class SignUpUITest to verify this behavior. The review feedback suggests improving the robustness of the new test by combining text and click action matchers to locate the sign-up button, preventing potential AmbiguousNodeException errors in certain locales.

…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

…2404) * fix(auth): validate display name only when required in sign-up form (#2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test * fix(internal): append CHAR_LIMIT to translation descriptions in export script (#2417) Fixes#1613 * fix(auth): mitigate tapjacking on the auth activity window (#2416) Fixes#2041 * sample(app): add Firestore, Database & Storage demos to sample app (#2406) * fix(auth): allow customizing top app bar colors via AuthUITheme (#2391) * fix(auth): handle edge-to-edge insets in MFA challenge and auth screens (#2413) * fix(auth): use fixed padding for method picker provider buttons (#2424) (#2426) * fix(firestore): catch InterruptedException in FirestorePagingSource * fix(firestore): drop load error logging and restore rx error handler in test * fix(firestore): return LoadResult.Error for every load failure instead of throwing * fix(firestore): fix PageKey.equals NPE on null snapshots and add hashCode * test(firestore): run paging source test in CI via robolectric and replace sleeps with latches * fix(firestore): log genuine load failures while keeping cancellations silent --------- Co-authored-by: Oluwatobi Shokunbi <ayoshokz@gmail.com>

demolaf · 2026-07-10T12:24:33Z

Fixes#2381

SignUpUI's isFormValid always validated displayName, even when AuthProvider.Email.isDisplayNameRequired = false and the field is hidden. Since the hidden field's value stays "", GeneralFieldValidator always treated it as a missing required field, so the sign-up button could never become enabled.

Now the display name check is skipped when isDisplayNameRequired is false.

Added SignUpUITest covering this case (name field hidden, other fields valid, sign-up button enabled) — verified it fails on the old code and passes with the fix.

gemini-code-assist

Code Review

This pull request updates the form validation logic in SignUpUI to ensure the form is considered valid when the display name is not required, even if it is left empty. It also introduces a new unit test class SignUpUITest to verify this behavior. The review feedback suggests improving the robustness of the new test by combining text and click action matchers to locate the sign-up button, preventing potential AmbiguousNodeException errors in certain locales.

…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

…2404) * fix(auth): validate display name only when required in sign-up form (#2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test * fix(internal): append CHAR_LIMIT to translation descriptions in export script (#2417) Fixes#1613 * fix(auth): mitigate tapjacking on the auth activity window (#2416) Fixes#2041 * sample(app): add Firestore, Database & Storage demos to sample app (#2406) * fix(auth): allow customizing top app bar colors via AuthUITheme (#2391) * fix(auth): handle edge-to-edge insets in MFA challenge and auth screens (#2413) * fix(auth): use fixed padding for method picker provider buttons (#2424) (#2426) * fix(firestore): catch InterruptedException in FirestorePagingSource * fix(firestore): drop load error logging and restore rx error handler in test * fix(firestore): return LoadResult.Error for every load failure instead of throwing * fix(firestore): fix PageKey.equals NPE on null snapshots and add hashCode * test(firestore): run paging source test in CI via robolectric and replace sleeps with latches * fix(firestore): log genuine load failures while keeping cancellations silent --------- Co-authored-by: Oluwatobi Shokunbi <ayoshokz@gmail.com>

demolaf · 2026-07-10T12:24:33Z

Fixes#2381

SignUpUI's isFormValid always validated displayName, even when AuthProvider.Email.isDisplayNameRequired = false and the field is hidden. Since the hidden field's value stays "", GeneralFieldValidator always treated it as a missing required field, so the sign-up button could never become enabled.

Now the display name check is skipped when isDisplayNameRequired is false.

Added SignUpUITest covering this case (name field hidden, other fields valid, sign-up button enabled) — verified it fails on the old code and passes with the fix.

gemini-code-assist

Code Review

This pull request updates the form validation logic in SignUpUI to ensure the form is considered valid when the display name is not required, even if it is left empty. It also introduces a new unit test class SignUpUITest to verify this behavior. The review feedback suggests improving the robustness of the new test by combining text and click action matchers to locate the sign-up button, preventing potential AmbiguousNodeException errors in certain locales.

…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

…2404) * fix(auth): validate display name only when required in sign-up form (#2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test * fix(internal): append CHAR_LIMIT to translation descriptions in export script (#2417) Fixes#1613 * fix(auth): mitigate tapjacking on the auth activity window (#2416) Fixes#2041 * sample(app): add Firestore, Database & Storage demos to sample app (#2406) * fix(auth): allow customizing top app bar colors via AuthUITheme (#2391) * fix(auth): handle edge-to-edge insets in MFA challenge and auth screens (#2413) * fix(auth): use fixed padding for method picker provider buttons (#2424) (#2426) * fix(firestore): catch InterruptedException in FirestorePagingSource * fix(firestore): drop load error logging and restore rx error handler in test * fix(firestore): return LoadResult.Error for every load failure instead of throwing * fix(firestore): fix PageKey.equals NPE on null snapshots and add hashCode * test(firestore): run paging source test in CI via robolectric and replace sleeps with latches * fix(firestore): log genuine load failures while keeping cancellations silent --------- Co-authored-by: Oluwatobi Shokunbi <ayoshokz@gmail.com>

demolaf · 2026-07-10T12:24:33Z

Fixes#2381

SignUpUI's isFormValid always validated displayName, even when AuthProvider.Email.isDisplayNameRequired = false and the field is hidden. Since the hidden field's value stays "", GeneralFieldValidator always treated it as a missing required field, so the sign-up button could never become enabled.

Now the display name check is skipped when isDisplayNameRequired is false.

Added SignUpUITest covering this case (name field hidden, other fields valid, sign-up button enabled) — verified it fails on the old code and passes with the fix.

gemini-code-assist

Code Review

This pull request updates the form validation logic in SignUpUI to ensure the form is considered valid when the display name is not required, even if it is left empty. It also introduces a new unit test class SignUpUITest to verify this behavior. The review feedback suggests improving the robustness of the new test by combining text and click action matchers to locate the sign-up button, preventing potential AmbiguousNodeException errors in certain locales.

…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

…2404) * fix(auth): validate display name only when required in sign-up form (#2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test * fix(internal): append CHAR_LIMIT to translation descriptions in export script (#2417) Fixes#1613 * fix(auth): mitigate tapjacking on the auth activity window (#2416) Fixes#2041 * sample(app): add Firestore, Database & Storage demos to sample app (#2406) * fix(auth): allow customizing top app bar colors via AuthUITheme (#2391) * fix(auth): handle edge-to-edge insets in MFA challenge and auth screens (#2413) * fix(auth): use fixed padding for method picker provider buttons (#2424) (#2426) * fix(firestore): catch InterruptedException in FirestorePagingSource * fix(firestore): drop load error logging and restore rx error handler in test * fix(firestore): return LoadResult.Error for every load failure instead of throwing * fix(firestore): fix PageKey.equals NPE on null snapshots and add hashCode * test(firestore): run paging source test in CI via robolectric and replace sleeps with latches * fix(firestore): log genuine load failures while keeping cancellations silent --------- Co-authored-by: Oluwatobi Shokunbi <ayoshokz@gmail.com>

demolaf · 2026-07-10T12:24:33Z

Fixes#2381

SignUpUI's isFormValid always validated displayName, even when AuthProvider.Email.isDisplayNameRequired = false and the field is hidden. Since the hidden field's value stays "", GeneralFieldValidator always treated it as a missing required field, so the sign-up button could never become enabled.

Now the display name check is skipped when isDisplayNameRequired is false.

Added SignUpUITest covering this case (name field hidden, other fields valid, sign-up button enabled) — verified it fails on the old code and passes with the fix.

gemini-code-assist

Code Review

This pull request updates the form validation logic in SignUpUI to ensure the form is considered valid when the display name is not required, even if it is left empty. It also introduces a new unit test class SignUpUITest to verify this behavior. The review feedback suggests improving the robustness of the new test by combining text and click action matchers to locate the sign-up button, preventing potential AmbiguousNodeException errors in certain locales.

…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

…2404) * fix(auth): validate display name only when required in sign-up form (#2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test * fix(internal): append CHAR_LIMIT to translation descriptions in export script (#2417) Fixes#1613 * fix(auth): mitigate tapjacking on the auth activity window (#2416) Fixes#2041 * sample(app): add Firestore, Database & Storage demos to sample app (#2406) * fix(auth): allow customizing top app bar colors via AuthUITheme (#2391) * fix(auth): handle edge-to-edge insets in MFA challenge and auth screens (#2413) * fix(auth): use fixed padding for method picker provider buttons (#2424) (#2426) * fix(firestore): catch InterruptedException in FirestorePagingSource * fix(firestore): drop load error logging and restore rx error handler in test * fix(firestore): return LoadResult.Error for every load failure instead of throwing * fix(firestore): fix PageKey.equals NPE on null snapshots and add hashCode * test(firestore): run paging source test in CI via robolectric and replace sleeps with latches * fix(firestore): log genuine load failures while keeping cancellations silent --------- Co-authored-by: Oluwatobi Shokunbi <ayoshokz@gmail.com>

demolaf · 2026-07-10T12:24:33Z

Fixes#2381

SignUpUI's isFormValid always validated displayName, even when AuthProvider.Email.isDisplayNameRequired = false and the field is hidden. Since the hidden field's value stays "", GeneralFieldValidator always treated it as a missing required field, so the sign-up button could never become enabled.

Now the display name check is skipped when isDisplayNameRequired is false.

Added SignUpUITest covering this case (name field hidden, other fields valid, sign-up button enabled) — verified it fails on the old code and passes with the fix.

gemini-code-assist

Code Review

This pull request updates the form validation logic in SignUpUI to ensure the form is considered valid when the display name is not required, even if it is left empty. It also introduces a new unit test class SignUpUITest to verify this behavior. The review feedback suggests improving the robustness of the new test by combining text and click action matchers to locate the sign-up button, preventing potential AmbiguousNodeException errors in certain locales.

…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

…2404) * fix(auth): validate display name only when required in sign-up form (#2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test * fix(internal): append CHAR_LIMIT to translation descriptions in export script (#2417) Fixes#1613 * fix(auth): mitigate tapjacking on the auth activity window (#2416) Fixes#2041 * sample(app): add Firestore, Database & Storage demos to sample app (#2406) * fix(auth): allow customizing top app bar colors via AuthUITheme (#2391) * fix(auth): handle edge-to-edge insets in MFA challenge and auth screens (#2413) * fix(auth): use fixed padding for method picker provider buttons (#2424) (#2426) * fix(firestore): catch InterruptedException in FirestorePagingSource * fix(firestore): drop load error logging and restore rx error handler in test * fix(firestore): return LoadResult.Error for every load failure instead of throwing * fix(firestore): fix PageKey.equals NPE on null snapshots and add hashCode * test(firestore): run paging source test in CI via robolectric and replace sleeps with latches * fix(firestore): log genuine load failures while keeping cancellations silent --------- Co-authored-by: Oluwatobi Shokunbi <ayoshokz@gmail.com>

fix(auth): validate display name only when required in sign-up form
e1b37a5

github-project-automationBot added this to studio-2394994192-60a69 Jul 10, 2026

github-project-automationBot moved this to Backlog in studio-2394994192-60a69 Jul 10, 2026

demolaf changed the base branch from master to version-10.0.0-beta04July 10, 2026 12:25

gemini-code-assistBot reviewed Jul 10, 2026
View reviewed changes

Comment threadauth/src/test/java/com/firebase/ui/auth/ui/screens/email/SignUpUITest.kt
Comment threadauth/src/test/java/com/firebase/ui/auth/ui/screens/email/SignUpUITest.kt Outdated

fix(auth): use locale-safe matcher for sign-up button in test
fa39b12

demolaf requested a review from russellwheatley July 10, 2026 13:13

demolaf mentioned this pull request Jul 10, 2026
[Auth-UI] [v10.0.0-beta03] In AuthProvider.Email the signup form never becomes valid #2381
Closed

russellwheatley approved these changes Jul 10, 2026
View reviewed changes

demolaf merged commit 86c34ff into version-10.0.0-beta04Jul 10, 2026
9 checks passed

github-project-automationBot moved this from Backlog to Done in studio-2394994192-60a69 Jul 10, 2026

demolaf deleted the fix/signup-form-validity branch July 10, 2026 13:53

demolaf added a commit that referenced this pull request Jul 15, 2026
fix(auth): validate display name only when required in sign-up form (#…
84a8b5d
…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

demolaf added a commit that referenced this pull request Jul 17, 2026
fix(auth): validate display name only when required in sign-up form (#…
d382bd5
…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test

demolaf added a commit that referenced this pull request Jul 22, 2026
fix(auth): validate display name only when required in sign-up form (#…
1ecd498
…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test