Uh oh!
There was an error while loading. Please reload this page.
docs(auth): update Screen Transitions samples to the Navigation 3 AuthUITransitions - #2475
Open
demolaf wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the auth/README.md documentation to reflect changes in screen transitions, moving from individual enter/exit transitions to unified transition specs using togetherWith. It also adds documentation for per-destination animations and updates notes on default transitions. Feedback is provided regarding an inconsistency in the vertical slide transition example, where the exit animation direction contradicts the accompanying comment.
Uh oh!
There was an error while loading. Please reload this page.
demolaf
marked this pull request as ready for review
September 4, 2026 12:36
demolafforce-pushed
the
fix/nav3-readme-transition-samples
branch
from
September 4, 2026 12:54
48aee3c to
65e890bComparedemolaf
changed the base branch from
version-10.0.0-beta05
to
feat/reauth-and-recovery-test-coverageSeptember 4, 2026 12:54
demolaf
marked this pull request as draft
September 4, 2026 12:54
demolaf
marked this pull request as ready for review
September 4, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Screen Transitions samples still use the Navigation 2 constructor —
enterTransition/exitTransition/popEnterTransition/popExitTransition— which no longer exists, so none of the four compile.AuthUITransitionsnow takes oneContentTransformper direction:transitionSpec,popTransitionSpecandpredictivePopTransitionSpec.Rewrites the four samples against the new constructor, pairing each enter/exit with
togetherWith, and adds a per-destination sample using the publicScene<NavKey>.authRoute(). The closing note now says each spec falls back to the default 700ms cross-fade independently —predictivePopTransitionSpecdoes not fall back topopTransitionSpec, and it fires when the gesture starts rather than when a back completes.Compiled all five samples verbatim against the module to check they build.
Maintainer note: Fixes internal CPRN-404