fix(auth): clear leftover MFA enrollment state after #2473's reset-on-entry

[demolaf]

• Related to fix(auth): clear MFA enrollment flow state on every entry #2473
• Related to feat(auth): make each MFA enrollment step a real navigation destination #2467

#2473 clears MfaEnrollmentFlowState on entry to the flow. Two paths do not reach an entry.

Un-hosted MfaEnrollmentScreen. Driven without a host it owns its step and remembers its own
flow state, which nothing outside it can reset. onComplete() cleared only error and
lastException, so a caller that stays composed goes on showing VerifyFactor with the enrolled
number and code. It now resets and returns to its start step — the single allowed factor's
configure step, or the picker. Hosted is untouched. This flips two existing assertions that pinned
"does not navigate away on success", which is the behaviour being changed.

Entry from inside the flow. Both host call sites live on the success destination, which stays
composed while the push runs, so a second tap could reset the enrolment in progress rather than the
previous one. enterMfaEnrollment is now a no-op when a step of the flow is already on the stack,
which also enforces the pushUnique invariant that was previously only asserted in a comment.

Adds 5 tests: the un-hosted reset on both the single-factor and picker starts, re-entry from inside
the flow through both host call sites, and sign-out → second user. Each was verified to fail with
the product change reverted.

---

Maintainer note: Fixes internal CPRN-405

[gemini-code-assist]

Code Review

This pull request prevents state resets and duplicate entries when navigating within the MFA enrollment flow, particularly addressing issues with second taps and un-hosted screens. It introduces a guard to prevent re-entry when a flow step is already on the stack, resets the flow state on completion for un-hosted screens, and adds comprehensive tests covering these scenarios. The reviewer suggests reusing the existing mfaEnrollmentStartStep function in unhostedStartStep to reduce code duplication and improve maintainability.

[demolaf]

• Related to fix(auth): clear MFA enrollment flow state on every entry #2473
• Related to feat(auth): make each MFA enrollment step a real navigation destination #2467

#2473 clears MfaEnrollmentFlowState on entry to the flow. Two paths do not reach an entry.

Un-hosted MfaEnrollmentScreen. Driven without a host it owns its step and remembers its own
flow state, which nothing outside it can reset. onComplete() cleared only error and
lastException, so a caller that stays composed goes on showing VerifyFactor with the enrolled
number and code. It now resets and returns to its start step — the single allowed factor's
configure step, or the picker. Hosted is untouched. This flips two existing assertions that pinned
"does not navigate away on success", which is the behaviour being changed.

Entry from inside the flow. Both host call sites live on the success destination, which stays
composed while the push runs, so a second tap could reset the enrolment in progress rather than the
previous one. enterMfaEnrollment is now a no-op when a step of the flow is already on the stack,
which also enforces the pushUnique invariant that was previously only asserted in a comment.

Adds 5 tests: the un-hosted reset on both the single-factor and picker starts, re-entry from inside
the flow through both host call sites, and sign-out → second user. Each was verified to fail with
the product change reverted.

---

Maintainer note: Fixes internal CPRN-405

[gemini-code-assist]

Code Review

This pull request prevents state resets and duplicate entries when navigating within the MFA enrollment flow, particularly addressing issues with second taps and un-hosted screens. It introduces a guard to prevent re-entry when a flow step is already on the stack, resets the flow state on completion for un-hosted screens, and adds comprehensive tests covering these scenarios. The reviewer suggests reusing the existing mfaEnrollmentStartStep function in unhostedStartStep to reduce code duplication and improve maintainability.

[demolaf]

• Related to fix(auth): clear MFA enrollment flow state on every entry #2473
• Related to feat(auth): make each MFA enrollment step a real navigation destination #2467

#2473 clears MfaEnrollmentFlowState on entry to the flow. Two paths do not reach an entry.

Un-hosted MfaEnrollmentScreen. Driven without a host it owns its step and remembers its own
flow state, which nothing outside it can reset. onComplete() cleared only error and
lastException, so a caller that stays composed goes on showing VerifyFactor with the enrolled
number and code. It now resets and returns to its start step — the single allowed factor's
configure step, or the picker. Hosted is untouched. This flips two existing assertions that pinned
"does not navigate away on success", which is the behaviour being changed.

Entry from inside the flow. Both host call sites live on the success destination, which stays
composed while the push runs, so a second tap could reset the enrolment in progress rather than the
previous one. enterMfaEnrollment is now a no-op when a step of the flow is already on the stack,
which also enforces the pushUnique invariant that was previously only asserted in a comment.

Adds 5 tests: the un-hosted reset on both the single-factor and picker starts, re-entry from inside
the flow through both host call sites, and sign-out → second user. Each was verified to fail with
the product change reverted.

---

Maintainer note: Fixes internal CPRN-405

[gemini-code-assist]

Code Review

This pull request prevents state resets and duplicate entries when navigating within the MFA enrollment flow, particularly addressing issues with second taps and un-hosted screens. It introduces a guard to prevent re-entry when a flow step is already on the stack, resets the flow state on completion for un-hosted screens, and adds comprehensive tests covering these scenarios. The reviewer suggests reusing the existing mfaEnrollmentStartStep function in unhostedStartStep to reduce code duplication and improve maintainability.

[demolaf]

• Related to fix(auth): clear MFA enrollment flow state on every entry #2473
• Related to feat(auth): make each MFA enrollment step a real navigation destination #2467

#2473 clears MfaEnrollmentFlowState on entry to the flow. Two paths do not reach an entry.

Un-hosted MfaEnrollmentScreen. Driven without a host it owns its step and remembers its own
flow state, which nothing outside it can reset. onComplete() cleared only error and
lastException, so a caller that stays composed goes on showing VerifyFactor with the enrolled
number and code. It now resets and returns to its start step — the single allowed factor's
configure step, or the picker. Hosted is untouched. This flips two existing assertions that pinned
"does not navigate away on success", which is the behaviour being changed.

Entry from inside the flow. Both host call sites live on the success destination, which stays
composed while the push runs, so a second tap could reset the enrolment in progress rather than the
previous one. enterMfaEnrollment is now a no-op when a step of the flow is already on the stack,
which also enforces the pushUnique invariant that was previously only asserted in a comment.

Adds 5 tests: the un-hosted reset on both the single-factor and picker starts, re-entry from inside
the flow through both host call sites, and sign-out → second user. Each was verified to fail with
the product change reverted.

---

Maintainer note: Fixes internal CPRN-405

[gemini-code-assist]

Code Review

This pull request prevents state resets and duplicate entries when navigating within the MFA enrollment flow, particularly addressing issues with second taps and un-hosted screens. It introduces a guard to prevent re-entry when a flow step is already on the stack, resets the flow state on completion for un-hosted screens, and adds comprehensive tests covering these scenarios. The reviewer suggests reusing the existing mfaEnrollmentStartStep function in unhostedStartStep to reduce code duplication and improve maintainability.

[demolaf]

• Related to fix(auth): clear MFA enrollment flow state on every entry #2473
• Related to feat(auth): make each MFA enrollment step a real navigation destination #2467

#2473 clears MfaEnrollmentFlowState on entry to the flow. Two paths do not reach an entry.

Un-hosted MfaEnrollmentScreen. Driven without a host it owns its step and remembers its own
flow state, which nothing outside it can reset. onComplete() cleared only error and
lastException, so a caller that stays composed goes on showing VerifyFactor with the enrolled
number and code. It now resets and returns to its start step — the single allowed factor's
configure step, or the picker. Hosted is untouched. This flips two existing assertions that pinned
"does not navigate away on success", which is the behaviour being changed.

Entry from inside the flow. Both host call sites live on the success destination, which stays
composed while the push runs, so a second tap could reset the enrolment in progress rather than the
previous one. enterMfaEnrollment is now a no-op when a step of the flow is already on the stack,
which also enforces the pushUnique invariant that was previously only asserted in a comment.

Adds 5 tests: the un-hosted reset on both the single-factor and picker starts, re-entry from inside
the flow through both host call sites, and sign-out → second user. Each was verified to fail with
the product change reverted.

---

Maintainer note: Fixes internal CPRN-405

[gemini-code-assist]

Code Review

This pull request prevents state resets and duplicate entries when navigating within the MFA enrollment flow, particularly addressing issues with second taps and un-hosted screens. It introduces a guard to prevent re-entry when a flow step is already on the stack, resets the flow state on completion for un-hosted screens, and adds comprehensive tests covering these scenarios. The reviewer suggests reusing the existing mfaEnrollmentStartStep function in unhostedStartStep to reduce code duplication and improve maintainability.

[demolaf]

• Related to fix(auth): clear MFA enrollment flow state on every entry #2473
• Related to feat(auth): make each MFA enrollment step a real navigation destination #2467

#2473 clears MfaEnrollmentFlowState on entry to the flow. Two paths do not reach an entry.

Un-hosted MfaEnrollmentScreen. Driven without a host it owns its step and remembers its own
flow state, which nothing outside it can reset. onComplete() cleared only error and
lastException, so a caller that stays composed goes on showing VerifyFactor with the enrolled
number and code. It now resets and returns to its start step — the single allowed factor's
configure step, or the picker. Hosted is untouched. This flips two existing assertions that pinned
"does not navigate away on success", which is the behaviour being changed.

Entry from inside the flow. Both host call sites live on the success destination, which stays
composed while the push runs, so a second tap could reset the enrolment in progress rather than the
previous one. enterMfaEnrollment is now a no-op when a step of the flow is already on the stack,
which also enforces the pushUnique invariant that was previously only asserted in a comment.

Adds 5 tests: the un-hosted reset on both the single-factor and picker starts, re-entry from inside
the flow through both host call sites, and sign-out → second user. Each was verified to fail with
the product change reverted.

---

Maintainer note: Fixes internal CPRN-405

[gemini-code-assist]

Code Review

This pull request prevents state resets and duplicate entries when navigating within the MFA enrollment flow, particularly addressing issues with second taps and un-hosted screens. It introduces a guard to prevent re-entry when a flow step is already on the stack, resets the flow state on completion for un-hosted screens, and adds comprehensive tests covering these scenarios. The reviewer suggests reusing the existing mfaEnrollmentStartStep function in unhostedStartStep to reduce code duplication and improve maintainability.

[demolaf]

• Related to fix(auth): clear MFA enrollment flow state on every entry #2473
• Related to feat(auth): make each MFA enrollment step a real navigation destination #2467

#2473 clears MfaEnrollmentFlowState on entry to the flow. Two paths do not reach an entry.

Un-hosted MfaEnrollmentScreen. Driven without a host it owns its step and remembers its own
flow state, which nothing outside it can reset. onComplete() cleared only error and
lastException, so a caller that stays composed goes on showing VerifyFactor with the enrolled
number and code. It now resets and returns to its start step — the single allowed factor's
configure step, or the picker. Hosted is untouched. This flips two existing assertions that pinned
"does not navigate away on success", which is the behaviour being changed.

Entry from inside the flow. Both host call sites live on the success destination, which stays
composed while the push runs, so a second tap could reset the enrolment in progress rather than the
previous one. enterMfaEnrollment is now a no-op when a step of the flow is already on the stack,
which also enforces the pushUnique invariant that was previously only asserted in a comment.

Adds 5 tests: the un-hosted reset on both the single-factor and picker starts, re-entry from inside
the flow through both host call sites, and sign-out → second user. Each was verified to fail with
the product change reverted.

---

Maintainer note: Fixes internal CPRN-405

[gemini-code-assist]

Code Review

This pull request prevents state resets and duplicate entries when navigating within the MFA enrollment flow, particularly addressing issues with second taps and un-hosted screens. It introduces a guard to prevent re-entry when a flow step is already on the stack, resets the flow state on completion for un-hosted screens, and adds comprehensive tests covering these scenarios. The reviewer suggests reusing the existing mfaEnrollmentStartStep function in unhostedStartStep to reduce code duplication and improve maintainability.

[demolaf]

• Related to fix(auth): clear MFA enrollment flow state on every entry #2473
• Related to feat(auth): make each MFA enrollment step a real navigation destination #2467

#2473 clears MfaEnrollmentFlowState on entry to the flow. Two paths do not reach an entry.

Un-hosted MfaEnrollmentScreen. Driven without a host it owns its step and remembers its own
flow state, which nothing outside it can reset. onComplete() cleared only error and
lastException, so a caller that stays composed goes on showing VerifyFactor with the enrolled
number and code. It now resets and returns to its start step — the single allowed factor's
configure step, or the picker. Hosted is untouched. This flips two existing assertions that pinned
"does not navigate away on success", which is the behaviour being changed.

Entry from inside the flow. Both host call sites live on the success destination, which stays
composed while the push runs, so a second tap could reset the enrolment in progress rather than the
previous one. enterMfaEnrollment is now a no-op when a step of the flow is already on the stack,
which also enforces the pushUnique invariant that was previously only asserted in a comment.

Adds 5 tests: the un-hosted reset on both the single-factor and picker starts, re-entry from inside
the flow through both host call sites, and sign-out → second user. Each was verified to fail with
the product change reverted.

---

Maintainer note: Fixes internal CPRN-405

[gemini-code-assist]

Code Review

This pull request prevents state resets and duplicate entries when navigating within the MFA enrollment flow, particularly addressing issues with second taps and un-hosted screens. It introduces a guard to prevent re-entry when a flow step is already on the stack, resets the flow state on completion for un-hosted screens, and adds comprehensive tests covering these scenarios. The reviewer suggests reusing the existing mfaEnrollmentStartStep function in unhostedStartStep to reduce code duplication and improve maintainability.