5.4 regression

[mbrevda]

Describe your environment

• Operating System version: AWS Lambda (node4.3)
• Firebase SDK version: 5.4
• Library version: _____
• Firebase Product: auth, database

Describe the problem

Since 5.4 package.json is read dynamically at run time. When bundling with Browserify, the package.json is not available at the path the code is expecting it to be, and hence an uncaught exception is thrown.

Steps to reproduce:

While I doubt this stack trace is of any use, perhaps the methods names might be recognized by someone:

module initialization error: Error
 at Object.exports.find (/var/task/myTask.js:72900:15)
 at Object.<anonymous> (/var/task/myTask.js:78083:12)
 at Object.62.exports.64.commonGrpc.Service.runTransaction.transaction.begin.then.getAll_.self.readStream.then.Promise._decorateRequest.Promise._retry.resolve.then.then._initializeStream.Promise.request.allowRetries._decorateRequest.then.decorated.readStream.allowRetries.66.67.exports.get.getCollections.create.data.delete.precondition.set.options.update.preconditionOrValues.onSnapshot.onError._get.Promise._stream.queryOptions._firestore.readStream.then.backendStream.68.exports.72.module.exports.validators.73.DOCUMENT_WATCH_COMPARATOR.onSnapshot.changes.74.exports.update.preconditionOrValues.188.236.exports.authorizeRequest.callback.getAuthClient.createAuthClientPromise.getCredentials.callback.getAuthClient.getEnvironment.async.parallel.cb.getProjectId.callback.getToken.callback.303.node-pre-gyp/lib/pre-binding (/var/task/myTask.js:78088:4)
 at s (/var/task/myTask.js:1:691)
 at /var/task/myTask.js:1:742
 at Object.62.exports.64.commonGrpc.Service.runTransaction.transaction.begin.then.getAll_.self.readStream.then.Promise._decorateRequest.Promise._retry.resolve.then.then._initializeStream.Promise.request.allowRetries._decorateRequest.then.decorated.readStream.allowRetries.66.67.exports.get.getCollections.create.data.delete.precondition.set.options.update.preconditionOrValues.onSnapshot.onError._get.Promise._stream.queryOptions._firestore.readStream.then.backendStream.68.exports.72.module.exports.validators.73.DOCUMENT_WATCH_COMPARATOR.onSnapshot.changes.74.exports.update.preconditionOrValues.188.236.exports.authorizeRequest.callback.getAuthClient.createAuthClientPromise.getCredentials.callback.getAuthClient.getEnvironment.async.parallel.cb.getProjectId.callback.getToken.callback.299.../../../package.json (/var/task/myTask.js:76517:12)
 at s (/var/task/myTask.js:1:691)
 at /var/task/myTask.js:1:742
 at Object.<anonymous> (/var/task/myTask.js:76250:14)
 at Object.62.exports.64.commonGrpc.Service.runTransaction.transaction.begin.then.getAll_.self.readStream.then.Promise._decorateRequest.Promise._retry.resolve.then.then._initializeStream.Promise.request.allowRetries._decorateRequest.then.decorated.readStream.allowRetries.66.67.exports.get.getCollections.create.data.delete.precondition.set.options.update.preconditionOrValues.onSnapshot.onError._get.Promise._stream.queryOptions._firestore.readStream.then.backendStream.68.exports.72.module.exports.validators.73.DOCUMENT_WATCH_COMPARATOR.onSnapshot.changes.74.exports.update.preconditionOrValues.188.236.exports.authorizeRequest.callback.getAuthClient.createAuthClientPromise.getCredentials.callback.getAuthClient.getEnvironment.async.parallel.cb.getProjectId.callback.getToken.callback.298../src/client.js (/var/task/myTask.js:76477:4)

Relevant Code:

with 5.3 this works as expected. These are my browserify settings:

var bOpts = _.extend({
 paths: [__dirname + '../'],
 standalone: name,
 builtins: false,
 commondir: false,
 ignoreMissing: true,
 detectGlobals: true,
 debug: true, //enabel sourcemaps
 fullPaths: false,
 browserField: false, // ignore package.json browser field
 insertGlobalVars: {
 process: function () {}
 }
 }, opts)

[google-oss-bot]

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.