Skip to content

Add emulator-based integration tests. - #1155

Merged
yuchenshi merged 9 commits into
masterfrom
ys/integration-emulator
Mar 23, 2021
Merged

Add emulator-based integration tests.#1155
yuchenshi merged 9 commits into
masterfrom
ys/integration-emulator

Conversation

@yuchenshi

Copy link
Copy Markdown
Member

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

This is a follow up to #1148 and enables emulator-based integration tests.

Testing

This covers Firestore and most of Auth and database.

API Changes

N/A

@hiranya911hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuchenshi. Really like how this is turning out. My main point of feedback is about managing the emulator-based integration tests entirely within the Actions workflow, rather than in package.json. That's consistent with how we did this in Python, and keeps the package.json file clean of changes.

Comment thread.github/workflows/ci.yml Outdated
Comment threadpackage.json Outdated
Comment thread.github/workflows/ci.yml
@yuchenshi

Copy link
Copy Markdown
MemberAuthor

Sorry I was OOO and I've now reverted package.json changes as requested.

@hiranya911hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuchenshi. LGTM with a couple of nits. Feel free to merge once the comments are addressed.

Comment thread.github/workflows/ci.yml Outdated
Comment thread.github/workflows/ci.yml Outdated
@yuchenshi

yuchenshi commented Feb 11, 2021

Copy link
Copy Markdown
MemberAuthor

I see one flaky test here and I'll investigate later. Don't merge for now please! https://github.com/firebase/firebase-admin-node/pull/1155/checks?check_run_id=1881208101#step:7:197

It's unclear if it's flaky due to some issue in Auth Emulator or maybe the test itself has race conditions that got worse since Auth Emulator is much faster than prod.

@yuchenshi
yuchenshi merged commit 97d3823 into masterMar 23, 2021
@yuchenshi
yuchenshi deleted the ys/integration-emulator branch March 23, 2021 00:48
@yuchenshi

Copy link
Copy Markdown
MemberAuthor

Merging now since the tests now pass. Feel free to skip that one test for emulators if this comes up again. Let's at least have coverage for the other tests.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yuchenshi@lahirumaramba@hiranya911