feat(fis): Adding the admin.installations() API for deleting Firebase installation IDs

[hiranya911]

• Added the new admin.installations() API.
• Deprecated the existing admin.instanceId() API. The implementation of this API now just invokes the installations API under the hood.
• The admin.instanceId() retains backward compatibility by converting the FirebaseInstallationsError raised by the new implementation to the old FirebaseInstanceIdError type. Error codes are the same, but the error message may defer.

go/firebase-admin-fis

RELEASE NOTE: Added a new admin.installations() API to replace the existing admin.instanceId() API. Developers are advised to migrate to the new API for deleting Firebase instance IDs and installation IDs.

[lahirumaramba]

LGTM. Left one comment.

[egilmorez]

Thanks Hiranya! Some nits and one link to update.

[hiranya911]

Thanks @egilmorez. I've responded to your comments. PTAL.

[egilmorez]

LGTM, thanks Hiranya!

[egilmorez]

Here's a couple of things to look at Hiranya. Thanks!

[egilmorez]

It's possible to add a "status: deprecated" flag here to create this kind of effect:

https://firebase.google.com/docs/reference/android/com/google/firebase/iid/package-summary?hl=en

[hiranya911]

What does that look like in the yaml? Can you point me to an example?

[egilmorez]

"Optional app whose Installations service to

• return." makes sense but isn't 100% grammatical.

"Optional app for which to return the Installations service" is valid but not great.

"Optional app whose Installations service should be

• returned." sounds better, but "should" seems weak.

I'll poll the tech writers and see who has a solution :)