Uh oh!
There was an error while loading. Please reload this page.
chore: Add Mailgun send email action - #1210
Conversation
83f4405 to
83d133cCompareda65665 to
e2f17d3CompareNote: |
e2f17d3 to
fc5f294Compare| }); | ||
| let from = core.getInput('from'); | ||
| const cc = core.getInput('cc'); |
There was a problem hiding this comment.
We probably do not need cc filed. I am open to remove it and keep this action as simple as possible if we need.
hiranya911
left a comment
There was a problem hiding this comment.
Looks pretty good. A few thoughts for improvement.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lahirumaramba
commented
Mar 31, 2021
Thanks, @hiranya911! |
hiranya911
left a comment
There was a problem hiding this comment.
Just a couple of readability nits. And remember to update the binary every time you push a code change.
| function validate(config) { | ||
| for (param in config) { | ||
| if (['cc', 'text', 'html'].includes(param)) { |
There was a problem hiding this comment.
const optionalFields = ['cc', 'text', 'html'];
| } | ||
| } | ||
| function validateParameter(value, name) { |
lahirumaramba
commented
Mar 31, 2021
Thanks @hiranya911! Updated the binary. |
mailgun.jsnpm module.