Skip to content

change: Migrate credentials to use google-auth-library - #2466

Merged
lahirumaramba merged 10 commits into
masterfrom
lm-migrate-cred-stage1
Nov 4, 2024
Merged

change: Migrate credentials to use google-auth-library#2466
lahirumaramba merged 10 commits into
masterfrom
lm-migrate-cred-stage1

Conversation

@lahirumaramba

@lahirumarambalahirumaramba commented Feb 21, 2024•
edited
Loading

Copy link
Copy Markdown
Member
  • Migrate Application default credentials, Service account credentials, Refresh token credentials, and Compute engine credentials to use google-auth-library

Resolves: #1377

This was referenced Feb 28, 2024
Closed
Closed
jonathanedey
jonathanedey reviewed Feb 28, 2024
View reviewed changes

@jonathanedeyjonathanedey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Left one comment.

Comment threadsrc/app/credential-internal.ts
);
return {
...credentials,
access_token: accessToken,

@jonathanedeyjonathanedeyFeb 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to assign access_token here?

@lahirumarambalahirumarambaNov 3, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I am keeping the shape of the internal GoogleOAuthAccessToken type here

@lahirumarambalahirumaramba self-assigned this Feb 29, 2024
@andrewmbentonandrewmbenton mentioned this pull request Mar 19, 2024
Closed
@foxrafa

foxrafa commented May 13, 2024

Copy link
Copy Markdown
Contributor

I submitted a fix for ADC not working for human accounts here #2553

@jenhjenh mentioned this pull request May 28, 2024
Merged
@lahirumarambalahirumaramba mentioned this pull request Jun 18, 2024
Merged
@VitaliAndrushkevich

VitaliAndrushkevich commented Jul 5, 2024

Copy link
Copy Markdown

Could you please provide an update on the status of this PR?
CC: @lahirumaramba

@KemingHe

KemingHe commented Jul 7, 2024

Copy link
Copy Markdown

@lahirumaramba@hsubox76 Hello there, as a firebase admin sdk user, I much look forward to this PR getting through, could you please give us a status update? Thank you.

@swftvsnswftvsn mentioned this pull request Aug 6, 2024
Closed
@lahirumarambalahirumaramba mentioned this pull request Sep 12, 2024
Closed
@lahirumaramba
lahirumaramba marked this pull request as ready for review November 1, 2024 22:01
@lahirumaramba
lahirumaramba marked this pull request as draft November 1, 2024 22:01
@lahirumaramba
lahirumaramba marked this pull request as ready for review November 1, 2024 22:02
@lahirumaramba
lahirumaramba marked this pull request as draft November 1, 2024 22:02
@lahirumaramba
lahirumaramba marked this pull request as ready for review November 1, 2024 22:02
@lahirumarambalahirumaramba changed the title feat: Migrate credentials to use google-auth-librarychange: Migrate credentials to use google-auth-libraryNov 3, 2024
@lahirumarambalahirumaramba added the release:stage Stage a release candidate label Nov 3, 2024
@lahirumaramba
lahirumaramba merged commit 2144b12 into masterNov 4, 2024
@lahirumaramba
lahirumaramba deleted the lm-migrate-cred-stage1 branch November 4, 2024 20:12
This was referenced Nov 5, 2024
Closed
Merged
@ivstivivstiv mentioned this pull request Nov 19, 2024
Closed
@coderabbitaicoderabbitaiBot mentioned this pull request Apr 21, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanedeyjonathanedeyjonathanedey left review comments
+1 more reviewer
@hsubox76hsubox76hsubox76 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lahirumarambalahirumaramba

Labels

release:stageStage a release candidaterelease-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FR] Allow credential file type "external_account" when calling admin.credential.applicationDefault()

6 participants

@lahirumaramba@foxrafa@VitaliAndrushkevich@KemingHe@hsubox76@jonathanedey