Uh oh!
There was an error while loading. Please reload this page.
feat(fcm): Add HTTP2 support for sendEach() and sendEachForMulticast() - #2550
Conversation
sendEach() and sendEachForMulticastsendEach() and sendEachForMulticast()| method: 'POST', | ||
| url: mockUrl, | ||
| headers: { | ||
| 'authorization': 'Bearer token', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| method: 'POST', | ||
| url: mockUrl, | ||
| headers: { | ||
| 'authorization': 'Bearer token', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| method: 'GET', | ||
| url: mockUrl, | ||
| headers: { | ||
| 'authorization': 'Bearer token', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| method: 'HEAD', | ||
| url: mockUrl, | ||
| headers: { | ||
| 'authorization': 'Bearer token', |
Check failure
Code scanning / CodeQL
Hard-coded credentials
lahirumaramba
left a comment
There was a problem hiding this comment.
Thanks, Jonathan!
The first pass (to quickly unblock you) LGTM. I will take another look at the tests.
Let's get an internal API proposal going soon
sendEach() and sendEachForMulticast()sendEach() and sendEachForMulticast()lahirumaramba
commented
Jun 11, 2024
Thanks Jonathan! Let's make the changes we discussed in the API proposal and do another pass. We should be good to go then! |
| * ``` | ||
| * | ||
| * @deprecated This is to be removed once the HTTP/2 transport is universally safe. | ||
| */ |
There was a problem hiding this comment.
Can we get a TW review on this?
| * messaging.sendEach(messages); | ||
| * ``` | ||
| * | ||
| * @deprecated This is to be removed once the HTTP/2 transport is universally safe. |
There was a problem hiding this comment.
This is to be removed once the HTTP/2 transport implementation is universally safe. ?
There was a problem hiding this comment.
Yeah, I'm not crazy about that wording either. Can we give a more concrete criteria than safety?
There was a problem hiding this comment.
Safe here was to imply when the HTTP/2 implementation was stable enough where it was on par with the HTTP/1.1 implementation and no longer needed an emergency back up in case some functionality was completely covered.
Went with the following but open to any suggestions here:This is to be removed once the HTTP/2 transport implementation reaches the same stability as the legacy HTTP/1.1 implementation.
There was a problem hiding this comment.
That works for me!
If it's easily done, I'd tone down to "This will be removed when..."
egilmorez
left a comment
There was a problem hiding this comment.
LG! But I do have comments :)
Can you use your eagle eye and do a scrub for literals that lack backticks Lahiru? Thanks!
Uh oh!
There was an error while loading. Please reload this page.
| * messaging.sendEach(messages); | ||
| * ``` | ||
| * | ||
| * @deprecated This is to be removed once the HTTP/2 transport is universally safe. |
There was a problem hiding this comment.
Yeah, I'm not crazy about that wording either. Can we give a more concrete criteria than safety?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
egilmorez
left a comment
There was a problem hiding this comment.
LG! Thanks for fixing the literals :)
Added:
sendEach()andsendEachForMulitcast()enableLegacyTransport()When sending messages using
sendEach()orsendEachForMulitcast()a HTTP/2 connection is now used by default.In order to use the legacy HTTP/1.1 versions of these methods, the
enableLegacyTransport()method must be used. This method is already marked as deprecated and will be removed once the HTTP/2 transport is considered fully stable.Related: #2488