Skip to content

Request timeout const name correction - #2743

Merged
lahirumaramba merged 3 commits into
firebase:masterfrom
tauksun:messaging-batch-send-value
Oct 30, 2024
Merged

Request timeout const name correction#2743
lahirumaramba merged 3 commits into
firebase:masterfrom
tauksun:messaging-batch-send-value

Conversation

@tauksun

Copy link
Copy Markdown
Contributor

Request timeout value correction while sending messaging requests in a batch

@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lahirumaramba

Copy link
Copy Markdown
Member

Hey @tauksun Thank you for your contribution. This change is related to #1999
Instead of changing the timeout back to 10 seconds we should rename the constant to FIFTEEN_SECONDS_IN_MILLIS

@lahirumarambalahirumaramba changed the title request timeout value correctionRequest timeout value correctionOct 30, 2024
@lahirumarambalahirumaramba changed the title Request timeout value correctionRequest timeout const name correctionOct 30, 2024
@lahirumaramba
lahirumaramba merged commit 8bb5691 into firebase:masterOct 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tauksun@lahirumaramba