Skip to content

feat(fcm): Added support for specifying the analytics label for notifications. - #597

Merged
hiranya911 merged 7 commits into
firebase:masterfrom
chemidy:analytics_label
Aug 12, 2019
Merged

feat(fcm): Added support for specifying the analytics label for notifications.#597
hiranya911 merged 7 commits into
firebase:masterfrom
chemidy:analytics_label

Conversation

@chemidy

@chemidychemidy commented Jul 20, 2019

Copy link
Copy Markdown
Contributor

hiranya911
hiranya911 suggested changes Jul 22, 2019
View reviewed changes
Comment threadsrc/messaging/messaging-types.ts
hiranya911
hiranya911 reviewed Jul 22, 2019
View reviewed changes
Comment threadtest/unit/messaging/messaging.spec.ts
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes
Comment threadsrc/index.d.ts Outdated
egilmorez
egilmorez reviewed Jul 22, 2019
View reviewed changes

@egilmorezegilmorez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some style comments. Thanks for the PR!

egilmorez
egilmorez approved these changes Jul 25, 2019
View reviewed changes

@egilmorezegilmorez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.d.ts content looks good, thanks chemidy!

hiranya911
hiranya911 suggested changes Jul 25, 2019
View reviewed changes

@hiranya911hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need some test cases for the new validators.

And I'm also waiting to hear from the FCM team about fcmOptions vs fcm_options in the JSON payload.

Comment threadtest/unit/messaging/messaging.spec.ts
hiranya911
hiranya911 approved these changes Aug 12, 2019
View reviewed changes

@hiranya911hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911hiranya911 changed the title Analytics labelfeat(fcm): Added support for specifying the analytics label for notifications.Aug 12, 2019
@hiranya911
hiranya911 merged commit d05dd23 into firebase:masterAug 12, 2019
@chemidy
chemidy deleted the analytics_label branch August 15, 2019 01:51
@hiranya911hiranya911 mentioned this pull request Aug 15, 2019
Closed
@parndtparndt mentioned this pull request Aug 21, 2019
Closed
@snyk-botsnyk-bot mentioned this pull request Oct 26, 2019
Open
This was referenced Nov 13, 2019
Closed
Closed
Closed
Closed
This was referenced Mar 10, 2020
Closed
Merged
@snyk-botsnyk-bot mentioned this pull request Apr 21, 2020
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@chong-shaochong-shaochong-shao left review comments
@hiranya911hiranya911hiranya911 approved these changes
@egilmorezegilmorezegilmorez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@hiranya911hiranya911

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chemidy@hiranya911@egilmorez@chong-shao